[GitHub] [incubator-pinot] icefury71 commented on issue #4585: Presence vector

[GitBox <gi...@apache.org>]

icefury71 commented on issue #4585: Presence vector
URL: https://github.com/apache/incubator-pinot/pull/4585#issuecomment-546119575
 
 
   > Good in general.
   > I still feel it is better to make it NullValueVector for the following reasons:
   > 
   > * Underlying bitmap is nullValueBitmap
   > * Always set null instead of set non-null
   > * We only need to check whether the value is null (all the return for isPresent() is reversed)
   > 
   > I understand the intention for PresenceVector is to fast return the presenceBitmap, but if the underlying storage is actually a nullValueBitmap, it is quite confusing. In the following PRs, we can maintain two bitmaps in memory, but still only store nullValueBitmap on disk. @kishoreg Thoughts?
   
   Modified to NullValueVector as per suggestion

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org