[GitHub] [apisix] Firstsawyou opened a new issue #3453: bug: limit-xxx plugin schema bug

[GitBox <gi...@apache.org>]

Firstsawyou opened a new issue #3453:
URL: https://github.com/apache/apisix/issues/3453


   ### Issue description
   
   limit-count:
   
   When the `count` or `time_window` fields of the limit-count plugin are 0, the plugin is not available.
   
   Repair method:
   It should be greater than 0 in the schema. Need to provide response test cases.
   
   limit-conn:
   
   When the `conn` 、`burst` or `default_conn_delay` fields of the limit-conn plugin are 0, the plugin is not available.
   
   Repair method:
   It should be greater than 0 in the schema. Need to provide response test cases.
   
   imit-req:
   
   When the `rate` or `burst`  fields of the limit-req plugin are 0, the plugin is not available.
   
   Repair method:
   It should be greater than 0 in the schema. Need to provide response test cases.
   
   ### Environment
   
   * apisix version (cmd: `apisix version`): 2.2
   * OS (cmd: `uname -a`):  Liunx
   * OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`): nginx version: openresty/1.19.3.1
   * etcd version, if have (cmd: run `curl http://127.0.0.1:9090/v1/server_info` to get the info from server-info API):
   * apisix-dashboard version, if have:
   
   ### Minimal test code / Steps to reproduce the issue
   
   1. add route
   
   ```shell
   curl -i http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
   {
       "uri": "/hello",
       "plugins": {
           "limit-count": {
               "count": 0,
               "time_window": 60,
               "rejected_code": 503,
               "key": "remote_addr"
           }
       },
       "upstream": {
           "type": "roundrobin",
           "nodes": {
               "127.0.0.1:1980": 1
           }
       }
   }'
   ```
   2. test plugin:
   
   ```shell
   curl -i http://127.0.0.1:9080/hello
   HTTP/1.1 500 Internal Server Error
   Date: Fri, 29 Jan 2021 04:14:01 GMT
   Content-Type: text/html; charset=utf-8
   Content-Length: 174
   Connection: close
   Server: APISIX/2.2
   
   <html>
   <head><title>500 Internal Server Error</title></head>
   <body>
   <center><h1>500 Internal Server Error</h1></center>
   <hr><center>openresty</center>
   </body>
   </html>
   
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander closed issue #3453: bug: limit-xxx plugins schema bug

[GitBox <gi...@apache.org>]

spacewander closed issue #3453:
URL: https://github.com/apache/apisix/issues/3453


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org