You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@jclouds.apache.org by Josef Cacek <no...@github.com> on 2015/09/17 18:53:58 UTC

[jclouds-labs] JCLOUDS-997 Allow nullable docker configuration (cmd, entrypoint, env) (#203)

https://issues.apache.org/jira/browse/JCLOUDS-997

This commit allows null values for List Config entries.

The `null` has another meaning than en empty `List`.  E.g. when using `CMD` from Docker remote API then  `null` value means "use the image default", on the other hand the empty List has meaning "don't provide any command".

The `entrypoint` configuration is now available in `DockerTemplateOptions`.

Other 2 nullable field fixes were probably a typos in the `Config` class:
* `hostConfig`
* `dns`
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds-labs/pull/203

-- Commit Summary --

  * JCLOUDS-997 Allow nullable docker configuration - the null has another meaning than empty list/map (e.g. CMD: null=default, emptyList=no-command)

-- File Changes --

    M docker/src/main/java/org/jclouds/docker/compute/options/DockerTemplateOptions.java (57)
    M docker/src/main/java/org/jclouds/docker/compute/strategy/DockerComputeServiceAdapter.java (13)
    M docker/src/main/java/org/jclouds/docker/domain/Config.java (25)
    M docker/src/main/java/org/jclouds/docker/internal/NullSafeCopies.java (40)
    M docker/src/test/java/org/jclouds/docker/compute/options/DockerTemplateOptionsTest.java (9)
    A docker/src/test/java/org/jclouds/docker/domain/ConfigTest.java (65)

-- Patch Links --

https://github.com/jclouds/jclouds-labs/pull/203.patch
https://github.com/jclouds/jclouds-labs/pull/203.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/203

Re: [jclouds-labs] JCLOUDS-997 Allow nullable docker configuration (cmd, entrypoint, env) (#203)

Posted by Ignasi Barrera <no...@github.com>.

Closed #203.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/203#event-413011814

Re: [jclouds-labs] JCLOUDS-997 Allow nullable docker configuration (cmd, entrypoint, env) (#203)

Posted by Ignasi Barrera <no...@github.com>.

Pushed to [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/3440a0b5) and [1.9.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/e3dede23). Thanks @kwart!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/203#issuecomment-141387112