[jira] Commented: (WODEN-59) NPE on W3C Test Case Storage-4G/storage.wsdl

["Jeremy Hughes (JIRA)" <ji...@apache.org>]

    [ http://issues.apache.org/jira/browse/WODEN-59?page=comments#action_12438137 ] 
            
Jeremy Hughes commented on WODEN-59:
------------------------------------

CmWriter line 375 does:

        out.write("messageLabel", component.getMessageLabel().toString());

The MessageLabel object returned is null. It is null because there isn't one specified in the <outfault> in the WSDL - which is allowed as the attribute is optional. However, the {message label} property is a required one on the InterfaceFaultReference component so we need to derive one. I believe in this case the {message label} should be 'Out'. Why? Because the {message exchange pattern} is http://www.w3.org/2006/01/wsdl/in-out which is defined in §2.3.3 of part 2 of the spec as:

-----
2.3.3 In-Out

This pattern consists of exactly two messages, in order, as follows:†

   1. A message:
          * indicated by a Interface Message Reference component whose {message label} is "In" and {direction} is "in"
          * received from some node N
   2. A message:
          * indicated by a Interface Message Reference component whose {message label} is "Out" and {direction} is "out"
          * sent to node N

This pattern uses the rule 2.2.1 Fault Replaces Message.†

An operation using this message exchange pattern has a {message exchange pattern} property with the value "http://www.w3.org/@@@@/@@/wsdl/in-out". 
-----

Under these rules, the only possible value for {message label} is 'Out' because the only way a fault message can occur is by using the 'fault replaces message' rule on the 2nd (Out) message. For this MEP there is only one possibility however for other MEPs the answer may be ambiguous. What should we do in these circumstances? Assuming we can figure that out we should have an object representation of each MEP so we can figure out the 'default' message label on a per message level. 

Alternatively we could ask the working group to make messageLabel a required attribute, thereby making it trivial to populate the {message level} property.

Any comments?

> NPE on W3C Test Case Storage-4G/storage.wsdl
> --------------------------------------------
>
>                 Key: WODEN-59
>                 URL: http://issues.apache.org/jira/browse/WODEN-59
>             Project: Woden
>          Issue Type: Bug
>            Reporter: Arthur Ryman
>
> I ran ant-test/build.xml and hit a NPE.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org