You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/07/01 06:46:30 UTC

[GitHub] [superset] simcha90 commented on pull request #15454: feat(dashboard-groupby): group by - add ability to exclude columns

simcha90 commented on pull request #15454:
URL: https://github.com/apache/superset/pull/15454#issuecomment-871971913


   > A few nits. Also, I haven't much used this feature, but in testing I got this strange result (it doesn't seem to apply properly, and the indicator is showing as not applied):
   > ![image](https://user-images.githubusercontent.com/33317356/124077300-0a4d2980-da50-11eb-9033-73e00f6f8658.png)
   > Is this filter working in your env properly?
   
   I checked it works properly, this filter should add columns to the table that added in filter and not filter them out :), about badge note, I think we can open other issue for because it's not a part of this PR :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org