You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yao Xu (Code Review)" <ge...@cloudera.org> on 2019/06/21 09:21:39 UTC
[kudu-CR] [docs] Add docs for extra configuration properties
Yao Xu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13704
Change subject: [docs] Add docs for extra configuration properties
......................................................................
[docs] Add docs for extra configuration properties
Change-Id: I7fe61efeafa9bd9d4cf62a378b6c4c7039bbcf6b
---
M docs/configuration.adoc
1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/13704/1
--
To view, visit http://gerrit.cloudera.org:8080/13704
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7fe61efeafa9bd9d4cf62a378b6c4c7039bbcf6b
Gerrit-Change-Number: 13704
Gerrit-PatchSet: 1
Gerrit-Owner: Yao Xu <oc...@gmail.com>
[kudu-CR] [docs] Add docs for extra configuration properties
Posted by "Yao Xu (Code Review)" <ge...@cloudera.org>.
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13704 )
Change subject: [docs] Add docs for extra configuration properties
......................................................................
Patch Set 3:
(3 comments)
Thanks for comments, it looks much better now. :D
http://gerrit.cloudera.org:8080/#/c/13704/1/docs/configuration.adoc
File docs/configuration.adoc:
http://gerrit.cloudera.org:8080/#/c/13704/1/docs/configuration.adoc@143
PS1, Line 143: Kudu allows certain configurations to be set per table. To configure the behavior of a Kudu table,
: you can set th
> nit: maybe add a little context about table-level configurations. Something
Done
http://gerrit.cloudera.org:8080/#/c/13704/1/docs/configuration.adoc@146
PS1, Line 146:
> nit: maybe "Configurable Properties"?
Done
http://gerrit.cloudera.org:8080/#/c/13704/1/docs/configuration.adoc@150
PS1, Line 150:
> I see. I agree isn't the most future proof thing ever. How about let's remo
Done
--
To view, visit http://gerrit.cloudera.org:8080/13704
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fe61efeafa9bd9d4cf62a378b6c4c7039bbcf6b
Gerrit-Change-Number: 13704
Gerrit-PatchSet: 3
Gerrit-Owner: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yao Xu <oc...@gmail.com>
Gerrit-Comment-Date: Tue, 25 Jun 2019 04:13:46 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add docs for extra configuration properties
Posted by "Yao Xu (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13704
to look at the new patch set (#4).
Change subject: [docs] Add docs for extra configuration properties
......................................................................
[docs] Add docs for extra configuration properties
Change-Id: I7fe61efeafa9bd9d4cf62a378b6c4c7039bbcf6b
---
M docs/configuration.adoc
1 file changed, 11 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/13704/4
--
To view, visit http://gerrit.cloudera.org:8080/13704
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7fe61efeafa9bd9d4cf62a378b6c4c7039bbcf6b
Gerrit-Change-Number: 13704
Gerrit-PatchSet: 4
Gerrit-Owner: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yao Xu <oc...@gmail.com>
[kudu-CR] [docs] Add docs for extra configuration properties
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13704 )
Change subject: [docs] Add docs for extra configuration properties
......................................................................
Patch Set 1:
(1 comment)
Thanks for this change! Sorry for the late review.
Could you upload this to your github and post a link to the page so it can be rendered, e.g. https://github.com/apache/kudu/blob/master/docs/configuration.adoc
http://gerrit.cloudera.org:8080/#/c/13704/1/docs/configuration.adoc
File docs/configuration.adoc:
http://gerrit.cloudera.org:8080/#/c/13704/1/docs/configuration.adoc@150
PS1, Line 150:
For 1.10+, this should be 60 * 60 * 24 * 7 (7 days)
--
To view, visit http://gerrit.cloudera.org:8080/13704
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fe61efeafa9bd9d4cf62a378b6c4c7039bbcf6b
Gerrit-Change-Number: 13704
Gerrit-PatchSet: 1
Gerrit-Owner: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 22 Jun 2019 02:55:56 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add docs for extra configuration properties
Posted by "Yao Xu (Code Review)" <ge...@cloudera.org>.
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13704 )
Change subject: [docs] Add docs for extra configuration properties
......................................................................
Patch Set 2:
(1 comment)
> (1 comment)
>
> Thanks for this change! Sorry for the late review.
>
> Could you upload this to your github and post a link to the page so
> it can be rendered, e.g. https://github.com/apache/kudu/blob/master/docs/configuration.adoc
Wow, cool. https://github.com/oclarms/kudu/blob/KUDU-2514/docs/configuration.adoc
http://gerrit.cloudera.org:8080/#/c/13704/1/docs/configuration.adoc
File docs/configuration.adoc:
http://gerrit.cloudera.org:8080/#/c/13704/1/docs/configuration.adoc@150
PS1, Line 150: U
> For 1.10+, this should be 60 * 60 * 24 * 7 (7 days)
I think this may be a bit inaccurate. For example, if I change the tablet_history_max_age_sec of tablet server by gflags, then the default value here is wrong. Maybe we should write like this: Use tablet_history_max_age_sec of Tablet Server
--
To view, visit http://gerrit.cloudera.org:8080/13704
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fe61efeafa9bd9d4cf62a378b6c4c7039bbcf6b
Gerrit-Change-Number: 13704
Gerrit-PatchSet: 2
Gerrit-Owner: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yao Xu <oc...@gmail.com>
Gerrit-Comment-Date: Sat, 22 Jun 2019 03:51:59 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add docs for extra configuration properties
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13704 )
Change subject: [docs] Add docs for extra configuration properties
......................................................................
Patch Set 4: Code-Review+2
Thanks again! :)
--
To view, visit http://gerrit.cloudera.org:8080/13704
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fe61efeafa9bd9d4cf62a378b6c4c7039bbcf6b
Gerrit-Change-Number: 13704
Gerrit-PatchSet: 4
Gerrit-Owner: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yao Xu <oc...@gmail.com>
Gerrit-Comment-Date: Tue, 25 Jun 2019 05:31:53 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] Add docs for extra configuration properties
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13704 )
Change subject: [docs] Add docs for extra configuration properties
......................................................................
[docs] Add docs for extra configuration properties
Change-Id: I7fe61efeafa9bd9d4cf62a378b6c4c7039bbcf6b
Reviewed-on: http://gerrit.cloudera.org:8080/13704
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Tested-by: Kudu Jenkins
---
M docs/configuration.adoc
1 file changed, 11 insertions(+), 0 deletions(-)
Approvals:
Andrew Wong: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/13704
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7fe61efeafa9bd9d4cf62a378b6c4c7039bbcf6b
Gerrit-Change-Number: 13704
Gerrit-PatchSet: 5
Gerrit-Owner: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yao Xu <oc...@gmail.com>
[kudu-CR] [docs] Add docs for extra configuration properties
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13704 )
Change subject: [docs] Add docs for extra configuration properties
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
One last thing and this looks good to go.
http://gerrit.cloudera.org:8080/#/c/13704/3/docs/configuration.adoc
File docs/configuration.adoc:
http://gerrit.cloudera.org:8080/#/c/13704/3/docs/configuration.adoc@142
PS3, Line 142: Table
nit: Tables
--
To view, visit http://gerrit.cloudera.org:8080/13704
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fe61efeafa9bd9d4cf62a378b6c4c7039bbcf6b
Gerrit-Change-Number: 13704
Gerrit-PatchSet: 3
Gerrit-Owner: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yao Xu <oc...@gmail.com>
Gerrit-Comment-Date: Tue, 25 Jun 2019 04:44:02 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add docs for extra configuration properties
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13704 )
Change subject: [docs] Add docs for extra configuration properties
......................................................................
Patch Set 2:
(3 comments)
> Patch Set 2:
>
> (1 comment)
>
> > (1 comment)
> >
> > Thanks for this change! Sorry for the late review.
> >
> > Could you upload this to your github and post a link to the page so
> > it can be rendered, e.g. https://github.com/apache/kudu/blob/master/docs/configuration.adoc
>
> Wow, cool. https://github.com/oclarms/kudu/blob/KUDU-2514/docs/configuration.adoc
Thanks! :D
http://gerrit.cloudera.org:8080/#/c/13704/1/docs/configuration.adoc
File docs/configuration.adoc:
http://gerrit.cloudera.org:8080/#/c/13704/1/docs/configuration.adoc@143
PS1, Line 143: To configure the behavior of each Kudu table, you can set or alter these configurations
: by API or CLI.
nit: maybe add a little context about table-level configurations. Something like.
Kudu allows certain configurations to be set per table. To configure the behavior of a Kudu table, you can set these configurations at table creation, or alter them via the Kudu API or Kudu command line tool.
http://gerrit.cloudera.org:8080/#/c/13704/1/docs/configuration.adoc@146
PS1, Line 146: Configuration
nit: maybe "Configurable Properties"?
http://gerrit.cloudera.org:8080/#/c/13704/1/docs/configuration.adoc@150
PS1, Line 150: U
> > For 1.10+, this should be 60 * 60 * 24 * 7 (7 days)
I see. I agree isn't the most future proof thing ever. How about let's remove the "Default" column here entirely, since I think most defaults will be to use the tserver default.
--
To view, visit http://gerrit.cloudera.org:8080/13704
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fe61efeafa9bd9d4cf62a378b6c4c7039bbcf6b
Gerrit-Change-Number: 13704
Gerrit-PatchSet: 2
Gerrit-Owner: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yao Xu <oc...@gmail.com>
Gerrit-Comment-Date: Mon, 24 Jun 2019 17:40:26 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add docs for extra configuration properties
Posted by "Yao Xu (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13704
to look at the new patch set (#3).
Change subject: [docs] Add docs for extra configuration properties
......................................................................
[docs] Add docs for extra configuration properties
Change-Id: I7fe61efeafa9bd9d4cf62a378b6c4c7039bbcf6b
---
M docs/configuration.adoc
1 file changed, 11 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/13704/3
--
To view, visit http://gerrit.cloudera.org:8080/13704
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7fe61efeafa9bd9d4cf62a378b6c4c7039bbcf6b
Gerrit-Change-Number: 13704
Gerrit-PatchSet: 3
Gerrit-Owner: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yao Xu <oc...@gmail.com>
[kudu-CR] [docs] Add docs for extra configuration properties
Posted by "Yao Xu (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13704
to look at the new patch set (#2).
Change subject: [docs] Add docs for extra configuration properties
......................................................................
[docs] Add docs for extra configuration properties
Change-Id: I7fe61efeafa9bd9d4cf62a378b6c4c7039bbcf6b
---
M docs/configuration.adoc
1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/13704/2
--
To view, visit http://gerrit.cloudera.org:8080/13704
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7fe61efeafa9bd9d4cf62a378b6c4c7039bbcf6b
Gerrit-Change-Number: 13704
Gerrit-PatchSet: 2
Gerrit-Owner: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)