[GitHub] [superset] sourcecode-glitch opened a new issue #16757: [Helm Chart] Init job marked as success despite errors

[GitBox <gi...@apache.org>]

sourcecode-glitch opened a new issue #16757:
URL: https://github.com/apache/superset/issues/16757


   The init job is marked as success in kubernetes despite errors. In my case the database upgrade failed, however this bug effects all errors happening in the init script (except the last command). The script does not exit immediately when encountering an error. Instead it continues with the next line, only using the error code from the last line in the script. This means that even after a successful helm deployment, one needs to check the init job logs to see if it was *actually* successful.
   
   ### Expected results
   Kubernetes job should be marked as failed.
   
   ### Actual results
   Kubernetes job is marked as success
   
   ### How to reproduce the bug
   
   1. Make the init job fail. In my case the database tables had a wrong owner, so superset was unable to alter the table structure.
   2. Deploy to kubernetes using the helm chart
   
   ### Environment
   - helm chart from latest git (at commit a8d53429)
   - helm client version: v3.6.3
   
   ### Checklist
   - [x] I have checked the superset logs for python stacktraces and included it here as text if there are any. (not applicable since it's a deployment related bug)
   - [x] I have reproduced the issue with at least the latest released version of superset.
   - [x] I have checked the issue tracker for the same issue and I haven't found one similar.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] craig-rueda closed issue #16757: [Helm Chart] Init job marked as success despite errors

[GitBox <gi...@apache.org>]

craig-rueda closed issue #16757:
URL: https://github.com/apache/superset/issues/16757


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org