[GitHub] [helix] jiajunwang commented on a change in pull request #688: Fix the watcher leakage issue

[GitBox <gi...@apache.org>]

jiajunwang commented on a change in pull request #688: Fix the watcher leakage issue
URL: https://github.com/apache/helix/pull/688#discussion_r368312400
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/manager/zk/zookeeper/ZkClient.java
 ##########
 @@ -145,32 +145,28 @@ public int hashCode() {
 
   private class ZkPathStatRecord {
     private final String _path;
-    private Stat _stat = null;
-    private boolean _checked = false;
+    private AtomicBoolean _isChecked = new AtomicBoolean(false);
 
 Review comment:
   Can you please explain why we need to change this value to Atomic?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org