[jira] [Commented] (KARAF-4511) grep leaves around Ansi reset char sequence

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KARAF-4511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15264005#comment-15264005 ] 

ASF GitHub Bot commented on KARAF-4511:
---------------------------------------

GitHub user paoloantinori opened a pull request:

    https://github.com/apache/karaf/pull/180

    KARAF-4511 - grep, fixed '--color never' support

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/paoloantinori/karaf ENTESB-4155

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/karaf/pull/180.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #180
    
----
commit 29bf1577ab8fd9f0ca23ebd4ccb6aa710566957c
Author: Paolo Antinori <pa...@redhat.com>
Date:   2016-04-29T12:40:55Z

    KARAF-4511 - grep, fixed '--color never' support

----


> grep leaves around Ansi reset char sequence
> -------------------------------------------
>
>                 Key: KARAF-4511
>                 URL: https://issues.apache.org/jira/browse/KARAF-4511
>             Project: Karaf
>          Issue Type: Bug
>    Affects Versions: 4.0.5
>            Reporter: Paolo Antinori
>
> {{grep}} command, injects an Ansi char sequence to close the markup/highlighting of the found token.
> It shouldn't do it when the command is invoked with the {{--color never}} flag.
> The current erroneous behavior, produces this output:
> {code}
> echo abc | grep --color never
> abXc
> {code}
> where {{X}} is the Ansi reset sequence, injected here:
> https://github.com/jboss-fuse/karaf/blob/2e2b9324d4a65076b119239edc8920185914dc60/shell/commands/src/main/java/org/apache/karaf/shell/commands/impl/GrepAction.java#L144



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)