You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by ge...@apache.org on 2011/07/27 06:59:29 UTC

svn commit: r1151330 - in /openejb/trunk/openejb3/deps: javaee-api-embedded/pom.xml javaee-api/pom.xml

Author: genspring
Date: Wed Jul 27 04:59:28 2011
New Revision: 1151330

URL: http://svn.apache.org/viewvc?rev=1151330&view=rev
Log:
Remove the version from exported javax.transaction packages.

Modified:
    openejb/trunk/openejb3/deps/javaee-api-embedded/pom.xml
    openejb/trunk/openejb3/deps/javaee-api/pom.xml

Modified: openejb/trunk/openejb3/deps/javaee-api-embedded/pom.xml
URL: http://svn.apache.org/viewvc/openejb/trunk/openejb3/deps/javaee-api-embedded/pom.xml?rev=1151330&r1=1151329&r2=1151330&view=diff
==============================================================================
--- openejb/trunk/openejb3/deps/javaee-api-embedded/pom.xml (original)
+++ openejb/trunk/openejb3/deps/javaee-api-embedded/pom.xml Wed Jul 27 04:59:28 2011
@@ -71,8 +71,8 @@
                       javax.enterprise.deploy.spi, javax.enterprise.deploy.spi.exceptions,
                       javax.enterprise.deploy.spi.factories, javax.enterprise.deploy.spi.status, javax.management,
                       javax.management.j2ee, javax.management.j2ee.statistics, javax.security, javax.security.jacc,
-                      javax.jms, javax.persistence, javax.persistence.spi, javax.transaction;version="5.0",
-                      javax.transaction.xa;version="5.0",
+                      javax.jms, javax.persistence, javax.persistence.spi, javax.transaction,
+                      javax.transaction.xa,
                       javax.jws, javax.jws.soap, org.apache.geronimo, org.apache.geronimo.mail,
                       org.apache.geronimo.mail.handlers, org.apache.geronimo.mail.util
                     </Export-Package>

Modified: openejb/trunk/openejb3/deps/javaee-api/pom.xml
URL: http://svn.apache.org/viewvc/openejb/trunk/openejb3/deps/javaee-api/pom.xml?rev=1151330&r1=1151329&r2=1151330&view=diff
==============================================================================
--- openejb/trunk/openejb3/deps/javaee-api/pom.xml (original)
+++ openejb/trunk/openejb3/deps/javaee-api/pom.xml Wed Jul 27 04:59:28 2011
@@ -70,8 +70,8 @@
                       javax.enterprise.deploy.spi, javax.enterprise.deploy.spi.exceptions,
                       javax.enterprise.deploy.spi.factories, javax.enterprise.deploy.spi.status, javax.management,
                       javax.management.j2ee, javax.management.j2ee.statistics, javax.security, javax.security.jacc,
-                      javax.jms, javax.persistence, javax.persistence.spi, javax.transaction;version="5.0",
-                      javax.transaction.xa;version="5.0", javax.servlet, javax.servlet.http, javax.servlet.resources,
+                      javax.jms, javax.persistence, javax.persistence.spi, javax.transaction,
+                      javax.transaction.xa, javax.servlet, javax.servlet.http, javax.servlet.resources,
                       javax.jws, javax.ws.rs, javax.jws.soap, org.apache.geronimo, org.apache.geronimo.mail,
                       org.apache.geronimo.mail.handlers, org.apache.geronimo.mail.util
                     </Export-Package>



Re: svn commit: r1151330 - in /openejb/trunk/openejb3/deps: javaee-api-embedded/pom.xml javaee-api/pom.xml

Posted by David Jencks <da...@yahoo.com>.
IMO these jars should be generated using the maven-bundle-plugin not the shade plugin since there's some chance of ending up with more correct package versions.  IIRC the problem when I tried this was that I didn't mark all the maven dependencies provided.

david jencks

On Jul 26, 2011, at 10:03 PM, Shawn Jiang wrote:

> I don't see a reason to export javax.transaction with a version here.  If we
> need,  the version should be 1.1 instead of 5.0.
> 
> Please correct me if it breaks anything.
> 
> On Wed, Jul 27, 2011 at 12:59 PM, <ge...@apache.org> wrote:
> 
>> Author: genspring
>> Date: Wed Jul 27 04:59:28 2011
>> New Revision: 1151330
>> 
>> URL: http://svn.apache.org/viewvc?rev=1151330&view=rev
>> Log:
>> Remove the version from exported javax.transaction packages.
>> 
>> Modified:
>>   openejb/trunk/openejb3/deps/javaee-api-embedded/pom.xml
>>   openejb/trunk/openejb3/deps/javaee-api/pom.xml
>> 
>> Modified: openejb/trunk/openejb3/deps/javaee-api-embedded/pom.xml
>> URL:
>> http://svn.apache.org/viewvc/openejb/trunk/openejb3/deps/javaee-api-embedded/pom.xml?rev=1151330&r1=1151329&r2=1151330&view=diff
>> 
>> ==============================================================================
>> --- openejb/trunk/openejb3/deps/javaee-api-embedded/pom.xml (original)
>> +++ openejb/trunk/openejb3/deps/javaee-api-embedded/pom.xml Wed Jul 27
>> 04:59:28 2011
>> @@ -71,8 +71,8 @@
>>                      javax.enterprise.deploy.spi,
>> javax.enterprise.deploy.spi.exceptions,
>>                      javax.enterprise.deploy.spi.factories,
>> javax.enterprise.deploy.spi.status, javax.management,
>>                      javax.management.j2ee,
>> javax.management.j2ee.statistics, javax.security, javax.security.jacc,
>> -                      javax.jms, javax.persistence, javax.persistence.spi,
>> javax.transaction;version="5.0",
>> -                      javax.transaction.xa;version="5.0",
>> +                      javax.jms, javax.persistence, javax.persistence.spi,
>> javax.transaction,
>> +                      javax.transaction.xa,
>>                      javax.jws, javax.jws.soap, org.apache.geronimo,
>> org.apache.geronimo.mail,
>>                      org.apache.geronimo.mail.handlers,
>> org.apache.geronimo.mail.util
>>                    </Export-Package>
>> 
>> Modified: openejb/trunk/openejb3/deps/javaee-api/pom.xml
>> URL:
>> http://svn.apache.org/viewvc/openejb/trunk/openejb3/deps/javaee-api/pom.xml?rev=1151330&r1=1151329&r2=1151330&view=diff
>> 
>> ==============================================================================
>> --- openejb/trunk/openejb3/deps/javaee-api/pom.xml (original)
>> +++ openejb/trunk/openejb3/deps/javaee-api/pom.xml Wed Jul 27 04:59:28 2011
>> @@ -70,8 +70,8 @@
>>                      javax.enterprise.deploy.spi,
>> javax.enterprise.deploy.spi.exceptions,
>>                      javax.enterprise.deploy.spi.factories,
>> javax.enterprise.deploy.spi.status, javax.management,
>>                      javax.management.j2ee,
>> javax.management.j2ee.statistics, javax.security, javax.security.jacc,
>> -                      javax.jms, javax.persistence, javax.persistence.spi,
>> javax.transaction;version="5.0",
>> -                      javax.transaction.xa;version="5.0", javax.servlet,
>> javax.servlet.http, javax.servlet.resources,
>> +                      javax.jms, javax.persistence, javax.persistence.spi,
>> javax.transaction,
>> +                      javax.transaction.xa, javax.servlet,
>> javax.servlet.http, javax.servlet.resources,
>>                      javax.jws, javax.ws.rs, javax.jws.soap,
>> org.apache.geronimo, org.apache.geronimo.mail,
>>                      org.apache.geronimo.mail.handlers,
>> org.apache.geronimo.mail.util
>>                    </Export-Package>
>> 
>> 
>> 
> 
> 
> -- 
> Shawn


Re: svn commit: r1151330 - in /openejb/trunk/openejb3/deps: javaee-api-embedded/pom.xml javaee-api/pom.xml

Posted by Shawn Jiang <ge...@gmail.com>.
I don't see a reason to export javax.transaction with a version here.  If we
need,  the version should be 1.1 instead of 5.0.

Please correct me if it breaks anything.

On Wed, Jul 27, 2011 at 12:59 PM, <ge...@apache.org> wrote:

> Author: genspring
> Date: Wed Jul 27 04:59:28 2011
> New Revision: 1151330
>
> URL: http://svn.apache.org/viewvc?rev=1151330&view=rev
> Log:
> Remove the version from exported javax.transaction packages.
>
> Modified:
>    openejb/trunk/openejb3/deps/javaee-api-embedded/pom.xml
>    openejb/trunk/openejb3/deps/javaee-api/pom.xml
>
> Modified: openejb/trunk/openejb3/deps/javaee-api-embedded/pom.xml
> URL:
> http://svn.apache.org/viewvc/openejb/trunk/openejb3/deps/javaee-api-embedded/pom.xml?rev=1151330&r1=1151329&r2=1151330&view=diff
>
> ==============================================================================
> --- openejb/trunk/openejb3/deps/javaee-api-embedded/pom.xml (original)
> +++ openejb/trunk/openejb3/deps/javaee-api-embedded/pom.xml Wed Jul 27
> 04:59:28 2011
> @@ -71,8 +71,8 @@
>                       javax.enterprise.deploy.spi,
> javax.enterprise.deploy.spi.exceptions,
>                       javax.enterprise.deploy.spi.factories,
> javax.enterprise.deploy.spi.status, javax.management,
>                       javax.management.j2ee,
> javax.management.j2ee.statistics, javax.security, javax.security.jacc,
> -                      javax.jms, javax.persistence, javax.persistence.spi,
> javax.transaction;version="5.0",
> -                      javax.transaction.xa;version="5.0",
> +                      javax.jms, javax.persistence, javax.persistence.spi,
> javax.transaction,
> +                      javax.transaction.xa,
>                       javax.jws, javax.jws.soap, org.apache.geronimo,
> org.apache.geronimo.mail,
>                       org.apache.geronimo.mail.handlers,
> org.apache.geronimo.mail.util
>                     </Export-Package>
>
> Modified: openejb/trunk/openejb3/deps/javaee-api/pom.xml
> URL:
> http://svn.apache.org/viewvc/openejb/trunk/openejb3/deps/javaee-api/pom.xml?rev=1151330&r1=1151329&r2=1151330&view=diff
>
> ==============================================================================
> --- openejb/trunk/openejb3/deps/javaee-api/pom.xml (original)
> +++ openejb/trunk/openejb3/deps/javaee-api/pom.xml Wed Jul 27 04:59:28 2011
> @@ -70,8 +70,8 @@
>                       javax.enterprise.deploy.spi,
> javax.enterprise.deploy.spi.exceptions,
>                       javax.enterprise.deploy.spi.factories,
> javax.enterprise.deploy.spi.status, javax.management,
>                       javax.management.j2ee,
> javax.management.j2ee.statistics, javax.security, javax.security.jacc,
> -                      javax.jms, javax.persistence, javax.persistence.spi,
> javax.transaction;version="5.0",
> -                      javax.transaction.xa;version="5.0", javax.servlet,
> javax.servlet.http, javax.servlet.resources,
> +                      javax.jms, javax.persistence, javax.persistence.spi,
> javax.transaction,
> +                      javax.transaction.xa, javax.servlet,
> javax.servlet.http, javax.servlet.resources,
>                       javax.jws, javax.ws.rs, javax.jws.soap,
> org.apache.geronimo, org.apache.geronimo.mail,
>                       org.apache.geronimo.mail.handlers,
> org.apache.geronimo.mail.util
>                     </Export-Package>
>
>
>


-- 
Shawn