You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "AnandInguva (via GitHub)" <gi...@apache.org> on 2023/01/23 19:33:44 UTC
[GitHub] [beam] AnandInguva opened a new pull request, #25123: Update tox to 4.x.x
AnandInguva opened a new pull request, #25123:
URL: https://github.com/apache/beam/pull/25123
Update tox to the latest major verison.
Remove the version bound on tox
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva closed pull request #25123: Update tox to 4.x.x
Posted by "AnandInguva (via GitHub)" <gi...@apache.org>.
AnandInguva closed pull request #25123: Update tox to 4.x.x
URL: https://github.com/apache/beam/pull/25123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on pull request #25123: Update tox to 4.x.x
Posted by "AnandInguva (via GitHub)" <gi...@apache.org>.
AnandInguva commented on PR #25123:
URL: https://github.com/apache/beam/pull/25123#issuecomment-1402127967
@damccorm I should have marked this a draft. I am not sure yet why it is behaving the way it is(running gen_protos.py solved but we do run gen_protos inside setup.py but it doesn't work).
I am going to ask on the tox channel. This could be the way tox builds sdist(which follows PEP 517, 518) but we didn't yet migrate to PEP 517, 518
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on pull request #25123: Update tox to 4.x.x
Posted by "AnandInguva (via GitHub)" <gi...@apache.org>.
AnandInguva commented on PR #25123:
URL: https://github.com/apache/beam/pull/25123#issuecomment-1464050514
Closing wrt #25785
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #25123: Update tox to 4.x.x
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #25123:
URL: https://github.com/apache/beam/pull/25123#discussion_r1085448799
##########
sdks/python/tox.ini:
##########
@@ -17,6 +17,8 @@
[tox]
# new environments will be excluded by default unless explicitly added to envlist.
+requires =
+ grpcio-tools==1.37.0
Review Comment:
Do you know why we now need this dependency?
##########
.github/workflows/python_tests.yml:
##########
@@ -116,16 +116,19 @@ jobs:
- name: Get build dependencies
working-directory: ./sdks/python
run: pip install -r build-requirements.txt
+ - name: Generate protos
+ working-directory: ./sdks/python
+ run: python gen_protos.py
Review Comment:
Why do we need this step now when we didn't before?
##########
.github/workflows/python_tests.yml:
##########
@@ -116,16 +116,19 @@ jobs:
- name: Get build dependencies
working-directory: ./sdks/python
run: pip install -r build-requirements.txt
+ - name: Generate protos
+ working-directory: ./sdks/python
+ run: python gen_protos.py
- name: Install tox
- run: pip install tox==3.27.1
+ run: pip install tox
Review Comment:
Should we still pin to a 4.x version to avoid this possibly breaking when tox 5.x is released?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org