You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by we...@apache.org on 2019/05/10 15:10:12 UTC

[spark] branch branch-2.4 updated: [MINOR][TEST] Fix schema mismatch error

This is an automated email from the ASF dual-hosted git repository.

wenchen pushed a commit to branch branch-2.4
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/branch-2.4 by this push:
     new 3726ece  [MINOR][TEST] Fix schema mismatch error
3726ece is described below

commit 3726eceaf39dc2aa32d34b4910f9136d4ebb7bd5
Author: Eric Liang <ek...@databricks.com>
AuthorDate: Fri May 10 23:08:02 2019 +0800

    [MINOR][TEST] Fix schema mismatch error
    
    ## What changes were proposed in this pull request?
    
    - the accumulator warning is too verbose
    - when a test fails with schema mismatch, you never see the error message / exception
    
    Closes #24549 from ericl/test-nits.
    
    Lead-authored-by: Eric Liang <ek...@databricks.com>
    Co-authored-by: Eric Liang <ek...@gmail.com>
    Signed-off-by: Wenchen Fan <we...@databricks.com>
    (cherry picked from commit 80de449f51e6ce99854aaf6b227e14f673aa0cb5)
    Signed-off-by: Wenchen Fan <we...@databricks.com>
---
 sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
index 826408c..ab817ff 100644
--- a/sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
+++ b/sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
@@ -243,7 +243,8 @@ class SQLQueryTestSuite extends QueryTest with SharedSQLContext {
       assertResult(expected.sql, s"SQL query did not match for query #$i\n${expected.sql}") {
         output.sql
       }
-      assertResult(expected.schema, s"Schema did not match for query #$i\n${expected.sql}") {
+      assertResult(expected.schema,
+        s"Schema did not match for query #$i\n${expected.sql}: $output") {
         output.schema
       }
       assertResult(expected.output, s"Result did not match for query #$i\n${expected.sql}") {


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org