You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/10/26 04:50:43 UTC

[GitHub] [beam] pabloem opened a new pull request, #23841: Deactivate Dask Runner code coverage tests as workaround

pabloem opened a new pull request, #23841:
URL: https://github.com/apache/beam/pull/23841

   **Please** add a meaningful description for your change here
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #23841: Deactivate Dask Runner code coverage tests as workaround

Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #23841:
URL: https://github.com/apache/beam/pull/23841#issuecomment-1292637569

   Good to me for now. Keep the issue open until forward fix is in and re-enable the coverage.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #23841: Deactivate Dask Runner code coverage tests as workaround

Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #23841:
URL: https://github.com/apache/beam/pull/23841#issuecomment-1291529123

   r: @Abacn @alxmrs 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #23841: Deactivate Dask Runner code coverage tests as workaround

Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #23841:
URL: https://github.com/apache/beam/pull/23841#issuecomment-1292632371

   r: @Abacn @alxmrs PTAL?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem merged pull request #23841: Deactivate Dask Runner code coverage tests as workaround

Posted by GitBox <gi...@apache.org>.
pabloem merged PR #23841:
URL: https://github.com/apache/beam/pull/23841


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #23841: Deactivate Dask Runner code coverage tests as workaround

Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #23841:
URL: https://github.com/apache/beam/pull/23841#issuecomment-1291529312

   we can roll forward the coverage test for dask, but it had become flaky so we need to fix it first if that's okay : )


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] alxmrs commented on pull request #23841: Deactivate Dask Runner code coverage tests as workaround

Posted by GitBox <gi...@apache.org>.
alxmrs commented on PR #23841:
URL: https://github.com/apache/beam/pull/23841#issuecomment-1292669440

   Thanks for pointing this out @Abacn -- I was expecting a different interface. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #23841: Deactivate Dask Runner code coverage tests as workaround

Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #23841:
URL: https://github.com/apache/beam/pull/23841#issuecomment-1291497424

   Fixes #23838


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #23841: Deactivate Dask Runner code coverage tests as workaround

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23841:
URL: https://github.com/apache/beam/pull/23841#issuecomment-1291532039

   Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #23841: Deactivate Dask Runner code coverage tests as workaround

Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #23841:
URL: https://github.com/apache/beam/pull/23841#issuecomment-1292639427

   > > r: @Abacn @alxmrs PTAL?
   > 
   > I don't have permission to review this CL.
   
   Anyone can review, in "File Changed" tab there is a "review change" button


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] commented on pull request #23841: Deactivate Dask Runner code coverage tests as workaround

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #23841:
URL: https://github.com/apache/beam/pull/23841#issuecomment-1291514782

   # [Codecov](https://codecov.io/gh/apache/beam/pull/23841?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#23841](https://codecov.io/gh/apache/beam/pull/23841?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (750b2c2) into [master](https://codecov.io/gh/apache/beam/commit/ead2d2e8025874ad5c3f09ea0fda06caf027e18c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ead2d2e) will **decrease** coverage by `0.14%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #23841      +/-   ##
   ==========================================
   - Coverage   73.84%   73.70%   -0.15%     
   ==========================================
     Files         706      706              
     Lines       95473    95473              
   ==========================================
   - Hits        70505    70367     -138     
   - Misses      23656    23794     +138     
     Partials     1312     1312              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | python | `83.79% <ø> (-0.21%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/23841?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...dks/python/apache\_beam/runners/dask/dask\_runner.py](https://codecov.io/gh/apache/beam/pull/23841/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXNrL2Rhc2tfcnVubmVyLnB5) | `10.41% <0.00%> (-76.05%)` | :arrow_down: |
   | [...on/apache\_beam/runners/dask/transform\_evaluator.py](https://codecov.io/gh/apache/beam/pull/23841/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXNrL3RyYW5zZm9ybV9ldmFsdWF0b3IucHk=) | `12.00% <0.00%> (-76.00%)` | :arrow_down: |
   | [sdks/python/apache\_beam/runners/dask/overrides.py](https://codecov.io/gh/apache/beam/pull/23841/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXNrL292ZXJyaWRlcy5weQ==) | `51.85% <0.00%> (-35.81%)` | :arrow_down: |
   | [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/23841/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.54% <0.00%> (+0.24%)` | :arrow_up: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] alxmrs commented on pull request #23841: Deactivate Dask Runner code coverage tests as workaround

Posted by GitBox <gi...@apache.org>.
alxmrs commented on PR #23841:
URL: https://github.com/apache/beam/pull/23841#issuecomment-1292638312

   > r: @Abacn @alxmrs PTAL?
   
   I don't have permission to review this CL. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org