You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "blaginin (via GitHub)" <gi...@apache.org> on 2026/02/23 20:33:04 UTC

[PR] Runs-on for Linux test CI [datafusion-comet]

blaginin opened a new pull request, #3579:
URL: https://github.com/apache/datafusion-comet/pull/3579

   ## Which issue does this PR close?
   
   Part of https://github.com/apache/datafusion-comet/issues/3404


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] build: Runs-on for `PR Build (Linux)` [datafusion-comet]

Posted by "blaginin (via GitHub)" <gi...@apache.org>.
blaginin commented on code in PR #3579:
URL: https://github.com/apache/datafusion-comet/pull/3579#discussion_r2849505918


##########
.github/workflows/pr_build_linux.yml:
##########
@@ -67,12 +67,12 @@ jobs:
   build-native:
     needs: lint
     name: Build Native Library
-    runs-on: ubuntu-latest
+    runs-on: ${{ github.repository_owner == 'apache' && format('runs-on={0},family=m8a,cpu=8,image=ubuntu24-full-x64,extras=s3-cache,disk=large,tag=datafusion', github.run_id) || 'ubuntu-latest' }}

Review Comment:
   should have been -comet everywhere, will update!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] build: Runs-on for `PR Build (Linux)` [datafusion-comet]

Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on PR #3579:
URL: https://github.com/apache/datafusion-comet/pull/3579#issuecomment-3953940585

   Thanks @blaginin we'll keep on CI, I remember it was some issue with delayed start


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] build: Runs-on for `PR Build (Linux)` [datafusion-comet]

Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on code in PR #3579:
URL: https://github.com/apache/datafusion-comet/pull/3579#discussion_r2848089379


##########
.github/workflows/pr_build_linux.yml:
##########
@@ -67,12 +67,12 @@ jobs:
   build-native:
     needs: lint
     name: Build Native Library
-    runs-on: ubuntu-latest
+    runs-on: ${{ github.repository_owner == 'apache' && format('runs-on={0},family=m8a,cpu=8,image=ubuntu24-full-x64,extras=s3-cache,disk=large,tag=datafusion', github.run_id) || 'ubuntu-latest' }}

Review Comment:
   There is a mix of `datafusion` and `datafusion-comet` for tags. Should they all be `data fusion-comet`?



##########
.github/workflows/pr_build_linux.yml:
##########
@@ -67,12 +67,12 @@ jobs:
   build-native:
     needs: lint
     name: Build Native Library
-    runs-on: ubuntu-latest
+    runs-on: ${{ github.repository_owner == 'apache' && format('runs-on={0},family=m8a,cpu=8,image=ubuntu24-full-x64,extras=s3-cache,disk=large,tag=datafusion', github.run_id) || 'ubuntu-latest' }}

Review Comment:
   There is a mix of `datafusion` and `datafusion-comet` for tags. Should they all be `datafusion-comet`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] build: Runs-on for `PR Build (Linux)` [datafusion-comet]

Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on code in PR #3579:
URL: https://github.com/apache/datafusion-comet/pull/3579#discussion_r2853991173


##########
.github/workflows/pr_build_linux.yml:
##########
@@ -67,12 +67,12 @@ jobs:
   build-native:
     needs: lint
     name: Build Native Library
-    runs-on: ubuntu-latest
+    runs-on: ${{ github.repository_owner == 'apache' && format('runs-on={0},family=m8a,cpu=8,image=ubuntu24-full-x64,extras=s3-cache,disk=large,tag=datafusion', github.run_id) || 'ubuntu-latest' }}

Review Comment:
   I went ahead and created https://github.com/apache/datafusion-comet/pull/3601



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] build: Runs-on for `PR Build (Linux)` [datafusion-comet]

Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove merged PR #3579:
URL: https://github.com/apache/datafusion-comet/pull/3579


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] build: Runs-on for `PR Build (Linux)` [datafusion-comet]

Posted by "blaginin (via GitHub)" <gi...@apache.org>.
blaginin commented on PR #3579:
URL: https://github.com/apache/datafusion-comet/pull/3579#issuecomment-3954696260

   thanks! i think we have fixed the slow start part but if you ever see it, adding more instance types should help (m7a for example)
   
   https://runs-on.com/guides/best-practices/#diversify-instance-types


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org