You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/04/22 06:03:17 UTC
[GitHub] [kafka] jiameixie opened a new pull request #8529: KAFKA-9901:Fix streams_broker_bounce_test error
jiameixie opened a new pull request #8529:
URL: https://github.com/apache/kafka/pull/8529
The constructor of StreamsSmokeTestJobRunnerService has been changed.
But it's not updated in streams_broker_bounce_test.py, which makes
num_threads = 3 to be processing_guarantee's value and causes that
StreamsTest can't startup
Change-Id: I07ebc3e007e0ddd0b5182d5cf9467cdfac993eae
Signed-off-by: Jiamei Xie <ji...@arm.com>
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on pull request #8529: KAFKA-9901:Fix streams_broker_bounce_test error
Posted by GitBox <gi...@apache.org>.
cadonna commented on pull request #8529:
URL: https://github.com/apache/kafka/pull/8529#issuecomment-619140731
@jiameixie My PR was merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on pull request #8529: KAFKA-9901:Fix streams_broker_bounce_test error
Posted by GitBox <gi...@apache.org>.
cadonna commented on pull request #8529:
URL: https://github.com/apache/kafka/pull/8529#issuecomment-619080823
In order to avoid duplicate work, I just want to let you know that I also have a PR that fixes this issue the same way https://github.com/apache/kafka/pull/8532. I have already run the system tests on that PR to verify the fix. On my PR, there is also a discussion on which value to set the new constructor parameter. You can merge this or the other PR, I do not care. I just wanted to let you know.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jiameixie commented on issue #8529: KAFKA-9901:Fix streams_broker_bounce_test error
Posted by GitBox <gi...@apache.org>.
jiameixie commented on issue #8529:
URL: https://github.com/apache/kafka/pull/8529#issuecomment-618169833
@guozhangwang @ijuma @junrao PTAL, thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org