You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by GitBox <gi...@apache.org> on 2022/12/09 11:28:22 UTC
[GitHub] [incubator-uniffle] xianjingfeng opened a new pull request, #395: [ISSUE-390] Print more infos after read finished
xianjingfeng opened a new pull request, #395:
URL: https://github.com/apache/incubator-uniffle/pull/395
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
2. Ensure you have added or run the appropriate tests for your PR
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]XXXX Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
1.Print how much data the client read from each server.
2.Print how much data read from all server(include skipped data)
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Currently, we do not know how much data the client read from each server and how much data read from all server(include skipped data) #390
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Run Uts and check logs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] xianjingfeng commented on a diff in pull request #395: [ISSUE-390] Print more infos after read finished
Posted by GitBox <gi...@apache.org>.
xianjingfeng commented on code in PR #395:
URL: https://github.com/apache/incubator-uniffle/pull/395#discussion_r1044954975
##########
storage/src/main/java/org/apache/uniffle/storage/handler/impl/AbstractClientReadHandler.java:
##########
@@ -38,10 +43,32 @@ public void close() {
}
@Override
- public void updateConsumedBlockInfo(BufferSegment bs) {
+ public void updateConsumedBlockInfo(BufferSegment bs, boolean skipped) {
+ if (bs == null) {
+ return;
+ }
+ updateBlockMetric(readHandlerMetric, bs, skipped);
}
@Override
public void logConsumedBlockInfo() {
+ LOG.info("Client read [" + readHandlerMetric.getReadBlockNum() + " blocks,"
+ + " bytes:" + readHandlerMetric.getReadLength() + " uncompressed bytes:"
+ + readHandlerMetric.getReadUncompressLength()
+ + "], skipped[" + readHandlerMetric.getSkippedReadBlockNum() + " blocks,"
+ + " bytes:" + readHandlerMetric.getSkippedReadLength() + " uncompressed bytes:"
+ + readHandlerMetric.getSkippedReadUncompressLength() + "]");
+ }
+
+ protected void updateBlockMetric(ClientReadHandlerMetric metric, BufferSegment bs, boolean skipped) {
Review Comment:
> `updateSkippedMetrics` may be better.
Add a new method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #395: [ISSUE-390] Print more infos after read finished
Posted by GitBox <gi...@apache.org>.
jerqi commented on code in PR #395:
URL: https://github.com/apache/incubator-uniffle/pull/395#discussion_r1044955323
##########
storage/src/main/java/org/apache/uniffle/storage/handler/impl/AbstractClientReadHandler.java:
##########
@@ -38,10 +43,32 @@ public void close() {
}
@Override
- public void updateConsumedBlockInfo(BufferSegment bs) {
+ public void updateConsumedBlockInfo(BufferSegment bs, boolean skipped) {
+ if (bs == null) {
+ return;
+ }
+ updateBlockMetric(readHandlerMetric, bs, skipped);
}
@Override
public void logConsumedBlockInfo() {
+ LOG.info("Client read [" + readHandlerMetric.getReadBlockNum() + " blocks,"
+ + " bytes:" + readHandlerMetric.getReadLength() + " uncompressed bytes:"
+ + readHandlerMetric.getReadUncompressLength()
+ + "], skipped[" + readHandlerMetric.getSkippedReadBlockNum() + " blocks,"
+ + " bytes:" + readHandlerMetric.getSkippedReadLength() + " uncompressed bytes:"
+ + readHandlerMetric.getSkippedReadUncompressLength() + "]");
+ }
+
+ protected void updateBlockMetric(ClientReadHandlerMetric metric, BufferSegment bs, boolean skipped) {
Review Comment:
> > `updateSkippedMetrics` may be better.
>
> Add a new method?
It's ok to rename this parameter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #395: [ISSUE-390] Print more infos after read finished
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #395:
URL: https://github.com/apache/incubator-uniffle/pull/395#issuecomment-1344211036
# [Codecov](https://codecov.io/gh/apache/incubator-uniffle/pull/395?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#395](https://codecov.io/gh/apache/incubator-uniffle/pull/395?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9bcdaad) into [master](https://codecov.io/gh/apache/incubator-uniffle/commit/3ec3f416596504d78284985a6b6fd64f1ba0d26d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3ec3f41) will **decrease** coverage by `0.89%`.
> The diff coverage is `13.04%`.
```diff
@@ Coverage Diff @@
## master #395 +/- ##
============================================
- Coverage 58.77% 57.87% -0.90%
+ Complexity 1602 1385 -217
============================================
Files 193 172 -21
Lines 10939 9134 -1805
Branches 955 795 -160
============================================
- Hits 6429 5286 -1143
+ Misses 4132 3514 -618
+ Partials 378 334 -44
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-uniffle/pull/395?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...uniffle/storage/factory/ShuffleHandlerFactory.java](https://codecov.io/gh/apache/incubator-uniffle/pull/395/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmFnZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdW5pZmZsZS9zdG9yYWdlL2ZhY3RvcnkvU2h1ZmZsZUhhbmRsZXJGYWN0b3J5LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...torage/handler/impl/ComposedClientReadHandler.java](https://codecov.io/gh/apache/incubator-uniffle/pull/395/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmFnZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdW5pZmZsZS9zdG9yYWdlL2hhbmRsZXIvaW1wbC9Db21wb3NlZENsaWVudFJlYWRIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...le/storage/handler/impl/HdfsClientReadHandler.java](https://codecov.io/gh/apache/incubator-uniffle/pull/395/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmFnZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdW5pZmZsZS9zdG9yYWdlL2hhbmRsZXIvaW1wbC9IZGZzQ2xpZW50UmVhZEhhbmRsZXIuamF2YQ==) | `82.60% <ø> (+7.60%)` | :arrow_up: |
| [...ge/handler/impl/MultiReplicaClientReadHandler.java](https://codecov.io/gh/apache/incubator-uniffle/pull/395/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmFnZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdW5pZmZsZS9zdG9yYWdlL2hhbmRsZXIvaW1wbC9NdWx0aVJlcGxpY2FDbGllbnRSZWFkSGFuZGxlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...torage/handler/impl/AbstractClientReadHandler.java](https://codecov.io/gh/apache/incubator-uniffle/pull/395/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmFnZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdW5pZmZsZS9zdG9yYWdlL2hhbmRsZXIvaW1wbC9BYnN0cmFjdENsaWVudFJlYWRIYW5kbGVyLmphdmE=) | `12.50% <10.52%> (-7.50%)` | :arrow_down: |
| [...iffle/storage/handler/ClientReadHandlerMetric.java](https://codecov.io/gh/apache/incubator-uniffle/pull/395/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmFnZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdW5pZmZsZS9zdG9yYWdlL2hhbmRsZXIvQ2xpZW50UmVhZEhhbmRsZXJNZXRyaWMuamF2YQ==) | `28.00% <28.00%> (ø)` | |
| [...che/uniffle/client/impl/ShuffleReadClientImpl.java](https://codecov.io/gh/apache/incubator-uniffle/pull/395/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NsaWVudC9pbXBsL1NodWZmbGVSZWFkQ2xpZW50SW1wbC5qYXZh) | `88.67% <100.00%> (+0.21%)` | :arrow_up: |
| [.../java/org/apache/uniffle/server/ShuffleServer.java](https://codecov.io/gh/apache/incubator-uniffle/pull/395/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL3NlcnZlci9TaHVmZmxlU2VydmVyLmphdmE=) | `64.49% <0.00%> (-2.90%)` | :arrow_down: |
| [...storage/handler/impl/DataSkippableReadHandler.java](https://codecov.io/gh/apache/incubator-uniffle/pull/395/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmFnZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdW5pZmZsZS9zdG9yYWdlL2hhbmRsZXIvaW1wbC9EYXRhU2tpcHBhYmxlUmVhZEhhbmRsZXIuamF2YQ==) | `83.78% <0.00%> (-2.71%)` | :arrow_down: |
| [...mapreduce/task/reduce/RssInMemoryRemoteMerger.java](https://codecov.io/gh/apache/incubator-uniffle/pull/395/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvbWFwcmVkdWNlL3Rhc2svcmVkdWNlL1Jzc0luTWVtb3J5UmVtb3RlTWVyZ2VyLmphdmE=) | | |
| ... and [21 more](https://codecov.io/gh/apache/incubator-uniffle/pull/395/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #395: [ISSUE-390] Print more infos after read finished
Posted by GitBox <gi...@apache.org>.
jerqi commented on code in PR #395:
URL: https://github.com/apache/incubator-uniffle/pull/395#discussion_r1044961190
##########
storage/src/main/java/org/apache/uniffle/storage/handler/impl/AbstractClientReadHandler.java:
##########
@@ -38,10 +43,32 @@ public void close() {
}
@Override
- public void updateConsumedBlockInfo(BufferSegment bs) {
+ public void updateConsumedBlockInfo(BufferSegment bs, boolean skipped) {
+ if (bs == null) {
+ return;
+ }
+ updateBlockMetric(readHandlerMetric, bs, skipped);
}
@Override
public void logConsumedBlockInfo() {
+ LOG.info("Client read [" + readHandlerMetric.getReadBlockNum() + " blocks,"
+ + " bytes:" + readHandlerMetric.getReadLength() + " uncompressed bytes:"
+ + readHandlerMetric.getReadUncompressLength()
+ + "], skipped[" + readHandlerMetric.getSkippedReadBlockNum() + " blocks,"
+ + " bytes:" + readHandlerMetric.getSkippedReadLength() + " uncompressed bytes:"
+ + readHandlerMetric.getSkippedReadUncompressLength() + "]");
+ }
+
+ protected void updateBlockMetric(ClientReadHandlerMetric metric, BufferSegment bs, boolean skipped) {
Review Comment:
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #395: [ISSUE-390] Print more infos after read finished
Posted by GitBox <gi...@apache.org>.
jerqi commented on code in PR #395:
URL: https://github.com/apache/incubator-uniffle/pull/395#discussion_r1044384038
##########
storage/src/main/java/org/apache/uniffle/storage/handler/impl/AbstractClientReadHandler.java:
##########
@@ -38,10 +43,32 @@ public void close() {
}
@Override
- public void updateConsumedBlockInfo(BufferSegment bs) {
+ public void updateConsumedBlockInfo(BufferSegment bs, boolean skipped) {
+ if (bs == null) {
+ return;
+ }
+ updateBlockMetric(readHandlerMetric, bs, skipped);
}
@Override
public void logConsumedBlockInfo() {
+ LOG.info("Client read [" + readHandlerMetric.getReadBlockNum() + " blocks,"
+ + " bytes:" + readHandlerMetric.getReadLength() + " uncompressed bytes:"
+ + readHandlerMetric.getReadUncompressLength()
+ + "], skipped[" + readHandlerMetric.getSkippedReadBlockNum() + " blocks,"
+ + " bytes:" + readHandlerMetric.getSkippedReadLength() + " uncompressed bytes:"
+ + readHandlerMetric.getSkippedReadUncompressLength() + "]");
+ }
+
+ protected void updateBlockMetric(ClientReadHandlerMetric metric, BufferSegment bs, boolean skipped) {
Review Comment:
Could we give `skipped` a better name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] xianjingfeng commented on a diff in pull request #395: [ISSUE-390] Print more infos after read finished
Posted by GitBox <gi...@apache.org>.
xianjingfeng commented on code in PR #395:
URL: https://github.com/apache/incubator-uniffle/pull/395#discussion_r1044960463
##########
storage/src/main/java/org/apache/uniffle/storage/handler/impl/AbstractClientReadHandler.java:
##########
@@ -38,10 +43,32 @@ public void close() {
}
@Override
- public void updateConsumedBlockInfo(BufferSegment bs) {
+ public void updateConsumedBlockInfo(BufferSegment bs, boolean skipped) {
+ if (bs == null) {
+ return;
+ }
+ updateBlockMetric(readHandlerMetric, bs, skipped);
}
@Override
public void logConsumedBlockInfo() {
+ LOG.info("Client read [" + readHandlerMetric.getReadBlockNum() + " blocks,"
+ + " bytes:" + readHandlerMetric.getReadLength() + " uncompressed bytes:"
+ + readHandlerMetric.getReadUncompressLength()
+ + "], skipped[" + readHandlerMetric.getSkippedReadBlockNum() + " blocks,"
+ + " bytes:" + readHandlerMetric.getSkippedReadLength() + " uncompressed bytes:"
+ + readHandlerMetric.getSkippedReadUncompressLength() + "]");
+ }
+
+ protected void updateBlockMetric(ClientReadHandlerMetric metric, BufferSegment bs, boolean skipped) {
Review Comment:
> Maybe `isSkippedMetrics` may be better. Because `updateSkippedMetrics` is like a method name. [emo]
So, rename `skipped` to `isSkippedMetrics`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #395: [ISSUE-390] Print more infos after read finished
Posted by GitBox <gi...@apache.org>.
jerqi commented on code in PR #395:
URL: https://github.com/apache/incubator-uniffle/pull/395#discussion_r1044954651
##########
storage/src/main/java/org/apache/uniffle/storage/handler/impl/AbstractClientReadHandler.java:
##########
@@ -38,10 +43,32 @@ public void close() {
}
@Override
- public void updateConsumedBlockInfo(BufferSegment bs) {
+ public void updateConsumedBlockInfo(BufferSegment bs, boolean skipped) {
+ if (bs == null) {
+ return;
+ }
+ updateBlockMetric(readHandlerMetric, bs, skipped);
}
@Override
public void logConsumedBlockInfo() {
+ LOG.info("Client read [" + readHandlerMetric.getReadBlockNum() + " blocks,"
+ + " bytes:" + readHandlerMetric.getReadLength() + " uncompressed bytes:"
+ + readHandlerMetric.getReadUncompressLength()
+ + "], skipped[" + readHandlerMetric.getSkippedReadBlockNum() + " blocks,"
+ + " bytes:" + readHandlerMetric.getSkippedReadLength() + " uncompressed bytes:"
+ + readHandlerMetric.getSkippedReadUncompressLength() + "]");
+ }
+
+ protected void updateBlockMetric(ClientReadHandlerMetric metric, BufferSegment bs, boolean skipped) {
Review Comment:
`updateSkippedMetrics` may be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #395: [ISSUE-390] Print more infos after read finished
Posted by GitBox <gi...@apache.org>.
jerqi commented on code in PR #395:
URL: https://github.com/apache/incubator-uniffle/pull/395#discussion_r1044467080
##########
storage/src/main/java/org/apache/uniffle/storage/handler/impl/AbstractClientReadHandler.java:
##########
@@ -38,10 +43,32 @@ public void close() {
}
@Override
- public void updateConsumedBlockInfo(BufferSegment bs) {
+ public void updateConsumedBlockInfo(BufferSegment bs, boolean skipped) {
+ if (bs == null) {
+ return;
+ }
+ updateBlockMetric(readHandlerMetric, bs, skipped);
}
@Override
public void logConsumedBlockInfo() {
+ LOG.info("Client read [" + readHandlerMetric.getReadBlockNum() + " blocks,"
+ + " bytes:" + readHandlerMetric.getReadLength() + " uncompressed bytes:"
+ + readHandlerMetric.getReadUncompressLength()
+ + "], skipped[" + readHandlerMetric.getSkippedReadBlockNum() + " blocks,"
+ + " bytes:" + readHandlerMetric.getSkippedReadLength() + " uncompressed bytes:"
+ + readHandlerMetric.getSkippedReadUncompressLength() + "]");
+ }
+
+ protected void updateBlockMetric(ClientReadHandlerMetric metric, BufferSegment bs, boolean skipped) {
Review Comment:
I can't get the meaning of this parameter. Do it mean that this BufferSegment will be skipped if this value is value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #395: [ISSUE-390] Print more infos after read finished
Posted by GitBox <gi...@apache.org>.
jerqi commented on code in PR #395:
URL: https://github.com/apache/incubator-uniffle/pull/395#discussion_r1044956108
##########
storage/src/main/java/org/apache/uniffle/storage/handler/impl/AbstractClientReadHandler.java:
##########
@@ -38,10 +43,32 @@ public void close() {
}
@Override
- public void updateConsumedBlockInfo(BufferSegment bs) {
+ public void updateConsumedBlockInfo(BufferSegment bs, boolean skipped) {
+ if (bs == null) {
+ return;
+ }
+ updateBlockMetric(readHandlerMetric, bs, skipped);
}
@Override
public void logConsumedBlockInfo() {
+ LOG.info("Client read [" + readHandlerMetric.getReadBlockNum() + " blocks,"
+ + " bytes:" + readHandlerMetric.getReadLength() + " uncompressed bytes:"
+ + readHandlerMetric.getReadUncompressLength()
+ + "], skipped[" + readHandlerMetric.getSkippedReadBlockNum() + " blocks,"
+ + " bytes:" + readHandlerMetric.getSkippedReadLength() + " uncompressed bytes:"
+ + readHandlerMetric.getSkippedReadUncompressLength() + "]");
+ }
+
+ protected void updateBlockMetric(ClientReadHandlerMetric metric, BufferSegment bs, boolean skipped) {
Review Comment:
Maybe `isSkippedMetrics` may be better. Because `updateSkippedMetrics` is like a method name. [emo]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] xianjingfeng commented on a diff in pull request #395: [ISSUE-390] Print more infos after read finished
Posted by GitBox <gi...@apache.org>.
xianjingfeng commented on code in PR #395:
URL: https://github.com/apache/incubator-uniffle/pull/395#discussion_r1044957730
##########
storage/src/main/java/org/apache/uniffle/storage/handler/impl/AbstractClientReadHandler.java:
##########
@@ -38,10 +43,32 @@ public void close() {
}
@Override
- public void updateConsumedBlockInfo(BufferSegment bs) {
+ public void updateConsumedBlockInfo(BufferSegment bs, boolean skipped) {
+ if (bs == null) {
+ return;
+ }
+ updateBlockMetric(readHandlerMetric, bs, skipped);
}
@Override
public void logConsumedBlockInfo() {
+ LOG.info("Client read [" + readHandlerMetric.getReadBlockNum() + " blocks,"
+ + " bytes:" + readHandlerMetric.getReadLength() + " uncompressed bytes:"
+ + readHandlerMetric.getReadUncompressLength()
+ + "], skipped[" + readHandlerMetric.getSkippedReadBlockNum() + " blocks,"
+ + " bytes:" + readHandlerMetric.getSkippedReadLength() + " uncompressed bytes:"
+ + readHandlerMetric.getSkippedReadUncompressLength() + "]");
+ }
+
+ protected void updateBlockMetric(ClientReadHandlerMetric metric, BufferSegment bs, boolean skipped) {
Review Comment:
> It's ok to rename this parameter
I don't get your point. Rename `skipped` or add a new method? `ClientReadHandler#updateConsumedBlockInfo` use `skipped` as a parameter too. Should we add a new method like`updateSkippedBlockInfo(BufferSegment bs)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi merged pull request #395: [ISSUE-390] Print more infos after read finished
Posted by GitBox <gi...@apache.org>.
jerqi merged PR #395:
URL: https://github.com/apache/incubator-uniffle/pull/395
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] xianjingfeng commented on a diff in pull request #395: [ISSUE-390] Print more infos after read finished
Posted by GitBox <gi...@apache.org>.
xianjingfeng commented on code in PR #395:
URL: https://github.com/apache/incubator-uniffle/pull/395#discussion_r1044446225
##########
storage/src/main/java/org/apache/uniffle/storage/handler/impl/AbstractClientReadHandler.java:
##########
@@ -38,10 +43,32 @@ public void close() {
}
@Override
- public void updateConsumedBlockInfo(BufferSegment bs) {
+ public void updateConsumedBlockInfo(BufferSegment bs, boolean skipped) {
+ if (bs == null) {
+ return;
+ }
+ updateBlockMetric(readHandlerMetric, bs, skipped);
}
@Override
public void logConsumedBlockInfo() {
+ LOG.info("Client read [" + readHandlerMetric.getReadBlockNum() + " blocks,"
+ + " bytes:" + readHandlerMetric.getReadLength() + " uncompressed bytes:"
+ + readHandlerMetric.getReadUncompressLength()
+ + "], skipped[" + readHandlerMetric.getSkippedReadBlockNum() + " blocks,"
+ + " bytes:" + readHandlerMetric.getSkippedReadLength() + " uncompressed bytes:"
+ + readHandlerMetric.getSkippedReadUncompressLength() + "]");
+ }
+
+ protected void updateBlockMetric(ClientReadHandlerMetric metric, BufferSegment bs, boolean skipped) {
Review Comment:
discarded？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #395: [ISSUE-390] Print more infos after read finished
Posted by GitBox <gi...@apache.org>.
jerqi commented on code in PR #395:
URL: https://github.com/apache/incubator-uniffle/pull/395#discussion_r1044467080
##########
storage/src/main/java/org/apache/uniffle/storage/handler/impl/AbstractClientReadHandler.java:
##########
@@ -38,10 +43,32 @@ public void close() {
}
@Override
- public void updateConsumedBlockInfo(BufferSegment bs) {
+ public void updateConsumedBlockInfo(BufferSegment bs, boolean skipped) {
+ if (bs == null) {
+ return;
+ }
+ updateBlockMetric(readHandlerMetric, bs, skipped);
}
@Override
public void logConsumedBlockInfo() {
+ LOG.info("Client read [" + readHandlerMetric.getReadBlockNum() + " blocks,"
+ + " bytes:" + readHandlerMetric.getReadLength() + " uncompressed bytes:"
+ + readHandlerMetric.getReadUncompressLength()
+ + "], skipped[" + readHandlerMetric.getSkippedReadBlockNum() + " blocks,"
+ + " bytes:" + readHandlerMetric.getSkippedReadLength() + " uncompressed bytes:"
+ + readHandlerMetric.getSkippedReadUncompressLength() + "]");
+ }
+
+ protected void updateBlockMetric(ClientReadHandlerMetric metric, BufferSegment bs, boolean skipped) {
Review Comment:
I can't get the meaning of this parameter. Do it mean that this BufferSegment will be skipped if this value is true?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] xianjingfeng commented on pull request #395: [ISSUE-390] Print more infos after read finished
Posted by GitBox <gi...@apache.org>.
xianjingfeng commented on PR #395:
URL: https://github.com/apache/incubator-uniffle/pull/395#issuecomment-1345164449
> Could we add some uts for this pr?
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] xianjingfeng commented on a diff in pull request #395: [ISSUE-390] Print more infos after read finished
Posted by GitBox <gi...@apache.org>.
xianjingfeng commented on code in PR #395:
URL: https://github.com/apache/incubator-uniffle/pull/395#discussion_r1044946567
##########
storage/src/main/java/org/apache/uniffle/storage/handler/impl/AbstractClientReadHandler.java:
##########
@@ -38,10 +43,32 @@ public void close() {
}
@Override
- public void updateConsumedBlockInfo(BufferSegment bs) {
+ public void updateConsumedBlockInfo(BufferSegment bs, boolean skipped) {
+ if (bs == null) {
+ return;
+ }
+ updateBlockMetric(readHandlerMetric, bs, skipped);
}
@Override
public void logConsumedBlockInfo() {
+ LOG.info("Client read [" + readHandlerMetric.getReadBlockNum() + " blocks,"
+ + " bytes:" + readHandlerMetric.getReadLength() + " uncompressed bytes:"
+ + readHandlerMetric.getReadUncompressLength()
+ + "], skipped[" + readHandlerMetric.getSkippedReadBlockNum() + " blocks,"
+ + " bytes:" + readHandlerMetric.getSkippedReadLength() + " uncompressed bytes:"
+ + readHandlerMetric.getSkippedReadUncompressLength() + "]");
+ }
+
+ protected void updateBlockMetric(ClientReadHandlerMetric metric, BufferSegment bs, boolean skipped) {
Review Comment:
> I can't get the meaning of this parameter. Do it mean that this BufferSegment will be skipped if this value is true?
There are two kinds of block meitrcs in this pr, `Consumed` and `Skipped`. `Consumed` means the block has not been read before and `Skipped` means block has been read before or the block is damaged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #395: [ISSUE-390] Print more infos after read finished
Posted by GitBox <gi...@apache.org>.
jerqi commented on PR #395:
URL: https://github.com/apache/incubator-uniffle/pull/395#issuecomment-1344533263
Could we add some uts for this pr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org