You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Travis Crawford (JIRA)" <ji...@apache.org> on 2010/04/19 22:14:51 UTC
[jira] Created: (ZOOKEEPER-744) Add monitoring four-letter word
Add monitoring four-letter word
-------------------------------
Key: ZOOKEEPER-744
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
Project: Zookeeper
Issue Type: New Feature
Components: server
Reporter: Travis Crawford
Filing a feature request based on a zookeeper-user discussion.
Zookeeper should have a new four-letter word that returns key-value pairs appropriate for importing to a monitoring system (such as Ganglia which has a large installed base)
This command should initially export the following:
(a) Count of instances in the ensemble.
(b) Count of up-to-date instances in the ensemble.
But be designed such that in the future additional data can be added. For example, the output could define the statistic in a comment, then print a key "space character" value line:
"""
# Total number of instances in the ensemble
zk_ensemble_instances_total 5
# Number of instances currently participating in the quorum.
zk_ensemble_instances_active 4
"""
>From the mailing list:
"""
Date: Mon, 19 Apr 2010 12:10:44 -0700
From: Patrick Hunt <ph...@apache.org>
To: zookeeper-user@hadoop.apache.org
Subject: Re: Recovery issue - how to debug?
On 04/19/2010 11:55 AM, Travis Crawford wrote:
> It would be a lot easier from the operations perspective if the leader
> explicitly published some health stats:
>
> (a) Count of instances in the ensemble.
> (b) Count of up-to-date instances in the ensemble.
>
> This would greatly simplify monitoring& alerting - when an instance
> falls behind one could configure their monitoring system to let
> someone know and take a look at the logs.
That's a great idea. Please enter a JIRA for this - a new 4 letter word
and JMX support. It would also be a great starter project for someone
interested in becoming more familiar with the server code.
Patrick
"""
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-744) Add monitoring four-letter word
Posted by "Savu Andrei (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12875021#action_12875021 ]
Savu Andrei commented on ZOOKEEPER-744:
---------------------------------------
Thanks for reviewing. I will resubmit the patch today.
--
Savu Andrei
Website: http://www.andreisavu.ro/
> Add monitoring four-letter word
> -------------------------------
>
> Key: ZOOKEEPER-744
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Affects Versions: 3.4.0
> Reporter: Travis Crawford
> Assignee: Savu Andrei
> Fix For: 3.4.0
>
> Attachments: zk-ganglia.png, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch
>
>
> Filing a feature request based on a zookeeper-user discussion.
> Zookeeper should have a new four-letter word that returns key-value pairs appropriate for importing to a monitoring system (such as Ganglia which has a large installed base)
> This command should initially export the following:
> (a) Count of instances in the ensemble.
> (b) Count of up-to-date instances in the ensemble.
> But be designed such that in the future additional data can be added. For example, the output could define the statistic in a comment, then print a key "space character" value line:
> """
> # Total number of instances in the ensemble
> zk_ensemble_instances_total 5
> # Number of instances currently participating in the quorum.
> zk_ensemble_instances_active 4
> """
> From the mailing list:
> """
> Date: Mon, 19 Apr 2010 12:10:44 -0700
> From: Patrick Hunt <ph...@apache.org>
> To: zookeeper-user@hadoop.apache.org
> Subject: Re: Recovery issue - how to debug?
> On 04/19/2010 11:55 AM, Travis Crawford wrote:
> > It would be a lot easier from the operations perspective if the leader
> > explicitly published some health stats:
> >
> > (a) Count of instances in the ensemble.
> > (b) Count of up-to-date instances in the ensemble.
> >
> > This would greatly simplify monitoring& alerting - when an instance
> > falls behind one could configure their monitoring system to let
> > someone know and take a look at the logs.
> That's a great idea. Please enter a JIRA for this - a new 4 letter word
> and JMX support. It would also be a great starter project for someone
> interested in becoming more familiar with the server code.
> Patrick
> """
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-744) Add monitoring four-letter word
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-744:
-----------------------------------
Status: Patch Available (was: Open)
> Add monitoring four-letter word
> -------------------------------
>
> Key: ZOOKEEPER-744
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Affects Versions: 3.4.0
> Reporter: Travis Crawford
> Assignee: Andrei Savu
> Fix For: 3.4.0
>
> Attachments: zk-ganglia.png, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch
>
>
> Filing a feature request based on a zookeeper-user discussion.
> Zookeeper should have a new four-letter word that returns key-value pairs appropriate for importing to a monitoring system (such as Ganglia which has a large installed base)
> This command should initially export the following:
> (a) Count of instances in the ensemble.
> (b) Count of up-to-date instances in the ensemble.
> But be designed such that in the future additional data can be added. For example, the output could define the statistic in a comment, then print a key "space character" value line:
> """
> # Total number of instances in the ensemble
> zk_ensemble_instances_total 5
> # Number of instances currently participating in the quorum.
> zk_ensemble_instances_active 4
> """
> From the mailing list:
> """
> Date: Mon, 19 Apr 2010 12:10:44 -0700
> From: Patrick Hunt <ph...@apache.org>
> To: zookeeper-user@hadoop.apache.org
> Subject: Re: Recovery issue - how to debug?
> On 04/19/2010 11:55 AM, Travis Crawford wrote:
> > It would be a lot easier from the operations perspective if the leader
> > explicitly published some health stats:
> >
> > (a) Count of instances in the ensemble.
> > (b) Count of up-to-date instances in the ensemble.
> >
> > This would greatly simplify monitoring& alerting - when an instance
> > falls behind one could configure their monitoring system to let
> > someone know and take a look at the logs.
> That's a great idea. Please enter a JIRA for this - a new 4 letter word
> and JMX support. It would also be a great starter project for someone
> interested in becoming more familiar with the server code.
> Patrick
> """
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-744) Add monitoring four-letter word
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-744:
-----------------------------------
Status: Open (was: Patch Available)
> Add monitoring four-letter word
> -------------------------------
>
> Key: ZOOKEEPER-744
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Affects Versions: 3.4.0
> Reporter: Travis Crawford
> Assignee: Andrei Savu
> Fix For: 3.4.0
>
> Attachments: zk-ganglia.png, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch
>
>
> Filing a feature request based on a zookeeper-user discussion.
> Zookeeper should have a new four-letter word that returns key-value pairs appropriate for importing to a monitoring system (such as Ganglia which has a large installed base)
> This command should initially export the following:
> (a) Count of instances in the ensemble.
> (b) Count of up-to-date instances in the ensemble.
> But be designed such that in the future additional data can be added. For example, the output could define the statistic in a comment, then print a key "space character" value line:
> """
> # Total number of instances in the ensemble
> zk_ensemble_instances_total 5
> # Number of instances currently participating in the quorum.
> zk_ensemble_instances_active 4
> """
> From the mailing list:
> """
> Date: Mon, 19 Apr 2010 12:10:44 -0700
> From: Patrick Hunt <ph...@apache.org>
> To: zookeeper-user@hadoop.apache.org
> Subject: Re: Recovery issue - how to debug?
> On 04/19/2010 11:55 AM, Travis Crawford wrote:
> > It would be a lot easier from the operations perspective if the leader
> > explicitly published some health stats:
> >
> > (a) Count of instances in the ensemble.
> > (b) Count of up-to-date instances in the ensemble.
> >
> > This would greatly simplify monitoring& alerting - when an instance
> > falls behind one could configure their monitoring system to let
> > someone know and take a look at the logs.
> That's a great idea. Please enter a JIRA for this - a new 4 letter word
> and JMX support. It would also be a great starter project for someone
> interested in becoming more familiar with the server code.
> Patrick
> """
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-744) Add monitoring four-letter word
Posted by "Savu Andrei (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Savu Andrei updated ZOOKEEPER-744:
----------------------------------
Attachment: ZOOKEEPER-744.patch
I've updated the patch and added a new the test for getWatchCount(). I'm not yet recording the time of the last election, I'm thinking about open a JIRA later for this. I want to move on and work on ZOOKEEPER-613.
> Add monitoring four-letter word
> -------------------------------
>
> Key: ZOOKEEPER-744
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Affects Versions: 3.4.0
> Reporter: Travis Crawford
> Assignee: Savu Andrei
> Fix For: 3.4.0
>
> Attachments: zk-ganglia.png, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch
>
>
> Filing a feature request based on a zookeeper-user discussion.
> Zookeeper should have a new four-letter word that returns key-value pairs appropriate for importing to a monitoring system (such as Ganglia which has a large installed base)
> This command should initially export the following:
> (a) Count of instances in the ensemble.
> (b) Count of up-to-date instances in the ensemble.
> But be designed such that in the future additional data can be added. For example, the output could define the statistic in a comment, then print a key "space character" value line:
> """
> # Total number of instances in the ensemble
> zk_ensemble_instances_total 5
> # Number of instances currently participating in the quorum.
> zk_ensemble_instances_active 4
> """
> From the mailing list:
> """
> Date: Mon, 19 Apr 2010 12:10:44 -0700
> From: Patrick Hunt <ph...@apache.org>
> To: zookeeper-user@hadoop.apache.org
> Subject: Re: Recovery issue - how to debug?
> On 04/19/2010 11:55 AM, Travis Crawford wrote:
> > It would be a lot easier from the operations perspective if the leader
> > explicitly published some health stats:
> >
> > (a) Count of instances in the ensemble.
> > (b) Count of up-to-date instances in the ensemble.
> >
> > This would greatly simplify monitoring& alerting - when an instance
> > falls behind one could configure their monitoring system to let
> > someone know and take a look at the logs.
> That's a great idea. Please enter a JIRA for this - a new 4 letter word
> and JMX support. It would also be a great starter project for someone
> interested in becoming more familiar with the server code.
> Patrick
> """
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-744) Add monitoring four-letter word
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-744:
-----------------------------------
Status: Open (was: Patch Available)
Fix Version/s: 3.4.0
> Add monitoring four-letter word
> -------------------------------
>
> Key: ZOOKEEPER-744
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Affects Versions: 3.4.0
> Reporter: Travis Crawford
> Assignee: Savu Andrei
> Fix For: 3.4.0
>
> Attachments: zk-ganglia.png, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch
>
>
> Filing a feature request based on a zookeeper-user discussion.
> Zookeeper should have a new four-letter word that returns key-value pairs appropriate for importing to a monitoring system (such as Ganglia which has a large installed base)
> This command should initially export the following:
> (a) Count of instances in the ensemble.
> (b) Count of up-to-date instances in the ensemble.
> But be designed such that in the future additional data can be added. For example, the output could define the statistic in a comment, then print a key "space character" value line:
> """
> # Total number of instances in the ensemble
> zk_ensemble_instances_total 5
> # Number of instances currently participating in the quorum.
> zk_ensemble_instances_active 4
> """
> From the mailing list:
> """
> Date: Mon, 19 Apr 2010 12:10:44 -0700
> From: Patrick Hunt <ph...@apache.org>
> To: zookeeper-user@hadoop.apache.org
> Subject: Re: Recovery issue - how to debug?
> On 04/19/2010 11:55 AM, Travis Crawford wrote:
> > It would be a lot easier from the operations perspective if the leader
> > explicitly published some health stats:
> >
> > (a) Count of instances in the ensemble.
> > (b) Count of up-to-date instances in the ensemble.
> >
> > This would greatly simplify monitoring& alerting - when an instance
> > falls behind one could configure their monitoring system to let
> > someone know and take a look at the logs.
> That's a great idea. Please enter a JIRA for this - a new 4 letter word
> and JMX support. It would also be a great starter project for someone
> interested in becoming more familiar with the server code.
> Patrick
> """
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-744) Add monitoring four-letter word
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-744:
-----------------------------------
Status: Resolved (was: Patch Available)
Hadoop Flags: [Reviewed]
Resolution: Fixed
+1, thanks Andrei!
> Add monitoring four-letter word
> -------------------------------
>
> Key: ZOOKEEPER-744
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Affects Versions: 3.4.0
> Reporter: Travis Crawford
> Assignee: Andrei Savu
> Fix For: 3.4.0
>
> Attachments: zk-ganglia.png, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch
>
>
> Filing a feature request based on a zookeeper-user discussion.
> Zookeeper should have a new four-letter word that returns key-value pairs appropriate for importing to a monitoring system (such as Ganglia which has a large installed base)
> This command should initially export the following:
> (a) Count of instances in the ensemble.
> (b) Count of up-to-date instances in the ensemble.
> But be designed such that in the future additional data can be added. For example, the output could define the statistic in a comment, then print a key "space character" value line:
> """
> # Total number of instances in the ensemble
> zk_ensemble_instances_total 5
> # Number of instances currently participating in the quorum.
> zk_ensemble_instances_active 4
> """
> From the mailing list:
> """
> Date: Mon, 19 Apr 2010 12:10:44 -0700
> From: Patrick Hunt <ph...@apache.org>
> To: zookeeper-user@hadoop.apache.org
> Subject: Re: Recovery issue - how to debug?
> On 04/19/2010 11:55 AM, Travis Crawford wrote:
> > It would be a lot easier from the operations perspective if the leader
> > explicitly published some health stats:
> >
> > (a) Count of instances in the ensemble.
> > (b) Count of up-to-date instances in the ensemble.
> >
> > This would greatly simplify monitoring& alerting - when an instance
> > falls behind one could configure their monitoring system to let
> > someone know and take a look at the logs.
> That's a great idea. Please enter a JIRA for this - a new 4 letter word
> and JMX support. It would also be a great starter project for someone
> interested in becoming more familiar with the server code.
> Patrick
> """
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-744) Add monitoring four-letter word
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-744:
-----------------------------------
Status: Patch Available (was: Open)
> Add monitoring four-letter word
> -------------------------------
>
> Key: ZOOKEEPER-744
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Affects Versions: 3.4.0
> Reporter: Travis Crawford
> Assignee: Andrei Savu
> Fix For: 3.4.0
>
> Attachments: zk-ganglia.png, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch
>
>
> Filing a feature request based on a zookeeper-user discussion.
> Zookeeper should have a new four-letter word that returns key-value pairs appropriate for importing to a monitoring system (such as Ganglia which has a large installed base)
> This command should initially export the following:
> (a) Count of instances in the ensemble.
> (b) Count of up-to-date instances in the ensemble.
> But be designed such that in the future additional data can be added. For example, the output could define the statistic in a comment, then print a key "space character" value line:
> """
> # Total number of instances in the ensemble
> zk_ensemble_instances_total 5
> # Number of instances currently participating in the quorum.
> zk_ensemble_instances_active 4
> """
> From the mailing list:
> """
> Date: Mon, 19 Apr 2010 12:10:44 -0700
> From: Patrick Hunt <ph...@apache.org>
> To: zookeeper-user@hadoop.apache.org
> Subject: Re: Recovery issue - how to debug?
> On 04/19/2010 11:55 AM, Travis Crawford wrote:
> > It would be a lot easier from the operations perspective if the leader
> > explicitly published some health stats:
> >
> > (a) Count of instances in the ensemble.
> > (b) Count of up-to-date instances in the ensemble.
> >
> > This would greatly simplify monitoring& alerting - when an instance
> > falls behind one could configure their monitoring system to let
> > someone know and take a look at the logs.
> That's a great idea. Please enter a JIRA for this - a new 4 letter word
> and JMX support. It would also be a great starter project for someone
> interested in becoming more familiar with the server code.
> Patrick
> """
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-744) Add monitoring four-letter word
Posted by "Savu Andrei (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12876091#action_12876091 ]
Savu Andrei commented on ZOOKEEPER-744:
---------------------------------------
@Patrick I have fixed 1-5. I will resubmit the patch after writing some tests to ensure that the node watch count works as expected (I'm having some problems with this part). Right now all tests are passing.
6. I believe the leader does not record the time of the last election. I will look more into this and change the code as needed.
Should I also add JVM memory stats?
> Add monitoring four-letter word
> -------------------------------
>
> Key: ZOOKEEPER-744
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Affects Versions: 3.4.0
> Reporter: Travis Crawford
> Assignee: Savu Andrei
> Fix For: 3.4.0
>
> Attachments: zk-ganglia.png, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch
>
>
> Filing a feature request based on a zookeeper-user discussion.
> Zookeeper should have a new four-letter word that returns key-value pairs appropriate for importing to a monitoring system (such as Ganglia which has a large installed base)
> This command should initially export the following:
> (a) Count of instances in the ensemble.
> (b) Count of up-to-date instances in the ensemble.
> But be designed such that in the future additional data can be added. For example, the output could define the statistic in a comment, then print a key "space character" value line:
> """
> # Total number of instances in the ensemble
> zk_ensemble_instances_total 5
> # Number of instances currently participating in the quorum.
> zk_ensemble_instances_active 4
> """
> From the mailing list:
> """
> Date: Mon, 19 Apr 2010 12:10:44 -0700
> From: Patrick Hunt <ph...@apache.org>
> To: zookeeper-user@hadoop.apache.org
> Subject: Re: Recovery issue - how to debug?
> On 04/19/2010 11:55 AM, Travis Crawford wrote:
> > It would be a lot easier from the operations perspective if the leader
> > explicitly published some health stats:
> >
> > (a) Count of instances in the ensemble.
> > (b) Count of up-to-date instances in the ensemble.
> >
> > This would greatly simplify monitoring& alerting - when an instance
> > falls behind one could configure their monitoring system to let
> > someone know and take a look at the logs.
> That's a great idea. Please enter a JIRA for this - a new 4 letter word
> and JMX support. It would also be a great starter project for someone
> interested in becoming more familiar with the server code.
> Patrick
> """
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-744) Add monitoring four-letter word
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874198#action_12874198 ]
Hadoop QA commented on ZOOKEEPER-744:
-------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12445822/ZOOKEEPER-744.patch
against trunk revision 947063.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 8 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/112/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/112/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/112/console
This message is automatically generated.
> Add monitoring four-letter word
> -------------------------------
>
> Key: ZOOKEEPER-744
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Affects Versions: 3.4.0
> Reporter: Travis Crawford
> Assignee: Savu Andrei
> Fix For: 3.4.0
>
> Attachments: zk-ganglia.png, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch
>
>
> Filing a feature request based on a zookeeper-user discussion.
> Zookeeper should have a new four-letter word that returns key-value pairs appropriate for importing to a monitoring system (such as Ganglia which has a large installed base)
> This command should initially export the following:
> (a) Count of instances in the ensemble.
> (b) Count of up-to-date instances in the ensemble.
> But be designed such that in the future additional data can be added. For example, the output could define the statistic in a comment, then print a key "space character" value line:
> """
> # Total number of instances in the ensemble
> zk_ensemble_instances_total 5
> # Number of instances currently participating in the quorum.
> zk_ensemble_instances_active 4
> """
> From the mailing list:
> """
> Date: Mon, 19 Apr 2010 12:10:44 -0700
> From: Patrick Hunt <ph...@apache.org>
> To: zookeeper-user@hadoop.apache.org
> Subject: Re: Recovery issue - how to debug?
> On 04/19/2010 11:55 AM, Travis Crawford wrote:
> > It would be a lot easier from the operations perspective if the leader
> > explicitly published some health stats:
> >
> > (a) Count of instances in the ensemble.
> > (b) Count of up-to-date instances in the ensemble.
> >
> > This would greatly simplify monitoring& alerting - when an instance
> > falls behind one could configure their monitoring system to let
> > someone know and take a look at the logs.
> That's a great idea. Please enter a JIRA for this - a new 4 letter word
> and JMX support. It would also be a great starter project for someone
> interested in becoming more familiar with the server code.
> Patrick
> """
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-744) Add monitoring four-letter word
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12882736#action_12882736 ]
Hadoop QA commented on ZOOKEEPER-744:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12448091/ZOOKEEPER-744.patch
against trunk revision 958096.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 12 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/121/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/121/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/121/console
This message is automatically generated.
> Add monitoring four-letter word
> -------------------------------
>
> Key: ZOOKEEPER-744
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Affects Versions: 3.4.0
> Reporter: Travis Crawford
> Assignee: Andrei Savu
> Fix For: 3.4.0
>
> Attachments: zk-ganglia.png, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch
>
>
> Filing a feature request based on a zookeeper-user discussion.
> Zookeeper should have a new four-letter word that returns key-value pairs appropriate for importing to a monitoring system (such as Ganglia which has a large installed base)
> This command should initially export the following:
> (a) Count of instances in the ensemble.
> (b) Count of up-to-date instances in the ensemble.
> But be designed such that in the future additional data can be added. For example, the output could define the statistic in a comment, then print a key "space character" value line:
> """
> # Total number of instances in the ensemble
> zk_ensemble_instances_total 5
> # Number of instances currently participating in the quorum.
> zk_ensemble_instances_active 4
> """
> From the mailing list:
> """
> Date: Mon, 19 Apr 2010 12:10:44 -0700
> From: Patrick Hunt <ph...@apache.org>
> To: zookeeper-user@hadoop.apache.org
> Subject: Re: Recovery issue - how to debug?
> On 04/19/2010 11:55 AM, Travis Crawford wrote:
> > It would be a lot easier from the operations perspective if the leader
> > explicitly published some health stats:
> >
> > (a) Count of instances in the ensemble.
> > (b) Count of up-to-date instances in the ensemble.
> >
> > This would greatly simplify monitoring& alerting - when an instance
> > falls behind one could configure their monitoring system to let
> > someone know and take a look at the logs.
> That's a great idea. Please enter a JIRA for this - a new 4 letter word
> and JMX support. It would also be a great starter project for someone
> interested in becoming more familiar with the server code.
> Patrick
> """
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-744) Add monitoring four-letter word
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-744:
-----------------------------------
Status: Open (was: Patch Available)
> Add monitoring four-letter word
> -------------------------------
>
> Key: ZOOKEEPER-744
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Affects Versions: 3.4.0
> Reporter: Travis Crawford
> Assignee: Andrei Savu
> Fix For: 3.4.0
>
> Attachments: zk-ganglia.png, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch
>
>
> Filing a feature request based on a zookeeper-user discussion.
> Zookeeper should have a new four-letter word that returns key-value pairs appropriate for importing to a monitoring system (such as Ganglia which has a large installed base)
> This command should initially export the following:
> (a) Count of instances in the ensemble.
> (b) Count of up-to-date instances in the ensemble.
> But be designed such that in the future additional data can be added. For example, the output could define the statistic in a comment, then print a key "space character" value line:
> """
> # Total number of instances in the ensemble
> zk_ensemble_instances_total 5
> # Number of instances currently participating in the quorum.
> zk_ensemble_instances_active 4
> """
> From the mailing list:
> """
> Date: Mon, 19 Apr 2010 12:10:44 -0700
> From: Patrick Hunt <ph...@apache.org>
> To: zookeeper-user@hadoop.apache.org
> Subject: Re: Recovery issue - how to debug?
> On 04/19/2010 11:55 AM, Travis Crawford wrote:
> > It would be a lot easier from the operations perspective if the leader
> > explicitly published some health stats:
> >
> > (a) Count of instances in the ensemble.
> > (b) Count of up-to-date instances in the ensemble.
> >
> > This would greatly simplify monitoring& alerting - when an instance
> > falls behind one could configure their monitoring system to let
> > someone know and take a look at the logs.
> That's a great idea. Please enter a JIRA for this - a new 4 letter word
> and JMX support. It would also be a great starter project for someone
> interested in becoming more familiar with the server code.
> Patrick
> """
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-744) Add monitoring four-letter word
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12870707#action_12870707 ]
Patrick Hunt commented on ZOOKEEPER-744:
----------------------------------------
Looks good so far. You should update the forrest docs as part of this change, you should detail the format at least (and expectation that order is not maintained, etc...), that this is compatible with java properties format, the content may change (keys added) over time, etc... That way a user will better understand how to integrate and have a reasonable expectation of b/w compatibliity, implementers will also have insight into how they can change this command over time. We didn't do a good job with this for the other commands, but since this is new and intended for integration into third party tools (vs a human always looking at the results) it's a good idea to add. You should add this command to the Tests as well.
> Add monitoring four-letter word
> -------------------------------
>
> Key: ZOOKEEPER-744
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Reporter: Travis Crawford
> Attachments: zk-ganglia.png, ZOOKEEPER-744.patch
>
>
> Filing a feature request based on a zookeeper-user discussion.
> Zookeeper should have a new four-letter word that returns key-value pairs appropriate for importing to a monitoring system (such as Ganglia which has a large installed base)
> This command should initially export the following:
> (a) Count of instances in the ensemble.
> (b) Count of up-to-date instances in the ensemble.
> But be designed such that in the future additional data can be added. For example, the output could define the statistic in a comment, then print a key "space character" value line:
> """
> # Total number of instances in the ensemble
> zk_ensemble_instances_total 5
> # Number of instances currently participating in the quorum.
> zk_ensemble_instances_active 4
> """
> From the mailing list:
> """
> Date: Mon, 19 Apr 2010 12:10:44 -0700
> From: Patrick Hunt <ph...@apache.org>
> To: zookeeper-user@hadoop.apache.org
> Subject: Re: Recovery issue - how to debug?
> On 04/19/2010 11:55 AM, Travis Crawford wrote:
> > It would be a lot easier from the operations perspective if the leader
> > explicitly published some health stats:
> >
> > (a) Count of instances in the ensemble.
> > (b) Count of up-to-date instances in the ensemble.
> >
> > This would greatly simplify monitoring& alerting - when an instance
> > falls behind one could configure their monitoring system to let
> > someone know and take a look at the logs.
> That's a great idea. Please enter a JIRA for this - a new 4 letter word
> and JMX support. It would also be a great starter project for someone
> interested in becoming more familiar with the server code.
> Patrick
> """
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-744) Add monitoring four-letter word
Posted by "Savu Andrei (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Savu Andrei updated ZOOKEEPER-744:
----------------------------------
Status: Patch Available (was: Open)
> Add monitoring four-letter word
> -------------------------------
>
> Key: ZOOKEEPER-744
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Affects Versions: 3.4.0
> Reporter: Travis Crawford
> Assignee: Savu Andrei
> Fix For: 3.4.0
>
> Attachments: zk-ganglia.png, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch
>
>
> Filing a feature request based on a zookeeper-user discussion.
> Zookeeper should have a new four-letter word that returns key-value pairs appropriate for importing to a monitoring system (such as Ganglia which has a large installed base)
> This command should initially export the following:
> (a) Count of instances in the ensemble.
> (b) Count of up-to-date instances in the ensemble.
> But be designed such that in the future additional data can be added. For example, the output could define the statistic in a comment, then print a key "space character" value line:
> """
> # Total number of instances in the ensemble
> zk_ensemble_instances_total 5
> # Number of instances currently participating in the quorum.
> zk_ensemble_instances_active 4
> """
> From the mailing list:
> """
> Date: Mon, 19 Apr 2010 12:10:44 -0700
> From: Patrick Hunt <ph...@apache.org>
> To: zookeeper-user@hadoop.apache.org
> Subject: Re: Recovery issue - how to debug?
> On 04/19/2010 11:55 AM, Travis Crawford wrote:
> > It would be a lot easier from the operations perspective if the leader
> > explicitly published some health stats:
> >
> > (a) Count of instances in the ensemble.
> > (b) Count of up-to-date instances in the ensemble.
> >
> > This would greatly simplify monitoring& alerting - when an instance
> > falls behind one could configure their monitoring system to let
> > someone know and take a look at the logs.
> That's a great idea. Please enter a JIRA for this - a new 4 letter word
> and JMX support. It would also be a great starter project for someone
> interested in becoming more familiar with the server code.
> Patrick
> """
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-744) Add monitoring four-letter word
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-744:
-----------------------------------
Attachment: ZOOKEEPER-744.patch
Updated patch to fix indentation.
Andrei, please update your editor (eclipse?) to use spaces only, no tabs for indentation.
> Add monitoring four-letter word
> -------------------------------
>
> Key: ZOOKEEPER-744
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Affects Versions: 3.4.0
> Reporter: Travis Crawford
> Assignee: Andrei Savu
> Fix For: 3.4.0
>
> Attachments: zk-ganglia.png, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch
>
>
> Filing a feature request based on a zookeeper-user discussion.
> Zookeeper should have a new four-letter word that returns key-value pairs appropriate for importing to a monitoring system (such as Ganglia which has a large installed base)
> This command should initially export the following:
> (a) Count of instances in the ensemble.
> (b) Count of up-to-date instances in the ensemble.
> But be designed such that in the future additional data can be added. For example, the output could define the statistic in a comment, then print a key "space character" value line:
> """
> # Total number of instances in the ensemble
> zk_ensemble_instances_total 5
> # Number of instances currently participating in the quorum.
> zk_ensemble_instances_active 4
> """
> From the mailing list:
> """
> Date: Mon, 19 Apr 2010 12:10:44 -0700
> From: Patrick Hunt <ph...@apache.org>
> To: zookeeper-user@hadoop.apache.org
> Subject: Re: Recovery issue - how to debug?
> On 04/19/2010 11:55 AM, Travis Crawford wrote:
> > It would be a lot easier from the operations perspective if the leader
> > explicitly published some health stats:
> >
> > (a) Count of instances in the ensemble.
> > (b) Count of up-to-date instances in the ensemble.
> >
> > This would greatly simplify monitoring& alerting - when an instance
> > falls behind one could configure their monitoring system to let
> > someone know and take a look at the logs.
> That's a great idea. Please enter a JIRA for this - a new 4 letter word
> and JMX support. It would also be a great starter project for someone
> interested in becoming more familiar with the server code.
> Patrick
> """
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-744) Add monitoring four-letter word
Posted by "Savu Andrei (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Savu Andrei updated ZOOKEEPER-744:
----------------------------------
Attachment: ZOOKEEPER-744.patch
I have fixed the patch: changed forrest docs and added tests.
@Travis: I believe your script should do some sort of filtering / format. Is it really a good idea to just throw any output in Ganglia?
PS: sorry for the late answer, I had some problems with forrest and java1.6
> Add monitoring four-letter word
> -------------------------------
>
> Key: ZOOKEEPER-744
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Reporter: Travis Crawford
> Attachments: zk-ganglia.png, ZOOKEEPER-744.patch
>
>
> Filing a feature request based on a zookeeper-user discussion.
> Zookeeper should have a new four-letter word that returns key-value pairs appropriate for importing to a monitoring system (such as Ganglia which has a large installed base)
> This command should initially export the following:
> (a) Count of instances in the ensemble.
> (b) Count of up-to-date instances in the ensemble.
> But be designed such that in the future additional data can be added. For example, the output could define the statistic in a comment, then print a key "space character" value line:
> """
> # Total number of instances in the ensemble
> zk_ensemble_instances_total 5
> # Number of instances currently participating in the quorum.
> zk_ensemble_instances_active 4
> """
> From the mailing list:
> """
> Date: Mon, 19 Apr 2010 12:10:44 -0700
> From: Patrick Hunt <ph...@apache.org>
> To: zookeeper-user@hadoop.apache.org
> Subject: Re: Recovery issue - how to debug?
> On 04/19/2010 11:55 AM, Travis Crawford wrote:
> > It would be a lot easier from the operations perspective if the leader
> > explicitly published some health stats:
> >
> > (a) Count of instances in the ensemble.
> > (b) Count of up-to-date instances in the ensemble.
> >
> > This would greatly simplify monitoring& alerting - when an instance
> > falls behind one could configure their monitoring system to let
> > someone know and take a look at the logs.
> That's a great idea. Please enter a JIRA for this - a new 4 letter word
> and JMX support. It would also be a great starter project for someone
> interested in becoming more familiar with the server code.
> Patrick
> """
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-744) Add monitoring four-letter word
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12885296#action_12885296 ]
Andrei Savu commented on ZOOKEEPER-744:
---------------------------------------
Thanks for reviewing.
> Add monitoring four-letter word
> -------------------------------
>
> Key: ZOOKEEPER-744
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Affects Versions: 3.4.0
> Reporter: Travis Crawford
> Assignee: Andrei Savu
> Fix For: 3.4.0
>
> Attachments: zk-ganglia.png, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch
>
>
> Filing a feature request based on a zookeeper-user discussion.
> Zookeeper should have a new four-letter word that returns key-value pairs appropriate for importing to a monitoring system (such as Ganglia which has a large installed base)
> This command should initially export the following:
> (a) Count of instances in the ensemble.
> (b) Count of up-to-date instances in the ensemble.
> But be designed such that in the future additional data can be added. For example, the output could define the statistic in a comment, then print a key "space character" value line:
> """
> # Total number of instances in the ensemble
> zk_ensemble_instances_total 5
> # Number of instances currently participating in the quorum.
> zk_ensemble_instances_active 4
> """
> From the mailing list:
> """
> Date: Mon, 19 Apr 2010 12:10:44 -0700
> From: Patrick Hunt <ph...@apache.org>
> To: zookeeper-user@hadoop.apache.org
> Subject: Re: Recovery issue - how to debug?
> On 04/19/2010 11:55 AM, Travis Crawford wrote:
> > It would be a lot easier from the operations perspective if the leader
> > explicitly published some health stats:
> >
> > (a) Count of instances in the ensemble.
> > (b) Count of up-to-date instances in the ensemble.
> >
> > This would greatly simplify monitoring& alerting - when an instance
> > falls behind one could configure their monitoring system to let
> > someone know and take a look at the logs.
> That's a great idea. Please enter a JIRA for this - a new 4 letter word
> and JMX support. It would also be a great starter project for someone
> interested in becoming more familiar with the server code.
> Patrick
> """
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-744) Add monitoring four-letter word
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-744:
-----------------------------------
Status: Patch Available (was: Open)
> Add monitoring four-letter word
> -------------------------------
>
> Key: ZOOKEEPER-744
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Affects Versions: 3.4.0
> Reporter: Travis Crawford
> Assignee: Savu Andrei
> Fix For: 3.4.0
>
> Attachments: zk-ganglia.png, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch
>
>
> Filing a feature request based on a zookeeper-user discussion.
> Zookeeper should have a new four-letter word that returns key-value pairs appropriate for importing to a monitoring system (such as Ganglia which has a large installed base)
> This command should initially export the following:
> (a) Count of instances in the ensemble.
> (b) Count of up-to-date instances in the ensemble.
> But be designed such that in the future additional data can be added. For example, the output could define the statistic in a comment, then print a key "space character" value line:
> """
> # Total number of instances in the ensemble
> zk_ensemble_instances_total 5
> # Number of instances currently participating in the quorum.
> zk_ensemble_instances_active 4
> """
> From the mailing list:
> """
> Date: Mon, 19 Apr 2010 12:10:44 -0700
> From: Patrick Hunt <ph...@apache.org>
> To: zookeeper-user@hadoop.apache.org
> Subject: Re: Recovery issue - how to debug?
> On 04/19/2010 11:55 AM, Travis Crawford wrote:
> > It would be a lot easier from the operations perspective if the leader
> > explicitly published some health stats:
> >
> > (a) Count of instances in the ensemble.
> > (b) Count of up-to-date instances in the ensemble.
> >
> > This would greatly simplify monitoring& alerting - when an instance
> > falls behind one could configure their monitoring system to let
> > someone know and take a look at the logs.
> That's a great idea. Please enter a JIRA for this - a new 4 letter word
> and JMX support. It would also be a great starter project for someone
> interested in becoming more familiar with the server code.
> Patrick
> """
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-744) Add monitoring four-letter word
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-744:
-----------------------------------
Status: Patch Available (was: Open)
> Add monitoring four-letter word
> -------------------------------
>
> Key: ZOOKEEPER-744
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Affects Versions: 3.4.0
> Reporter: Travis Crawford
> Assignee: Savu Andrei
> Fix For: 3.4.0
>
> Attachments: zk-ganglia.png, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch
>
>
> Filing a feature request based on a zookeeper-user discussion.
> Zookeeper should have a new four-letter word that returns key-value pairs appropriate for importing to a monitoring system (such as Ganglia which has a large installed base)
> This command should initially export the following:
> (a) Count of instances in the ensemble.
> (b) Count of up-to-date instances in the ensemble.
> But be designed such that in the future additional data can be added. For example, the output could define the statistic in a comment, then print a key "space character" value line:
> """
> # Total number of instances in the ensemble
> zk_ensemble_instances_total 5
> # Number of instances currently participating in the quorum.
> zk_ensemble_instances_active 4
> """
> From the mailing list:
> """
> Date: Mon, 19 Apr 2010 12:10:44 -0700
> From: Patrick Hunt <ph...@apache.org>
> To: zookeeper-user@hadoop.apache.org
> Subject: Re: Recovery issue - how to debug?
> On 04/19/2010 11:55 AM, Travis Crawford wrote:
> > It would be a lot easier from the operations perspective if the leader
> > explicitly published some health stats:
> >
> > (a) Count of instances in the ensemble.
> > (b) Count of up-to-date instances in the ensemble.
> >
> > This would greatly simplify monitoring& alerting - when an instance
> > falls behind one could configure their monitoring system to let
> > someone know and take a look at the logs.
> That's a great idea. Please enter a JIRA for this - a new 4 letter word
> and JMX support. It would also be a great starter project for someone
> interested in becoming more familiar with the server code.
> Patrick
> """
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-744) Add monitoring four-letter word
Posted by "Savu Andrei (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Savu Andrei updated ZOOKEEPER-744:
----------------------------------
Status: Patch Available (was: Open)
Release Note: Added new 4letter word for monitoring: "mntr" The output is compatible with the Java properties format.Your script should expect content changes: new keys could be added in the future.
Affects Version/s: 3.4.0
Assignee: Savu Andrei
> Add monitoring four-letter word
> -------------------------------
>
> Key: ZOOKEEPER-744
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Affects Versions: 3.4.0
> Reporter: Travis Crawford
> Assignee: Savu Andrei
> Attachments: zk-ganglia.png, ZOOKEEPER-744.patch
>
>
> Filing a feature request based on a zookeeper-user discussion.
> Zookeeper should have a new four-letter word that returns key-value pairs appropriate for importing to a monitoring system (such as Ganglia which has a large installed base)
> This command should initially export the following:
> (a) Count of instances in the ensemble.
> (b) Count of up-to-date instances in the ensemble.
> But be designed such that in the future additional data can be added. For example, the output could define the statistic in a comment, then print a key "space character" value line:
> """
> # Total number of instances in the ensemble
> zk_ensemble_instances_total 5
> # Number of instances currently participating in the quorum.
> zk_ensemble_instances_active 4
> """
> From the mailing list:
> """
> Date: Mon, 19 Apr 2010 12:10:44 -0700
> From: Patrick Hunt <ph...@apache.org>
> To: zookeeper-user@hadoop.apache.org
> Subject: Re: Recovery issue - how to debug?
> On 04/19/2010 11:55 AM, Travis Crawford wrote:
> > It would be a lot easier from the operations perspective if the leader
> > explicitly published some health stats:
> >
> > (a) Count of instances in the ensemble.
> > (b) Count of up-to-date instances in the ensemble.
> >
> > This would greatly simplify monitoring& alerting - when an instance
> > falls behind one could configure their monitoring system to let
> > someone know and take a look at the logs.
> That's a great idea. Please enter a JIRA for this - a new 4 letter word
> and JMX support. It would also be a great starter project for someone
> interested in becoming more familiar with the server code.
> Patrick
> """
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-744) Add monitoring four-letter word
Posted by "Travis Crawford (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Travis Crawford updated ZOOKEEPER-744:
--------------------------------------
Attachment: zk-ganglia.png
Attaching a Ganglia screen capture showing an example of how this data would be used. Many monitoring systems have a way to collect & store timeseries data; exporting these data as easily-parsable plaintext will make writing importers to any monitoring system easy.
> Add monitoring four-letter word
> -------------------------------
>
> Key: ZOOKEEPER-744
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Reporter: Travis Crawford
> Attachments: zk-ganglia.png
>
>
> Filing a feature request based on a zookeeper-user discussion.
> Zookeeper should have a new four-letter word that returns key-value pairs appropriate for importing to a monitoring system (such as Ganglia which has a large installed base)
> This command should initially export the following:
> (a) Count of instances in the ensemble.
> (b) Count of up-to-date instances in the ensemble.
> But be designed such that in the future additional data can be added. For example, the output could define the statistic in a comment, then print a key "space character" value line:
> """
> # Total number of instances in the ensemble
> zk_ensemble_instances_total 5
> # Number of instances currently participating in the quorum.
> zk_ensemble_instances_active 4
> """
> From the mailing list:
> """
> Date: Mon, 19 Apr 2010 12:10:44 -0700
> From: Patrick Hunt <ph...@apache.org>
> To: zookeeper-user@hadoop.apache.org
> Subject: Re: Recovery issue - how to debug?
> On 04/19/2010 11:55 AM, Travis Crawford wrote:
> > It would be a lot easier from the operations perspective if the leader
> > explicitly published some health stats:
> >
> > (a) Count of instances in the ensemble.
> > (b) Count of up-to-date instances in the ensemble.
> >
> > This would greatly simplify monitoring& alerting - when an instance
> > falls behind one could configure their monitoring system to let
> > someone know and take a look at the logs.
> That's a great idea. Please enter a JIRA for this - a new 4 letter word
> and JMX support. It would also be a great starter project for someone
> interested in becoming more familiar with the server code.
> Patrick
> """
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-744) Add monitoring four-letter word
Posted by "Savu Andrei (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Savu Andrei updated ZOOKEEPER-744:
----------------------------------
Attachment: ZOOKEEPER-744.patch
I have added two more keys:
zk_open_file_descriptor_count 23
zk_max_file_descriptor_count 1024
@Travis could you post the zk2ganglia script?
> Add monitoring four-letter word
> -------------------------------
>
> Key: ZOOKEEPER-744
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Affects Versions: 3.4.0
> Reporter: Travis Crawford
> Assignee: Savu Andrei
> Attachments: zk-ganglia.png, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch
>
>
> Filing a feature request based on a zookeeper-user discussion.
> Zookeeper should have a new four-letter word that returns key-value pairs appropriate for importing to a monitoring system (such as Ganglia which has a large installed base)
> This command should initially export the following:
> (a) Count of instances in the ensemble.
> (b) Count of up-to-date instances in the ensemble.
> But be designed such that in the future additional data can be added. For example, the output could define the statistic in a comment, then print a key "space character" value line:
> """
> # Total number of instances in the ensemble
> zk_ensemble_instances_total 5
> # Number of instances currently participating in the quorum.
> zk_ensemble_instances_active 4
> """
> From the mailing list:
> """
> Date: Mon, 19 Apr 2010 12:10:44 -0700
> From: Patrick Hunt <ph...@apache.org>
> To: zookeeper-user@hadoop.apache.org
> Subject: Re: Recovery issue - how to debug?
> On 04/19/2010 11:55 AM, Travis Crawford wrote:
> > It would be a lot easier from the operations perspective if the leader
> > explicitly published some health stats:
> >
> > (a) Count of instances in the ensemble.
> > (b) Count of up-to-date instances in the ensemble.
> >
> > This would greatly simplify monitoring& alerting - when an instance
> > falls behind one could configure their monitoring system to let
> > someone know and take a look at the logs.
> That's a great idea. Please enter a JIRA for this - a new 4 letter word
> and JMX support. It would also be a great starter project for someone
> interested in becoming more familiar with the server code.
> Patrick
> """
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-744) Add monitoring four-letter word
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12878793#action_12878793 ]
Hadoop QA commented on ZOOKEEPER-744:
-------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12447082/ZOOKEEPER-744.patch
against trunk revision 953041.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 16 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/116/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/116/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/116/console
This message is automatically generated.
> Add monitoring four-letter word
> -------------------------------
>
> Key: ZOOKEEPER-744
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Affects Versions: 3.4.0
> Reporter: Travis Crawford
> Assignee: Savu Andrei
> Fix For: 3.4.0
>
> Attachments: zk-ganglia.png, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch
>
>
> Filing a feature request based on a zookeeper-user discussion.
> Zookeeper should have a new four-letter word that returns key-value pairs appropriate for importing to a monitoring system (such as Ganglia which has a large installed base)
> This command should initially export the following:
> (a) Count of instances in the ensemble.
> (b) Count of up-to-date instances in the ensemble.
> But be designed such that in the future additional data can be added. For example, the output could define the statistic in a comment, then print a key "space character" value line:
> """
> # Total number of instances in the ensemble
> zk_ensemble_instances_total 5
> # Number of instances currently participating in the quorum.
> zk_ensemble_instances_active 4
> """
> From the mailing list:
> """
> Date: Mon, 19 Apr 2010 12:10:44 -0700
> From: Patrick Hunt <ph...@apache.org>
> To: zookeeper-user@hadoop.apache.org
> Subject: Re: Recovery issue - how to debug?
> On 04/19/2010 11:55 AM, Travis Crawford wrote:
> > It would be a lot easier from the operations perspective if the leader
> > explicitly published some health stats:
> >
> > (a) Count of instances in the ensemble.
> > (b) Count of up-to-date instances in the ensemble.
> >
> > This would greatly simplify monitoring& alerting - when an instance
> > falls behind one could configure their monitoring system to let
> > someone know and take a look at the logs.
> That's a great idea. Please enter a JIRA for this - a new 4 letter word
> and JMX support. It would also be a great starter project for someone
> interested in becoming more familiar with the server code.
> Patrick
> """
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-744) Add monitoring four-letter word
Posted by "Travis Crawford (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871479#action_12871479 ]
Travis Crawford commented on ZOOKEEPER-744:
-------------------------------------------
Looks awesome! One nit -- many monitoring systems do not interpret strings so it may be appropriate to export everything as numbers. For example, consider a script that loops through these values poking them into Ganglia (or other timeseries database). The script would need special-cased to handle "leader". Later, as more values are added the import script would need updated with the new strings. Doing everything as numbers ensures new values would "just work" without updating other systems.
With that in mind, perhaps:
zk_server_state 1 (instead of: leader)
zk_build_timestamp unix_timestamp (instead of build string)
> Add monitoring four-letter word
> -------------------------------
>
> Key: ZOOKEEPER-744
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Reporter: Travis Crawford
> Attachments: zk-ganglia.png, ZOOKEEPER-744.patch
>
>
> Filing a feature request based on a zookeeper-user discussion.
> Zookeeper should have a new four-letter word that returns key-value pairs appropriate for importing to a monitoring system (such as Ganglia which has a large installed base)
> This command should initially export the following:
> (a) Count of instances in the ensemble.
> (b) Count of up-to-date instances in the ensemble.
> But be designed such that in the future additional data can be added. For example, the output could define the statistic in a comment, then print a key "space character" value line:
> """
> # Total number of instances in the ensemble
> zk_ensemble_instances_total 5
> # Number of instances currently participating in the quorum.
> zk_ensemble_instances_active 4
> """
> From the mailing list:
> """
> Date: Mon, 19 Apr 2010 12:10:44 -0700
> From: Patrick Hunt <ph...@apache.org>
> To: zookeeper-user@hadoop.apache.org
> Subject: Re: Recovery issue - how to debug?
> On 04/19/2010 11:55 AM, Travis Crawford wrote:
> > It would be a lot easier from the operations perspective if the leader
> > explicitly published some health stats:
> >
> > (a) Count of instances in the ensemble.
> > (b) Count of up-to-date instances in the ensemble.
> >
> > This would greatly simplify monitoring& alerting - when an instance
> > falls behind one could configure their monitoring system to let
> > someone know and take a look at the logs.
> That's a great idea. Please enter a JIRA for this - a new 4 letter word
> and JMX support. It would also be a great starter project for someone
> interested in becoming more familiar with the server code.
> Patrick
> """
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-744) Add monitoring four-letter word
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-744:
-----------------------------------
Status: Open (was: Patch Available)
Andrei, looks good, a few comments while reviewing the patch:
1) indicate in the docs that not all keys are available on all platforms (fd count only on unix for example)
2) change "node_count" to "znode_count" (reduce confusion btw serving nodes and znodes)
3) your implementation of ephemeral counting:
org.apache.zookeeper.server.DataTree.getEphemeralsCount()
is inefficient, use entrySet instead (rather than keyset)
4) take a look at how ephemeral counting is done here:
org.apache.zookeeper.server.DataTreeBean.countEphemerals()
You might use refactor to use this code in both places.
5) watch_count is only counting the number of paths that are watched, not the total number of watches (a path may have multiple watches - ie multiple sessions watching the same path)
Looks like this is a bug in the existing implementation (currently only exposed in the bean). You should fix this. Add a test for this while you are at it to verify correct counting.
6) good that you capture the quorum info, is there a way to capture the date/time of the last election?
> Add monitoring four-letter word
> -------------------------------
>
> Key: ZOOKEEPER-744
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Affects Versions: 3.4.0
> Reporter: Travis Crawford
> Assignee: Savu Andrei
> Fix For: 3.4.0
>
> Attachments: zk-ganglia.png, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch
>
>
> Filing a feature request based on a zookeeper-user discussion.
> Zookeeper should have a new four-letter word that returns key-value pairs appropriate for importing to a monitoring system (such as Ganglia which has a large installed base)
> This command should initially export the following:
> (a) Count of instances in the ensemble.
> (b) Count of up-to-date instances in the ensemble.
> But be designed such that in the future additional data can be added. For example, the output could define the statistic in a comment, then print a key "space character" value line:
> """
> # Total number of instances in the ensemble
> zk_ensemble_instances_total 5
> # Number of instances currently participating in the quorum.
> zk_ensemble_instances_active 4
> """
> From the mailing list:
> """
> Date: Mon, 19 Apr 2010 12:10:44 -0700
> From: Patrick Hunt <ph...@apache.org>
> To: zookeeper-user@hadoop.apache.org
> Subject: Re: Recovery issue - how to debug?
> On 04/19/2010 11:55 AM, Travis Crawford wrote:
> > It would be a lot easier from the operations perspective if the leader
> > explicitly published some health stats:
> >
> > (a) Count of instances in the ensemble.
> > (b) Count of up-to-date instances in the ensemble.
> >
> > This would greatly simplify monitoring& alerting - when an instance
> > falls behind one could configure their monitoring system to let
> > someone know and take a look at the logs.
> That's a great idea. Please enter a JIRA for this - a new 4 letter word
> and JMX support. It would also be a great starter project for someone
> interested in becoming more familiar with the server code.
> Patrick
> """
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-744) Add monitoring four-letter word
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874111#action_12874111 ]
Patrick Hunt commented on ZOOKEEPER-744:
----------------------------------------
Andrei, are you are still working on this or should I review for commit?
> Add monitoring four-letter word
> -------------------------------
>
> Key: ZOOKEEPER-744
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Affects Versions: 3.4.0
> Reporter: Travis Crawford
> Assignee: Savu Andrei
> Fix For: 3.4.0
>
> Attachments: zk-ganglia.png, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch
>
>
> Filing a feature request based on a zookeeper-user discussion.
> Zookeeper should have a new four-letter word that returns key-value pairs appropriate for importing to a monitoring system (such as Ganglia which has a large installed base)
> This command should initially export the following:
> (a) Count of instances in the ensemble.
> (b) Count of up-to-date instances in the ensemble.
> But be designed such that in the future additional data can be added. For example, the output could define the statistic in a comment, then print a key "space character" value line:
> """
> # Total number of instances in the ensemble
> zk_ensemble_instances_total 5
> # Number of instances currently participating in the quorum.
> zk_ensemble_instances_active 4
> """
> From the mailing list:
> """
> Date: Mon, 19 Apr 2010 12:10:44 -0700
> From: Patrick Hunt <ph...@apache.org>
> To: zookeeper-user@hadoop.apache.org
> Subject: Re: Recovery issue - how to debug?
> On 04/19/2010 11:55 AM, Travis Crawford wrote:
> > It would be a lot easier from the operations perspective if the leader
> > explicitly published some health stats:
> >
> > (a) Count of instances in the ensemble.
> > (b) Count of up-to-date instances in the ensemble.
> >
> > This would greatly simplify monitoring& alerting - when an instance
> > falls behind one could configure their monitoring system to let
> > someone know and take a look at the logs.
> That's a great idea. Please enter a JIRA for this - a new 4 letter word
> and JMX support. It would also be a great starter project for someone
> interested in becoming more familiar with the server code.
> Patrick
> """
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-744) Add monitoring four-letter word
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12882759#action_12882759 ]
Hadoop QA commented on ZOOKEEPER-744:
-------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12448091/ZOOKEEPER-744.patch
against trunk revision 958096.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 12 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/122/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/122/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/122/console
This message is automatically generated.
> Add monitoring four-letter word
> -------------------------------
>
> Key: ZOOKEEPER-744
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Affects Versions: 3.4.0
> Reporter: Travis Crawford
> Assignee: Andrei Savu
> Fix For: 3.4.0
>
> Attachments: zk-ganglia.png, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch
>
>
> Filing a feature request based on a zookeeper-user discussion.
> Zookeeper should have a new four-letter word that returns key-value pairs appropriate for importing to a monitoring system (such as Ganglia which has a large installed base)
> This command should initially export the following:
> (a) Count of instances in the ensemble.
> (b) Count of up-to-date instances in the ensemble.
> But be designed such that in the future additional data can be added. For example, the output could define the statistic in a comment, then print a key "space character" value line:
> """
> # Total number of instances in the ensemble
> zk_ensemble_instances_total 5
> # Number of instances currently participating in the quorum.
> zk_ensemble_instances_active 4
> """
> From the mailing list:
> """
> Date: Mon, 19 Apr 2010 12:10:44 -0700
> From: Patrick Hunt <ph...@apache.org>
> To: zookeeper-user@hadoop.apache.org
> Subject: Re: Recovery issue - how to debug?
> On 04/19/2010 11:55 AM, Travis Crawford wrote:
> > It would be a lot easier from the operations perspective if the leader
> > explicitly published some health stats:
> >
> > (a) Count of instances in the ensemble.
> > (b) Count of up-to-date instances in the ensemble.
> >
> > This would greatly simplify monitoring& alerting - when an instance
> > falls behind one could configure their monitoring system to let
> > someone know and take a look at the logs.
> That's a great idea. Please enter a JIRA for this - a new 4 letter word
> and JMX support. It would also be a great starter project for someone
> interested in becoming more familiar with the server code.
> Patrick
> """
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-744) Add monitoring four-letter word
Posted by "Savu Andrei (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Savu Andrei updated ZOOKEEPER-744:
----------------------------------
Attachment: (was: ZOOKEEPER-744.patch)
> Add monitoring four-letter word
> -------------------------------
>
> Key: ZOOKEEPER-744
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Reporter: Travis Crawford
> Attachments: zk-ganglia.png, ZOOKEEPER-744.patch
>
>
> Filing a feature request based on a zookeeper-user discussion.
> Zookeeper should have a new four-letter word that returns key-value pairs appropriate for importing to a monitoring system (such as Ganglia which has a large installed base)
> This command should initially export the following:
> (a) Count of instances in the ensemble.
> (b) Count of up-to-date instances in the ensemble.
> But be designed such that in the future additional data can be added. For example, the output could define the statistic in a comment, then print a key "space character" value line:
> """
> # Total number of instances in the ensemble
> zk_ensemble_instances_total 5
> # Number of instances currently participating in the quorum.
> zk_ensemble_instances_active 4
> """
> From the mailing list:
> """
> Date: Mon, 19 Apr 2010 12:10:44 -0700
> From: Patrick Hunt <ph...@apache.org>
> To: zookeeper-user@hadoop.apache.org
> Subject: Re: Recovery issue - how to debug?
> On 04/19/2010 11:55 AM, Travis Crawford wrote:
> > It would be a lot easier from the operations perspective if the leader
> > explicitly published some health stats:
> >
> > (a) Count of instances in the ensemble.
> > (b) Count of up-to-date instances in the ensemble.
> >
> > This would greatly simplify monitoring& alerting - when an instance
> > falls behind one could configure their monitoring system to let
> > someone know and take a look at the logs.
> That's a great idea. Please enter a JIRA for this - a new 4 letter word
> and JMX support. It would also be a great starter project for someone
> interested in becoming more familiar with the server code.
> Patrick
> """
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-744) Add monitoring four-letter word
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12876294#action_12876294 ]
Patrick Hunt commented on ZOOKEEPER-744:
----------------------------------------
iirc 6 is in the jmx intf, perhaps that captures the election time itself, take a look, perhaps it needs to be moved out to the election object itself.
> Add monitoring four-letter word
> -------------------------------
>
> Key: ZOOKEEPER-744
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Affects Versions: 3.4.0
> Reporter: Travis Crawford
> Assignee: Savu Andrei
> Fix For: 3.4.0
>
> Attachments: zk-ganglia.png, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch
>
>
> Filing a feature request based on a zookeeper-user discussion.
> Zookeeper should have a new four-letter word that returns key-value pairs appropriate for importing to a monitoring system (such as Ganglia which has a large installed base)
> This command should initially export the following:
> (a) Count of instances in the ensemble.
> (b) Count of up-to-date instances in the ensemble.
> But be designed such that in the future additional data can be added. For example, the output could define the statistic in a comment, then print a key "space character" value line:
> """
> # Total number of instances in the ensemble
> zk_ensemble_instances_total 5
> # Number of instances currently participating in the quorum.
> zk_ensemble_instances_active 4
> """
> From the mailing list:
> """
> Date: Mon, 19 Apr 2010 12:10:44 -0700
> From: Patrick Hunt <ph...@apache.org>
> To: zookeeper-user@hadoop.apache.org
> Subject: Re: Recovery issue - how to debug?
> On 04/19/2010 11:55 AM, Travis Crawford wrote:
> > It would be a lot easier from the operations perspective if the leader
> > explicitly published some health stats:
> >
> > (a) Count of instances in the ensemble.
> > (b) Count of up-to-date instances in the ensemble.
> >
> > This would greatly simplify monitoring& alerting - when an instance
> > falls behind one could configure their monitoring system to let
> > someone know and take a look at the logs.
> That's a great idea. Please enter a JIRA for this - a new 4 letter word
> and JMX support. It would also be a great starter project for someone
> interested in becoming more familiar with the server code.
> Patrick
> """
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-744) Add monitoring four-letter word
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12885510#action_12885510 ]
Hudson commented on ZOOKEEPER-744:
----------------------------------
Integrated in ZooKeeper-trunk #869 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/869/])
ZOOKEEPER-744. Add monitoring four-letter word
> Add monitoring four-letter word
> -------------------------------
>
> Key: ZOOKEEPER-744
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Affects Versions: 3.4.0
> Reporter: Travis Crawford
> Assignee: Andrei Savu
> Fix For: 3.4.0
>
> Attachments: zk-ganglia.png, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch
>
>
> Filing a feature request based on a zookeeper-user discussion.
> Zookeeper should have a new four-letter word that returns key-value pairs appropriate for importing to a monitoring system (such as Ganglia which has a large installed base)
> This command should initially export the following:
> (a) Count of instances in the ensemble.
> (b) Count of up-to-date instances in the ensemble.
> But be designed such that in the future additional data can be added. For example, the output could define the statistic in a comment, then print a key "space character" value line:
> """
> # Total number of instances in the ensemble
> zk_ensemble_instances_total 5
> # Number of instances currently participating in the quorum.
> zk_ensemble_instances_active 4
> """
> From the mailing list:
> """
> Date: Mon, 19 Apr 2010 12:10:44 -0700
> From: Patrick Hunt <ph...@apache.org>
> To: zookeeper-user@hadoop.apache.org
> Subject: Re: Recovery issue - how to debug?
> On 04/19/2010 11:55 AM, Travis Crawford wrote:
> > It would be a lot easier from the operations perspective if the leader
> > explicitly published some health stats:
> >
> > (a) Count of instances in the ensemble.
> > (b) Count of up-to-date instances in the ensemble.
> >
> > This would greatly simplify monitoring& alerting - when an instance
> > falls behind one could configure their monitoring system to let
> > someone know and take a look at the logs.
> That's a great idea. Please enter a JIRA for this - a new 4 letter word
> and JMX support. It would also be a great starter project for someone
> interested in becoming more familiar with the server code.
> Patrick
> """
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-744) Add monitoring four-letter word
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12872176#action_12872176 ]
Hadoop QA commented on ZOOKEEPER-744:
-------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12445586/ZOOKEEPER-744.patch
against trunk revision 947063.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 8 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/109/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/109/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/109/console
This message is automatically generated.
> Add monitoring four-letter word
> -------------------------------
>
> Key: ZOOKEEPER-744
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Affects Versions: 3.4.0
> Reporter: Travis Crawford
> Assignee: Savu Andrei
> Attachments: zk-ganglia.png, ZOOKEEPER-744.patch
>
>
> Filing a feature request based on a zookeeper-user discussion.
> Zookeeper should have a new four-letter word that returns key-value pairs appropriate for importing to a monitoring system (such as Ganglia which has a large installed base)
> This command should initially export the following:
> (a) Count of instances in the ensemble.
> (b) Count of up-to-date instances in the ensemble.
> But be designed such that in the future additional data can be added. For example, the output could define the statistic in a comment, then print a key "space character" value line:
> """
> # Total number of instances in the ensemble
> zk_ensemble_instances_total 5
> # Number of instances currently participating in the quorum.
> zk_ensemble_instances_active 4
> """
> From the mailing list:
> """
> Date: Mon, 19 Apr 2010 12:10:44 -0700
> From: Patrick Hunt <ph...@apache.org>
> To: zookeeper-user@hadoop.apache.org
> Subject: Re: Recovery issue - how to debug?
> On 04/19/2010 11:55 AM, Travis Crawford wrote:
> > It would be a lot easier from the operations perspective if the leader
> > explicitly published some health stats:
> >
> > (a) Count of instances in the ensemble.
> > (b) Count of up-to-date instances in the ensemble.
> >
> > This would greatly simplify monitoring& alerting - when an instance
> > falls behind one could configure their monitoring system to let
> > someone know and take a look at the logs.
> That's a great idea. Please enter a JIRA for this - a new 4 letter word
> and JMX support. It would also be a great starter project for someone
> interested in becoming more familiar with the server code.
> Patrick
> """
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-744) Add monitoring four-letter word
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-744:
-----------------------------------
Status: Open (was: Patch Available)
> Add monitoring four-letter word
> -------------------------------
>
> Key: ZOOKEEPER-744
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Affects Versions: 3.4.0
> Reporter: Travis Crawford
> Assignee: Savu Andrei
> Fix For: 3.4.0
>
> Attachments: zk-ganglia.png, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch
>
>
> Filing a feature request based on a zookeeper-user discussion.
> Zookeeper should have a new four-letter word that returns key-value pairs appropriate for importing to a monitoring system (such as Ganglia which has a large installed base)
> This command should initially export the following:
> (a) Count of instances in the ensemble.
> (b) Count of up-to-date instances in the ensemble.
> But be designed such that in the future additional data can be added. For example, the output could define the statistic in a comment, then print a key "space character" value line:
> """
> # Total number of instances in the ensemble
> zk_ensemble_instances_total 5
> # Number of instances currently participating in the quorum.
> zk_ensemble_instances_active 4
> """
> From the mailing list:
> """
> Date: Mon, 19 Apr 2010 12:10:44 -0700
> From: Patrick Hunt <ph...@apache.org>
> To: zookeeper-user@hadoop.apache.org
> Subject: Re: Recovery issue - how to debug?
> On 04/19/2010 11:55 AM, Travis Crawford wrote:
> > It would be a lot easier from the operations perspective if the leader
> > explicitly published some health stats:
> >
> > (a) Count of instances in the ensemble.
> > (b) Count of up-to-date instances in the ensemble.
> >
> > This would greatly simplify monitoring& alerting - when an instance
> > falls behind one could configure their monitoring system to let
> > someone know and take a look at the logs.
> That's a great idea. Please enter a JIRA for this - a new 4 letter word
> and JMX support. It would also be a great starter project for someone
> interested in becoming more familiar with the server code.
> Patrick
> """
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-744) Add monitoring four-letter word
Posted by "Savu Andrei (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874148#action_12874148 ]
Savu Andrei commented on ZOOKEEPER-744:
---------------------------------------
You can review the patch for commit. Right know I'm writing monitoring scripts for Nagios, Cacti and Ganglia (in this order). The script for nagios is almost ready. Thanks.
-original message-
Subject: [jira] Commented: (ZOOKEEPER-744) Add monitoring four-letter word
From: "Patrick Hunt (JIRA)" <ji...@apache.org>
Date: 01/06/2010 19:07
[ https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874111#action_12874111 ]
Patrick Hunt commented on ZOOKEEPER-744:
----------------------------------------
Andrei, are you are still working on this or should I review for commit?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
> Add monitoring four-letter word
> -------------------------------
>
> Key: ZOOKEEPER-744
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Affects Versions: 3.4.0
> Reporter: Travis Crawford
> Assignee: Savu Andrei
> Fix For: 3.4.0
>
> Attachments: zk-ganglia.png, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch
>
>
> Filing a feature request based on a zookeeper-user discussion.
> Zookeeper should have a new four-letter word that returns key-value pairs appropriate for importing to a monitoring system (such as Ganglia which has a large installed base)
> This command should initially export the following:
> (a) Count of instances in the ensemble.
> (b) Count of up-to-date instances in the ensemble.
> But be designed such that in the future additional data can be added. For example, the output could define the statistic in a comment, then print a key "space character" value line:
> """
> # Total number of instances in the ensemble
> zk_ensemble_instances_total 5
> # Number of instances currently participating in the quorum.
> zk_ensemble_instances_active 4
> """
> From the mailing list:
> """
> Date: Mon, 19 Apr 2010 12:10:44 -0700
> From: Patrick Hunt <ph...@apache.org>
> To: zookeeper-user@hadoop.apache.org
> Subject: Re: Recovery issue - how to debug?
> On 04/19/2010 11:55 AM, Travis Crawford wrote:
> > It would be a lot easier from the operations perspective if the leader
> > explicitly published some health stats:
> >
> > (a) Count of instances in the ensemble.
> > (b) Count of up-to-date instances in the ensemble.
> >
> > This would greatly simplify monitoring& alerting - when an instance
> > falls behind one could configure their monitoring system to let
> > someone know and take a look at the logs.
> That's a great idea. Please enter a JIRA for this - a new 4 letter word
> and JMX support. It would also be a great starter project for someone
> interested in becoming more familiar with the server code.
> Patrick
> """
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-744) Add monitoring four-letter word
Posted by "Savu Andrei (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Savu Andrei updated ZOOKEEPER-744:
----------------------------------
Attachment: ZOOKEEPER-744.patch
Added one more 4letter word for monitoring: mntr
Output:
$ echo mntr | nc localhost 2185
zk_version 3.4.0--1, built on 05/24/2010 12:38 GMT
zk_avg_latency 0
zk_max_latency 0
zk_min_latency 0
zk_packets_received 70
zk_packets_sent 69
zk_outstanding_requests 0
zk_server_state leader
zk_node_count 4
zk_watch_count 0
zk_ephemerals_count 0
zk_approximate_data_size 27
zk_followers 4
zk_synced_followers 4
zk_pending_syncs 0
What else should I add here?
> Add monitoring four-letter word
> -------------------------------
>
> Key: ZOOKEEPER-744
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Reporter: Travis Crawford
> Attachments: zk-ganglia.png, ZOOKEEPER-744.patch
>
>
> Filing a feature request based on a zookeeper-user discussion.
> Zookeeper should have a new four-letter word that returns key-value pairs appropriate for importing to a monitoring system (such as Ganglia which has a large installed base)
> This command should initially export the following:
> (a) Count of instances in the ensemble.
> (b) Count of up-to-date instances in the ensemble.
> But be designed such that in the future additional data can be added. For example, the output could define the statistic in a comment, then print a key "space character" value line:
> """
> # Total number of instances in the ensemble
> zk_ensemble_instances_total 5
> # Number of instances currently participating in the quorum.
> zk_ensemble_instances_active 4
> """
> From the mailing list:
> """
> Date: Mon, 19 Apr 2010 12:10:44 -0700
> From: Patrick Hunt <ph...@apache.org>
> To: zookeeper-user@hadoop.apache.org
> Subject: Re: Recovery issue - how to debug?
> On 04/19/2010 11:55 AM, Travis Crawford wrote:
> > It would be a lot easier from the operations perspective if the leader
> > explicitly published some health stats:
> >
> > (a) Count of instances in the ensemble.
> > (b) Count of up-to-date instances in the ensemble.
> >
> > This would greatly simplify monitoring& alerting - when an instance
> > falls behind one could configure their monitoring system to let
> > someone know and take a look at the logs.
> That's a great idea. Please enter a JIRA for this - a new 4 letter word
> and JMX support. It would also be a great starter project for someone
> interested in becoming more familiar with the server code.
> Patrick
> """
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-744) Add monitoring four-letter word
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858719#action_12858719 ]
Mahadev konar commented on ZOOKEEPER-744:
-----------------------------------------
thats cool !!!!
> Add monitoring four-letter word
> -------------------------------
>
> Key: ZOOKEEPER-744
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Reporter: Travis Crawford
> Attachments: zk-ganglia.png
>
>
> Filing a feature request based on a zookeeper-user discussion.
> Zookeeper should have a new four-letter word that returns key-value pairs appropriate for importing to a monitoring system (such as Ganglia which has a large installed base)
> This command should initially export the following:
> (a) Count of instances in the ensemble.
> (b) Count of up-to-date instances in the ensemble.
> But be designed such that in the future additional data can be added. For example, the output could define the statistic in a comment, then print a key "space character" value line:
> """
> # Total number of instances in the ensemble
> zk_ensemble_instances_total 5
> # Number of instances currently participating in the quorum.
> zk_ensemble_instances_active 4
> """
> From the mailing list:
> """
> Date: Mon, 19 Apr 2010 12:10:44 -0700
> From: Patrick Hunt <ph...@apache.org>
> To: zookeeper-user@hadoop.apache.org
> Subject: Re: Recovery issue - how to debug?
> On 04/19/2010 11:55 AM, Travis Crawford wrote:
> > It would be a lot easier from the operations perspective if the leader
> > explicitly published some health stats:
> >
> > (a) Count of instances in the ensemble.
> > (b) Count of up-to-date instances in the ensemble.
> >
> > This would greatly simplify monitoring& alerting - when an instance
> > falls behind one could configure their monitoring system to let
> > someone know and take a look at the logs.
> That's a great idea. Please enter a JIRA for this - a new 4 letter word
> and JMX support. It would also be a great starter project for someone
> interested in becoming more familiar with the server code.
> Patrick
> """
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-744) Add monitoring four-letter word
Posted by "Travis Crawford (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12872284#action_12872284 ]
Travis Crawford commented on ZOOKEEPER-744:
-------------------------------------------
@savu - Sometimes the "right" thing is publishing everything, sometimes not. In this case I'll have some filtering/formatting in the zk2ganglia script.
> Add monitoring four-letter word
> -------------------------------
>
> Key: ZOOKEEPER-744
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Affects Versions: 3.4.0
> Reporter: Travis Crawford
> Assignee: Savu Andrei
> Attachments: zk-ganglia.png, ZOOKEEPER-744.patch
>
>
> Filing a feature request based on a zookeeper-user discussion.
> Zookeeper should have a new four-letter word that returns key-value pairs appropriate for importing to a monitoring system (such as Ganglia which has a large installed base)
> This command should initially export the following:
> (a) Count of instances in the ensemble.
> (b) Count of up-to-date instances in the ensemble.
> But be designed such that in the future additional data can be added. For example, the output could define the statistic in a comment, then print a key "space character" value line:
> """
> # Total number of instances in the ensemble
> zk_ensemble_instances_total 5
> # Number of instances currently participating in the quorum.
> zk_ensemble_instances_active 4
> """
> From the mailing list:
> """
> Date: Mon, 19 Apr 2010 12:10:44 -0700
> From: Patrick Hunt <ph...@apache.org>
> To: zookeeper-user@hadoop.apache.org
> Subject: Re: Recovery issue - how to debug?
> On 04/19/2010 11:55 AM, Travis Crawford wrote:
> > It would be a lot easier from the operations perspective if the leader
> > explicitly published some health stats:
> >
> > (a) Count of instances in the ensemble.
> > (b) Count of up-to-date instances in the ensemble.
> >
> > This would greatly simplify monitoring& alerting - when an instance
> > falls behind one could configure their monitoring system to let
> > someone know and take a look at the logs.
> That's a great idea. Please enter a JIRA for this - a new 4 letter word
> and JMX support. It would also be a great starter project for someone
> interested in becoming more familiar with the server code.
> Patrick
> """
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.