[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1234: HDDS-1917. Ignore failing test-cases in TestSecureOzoneRpcClient.

[GitBox <gi...@apache.org>]

xiaoyuyao commented on a change in pull request #1234: HDDS-1917. Ignore failing test-cases in TestSecureOzoneRpcClient.
URL: https://github.com/apache/hadoop/pull/1234#discussion_r311293111
 
 

 ##########
 File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestOzoneRpcClientAbstract.java
 ##########
 @@ -2280,6 +2280,7 @@ public void testNativeAclsForVolume() throws Exception {
     validateOzoneAccessAcl(ozObj);
   }
 
+  @Ignore("This will be fixed when HA support is added to acl operations")
 
 Review comment:
   Instead of Ignore for all subclasses, Can we just ignore these ACL related test cases for Ratis/HA like below at the begin of TestOzoneRpcClientAbstract#testNativeAclsForKey/Volume/Bucket/Prefix? This way, we still have all the coverage of non-HA cases for ACL, which is the main feature of ozone-0.4.1.
   
   {code}
       assumeFalse("Remove this once ACL HA is supported",
           getClass().equals(TestOzoneRpcClientWithRatis.class));
   {code}
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org