You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by ke...@apache.org on 2021/10/21 13:29:31 UTC

[skywalking-python] branch flake8 created (now 3142dc3)

This is an automated email from the ASF dual-hosted git repository.

kezhenxu94 pushed a change to branch flake8
in repository https://gitbox.apache.org/repos/asf/skywalking-python.git.


      at 3142dc3  Move flake configs all together

This branch includes the following new commits:

     new 3142dc3  Move flake configs all together

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


[skywalking-python] 01/01: Move flake configs all together

Posted by ke...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

kezhenxu94 pushed a commit to branch flake8
in repository https://gitbox.apache.org/repos/asf/skywalking-python.git

commit 3142dc3a41e141a51a6ee12c323c87608520897b
Author: kezhenxu94 <ke...@apache.org>
AuthorDate: Thu Oct 21 21:29:20 2021 +0800

    Move flake configs all together
---
 .flake8  | 6 ++++--
 Makefile | 8 ++++----
 2 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/.flake8 b/.flake8
index c0044e9..e42adb6 100644
--- a/.flake8
+++ b/.flake8
@@ -17,5 +17,7 @@
 [flake8]
 ignore = E501, E126, W503  # careful with E303, which may cause too many blank lines in pycharm formatted code
 max-line-length = 120
-max-complexity = 15
-exclude = venv*,*egg_info,protocol
\ No newline at end of file
+max-complexity = 20
+exclude = venv*,*egg_info,protocol
+count = True
+show-source = True
diff --git a/Makefile b/Makefile
index eb7904b..d89003d 100644
--- a/Makefile
+++ b/Makefile
@@ -30,12 +30,12 @@ gen:
 	python3 tools/codegen.py
 
 lint: clean
-	flake8 --version || python3 -m pip install flake8
-	flake8 . --count --show-source --max-complexity 20
+	# flake8 configurations should go to the file .flake8
+	flake8 --version || python3 -m pip install flake8 && flake8 .
 
 dev-check:
-	flake8 --version || python3 -m pip install flake8
-	flake8 . --count --show-source --max-complexity 20
+	# flake8 configurations should go to the file .flake8
+	flake8 --version || python3 -m pip install flake8 && flake8 .
 	python3 tools/check-license-header.py skywalking tests tools
 
 license: clean