You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Jesse Long (Created) (JIRA)" <ji...@apache.org> on 2012/03/28 22:39:28 UTC

[jira] [Created] (WICKET-4484) wicket:link component ids get too long

wicket:link component ids get too long
--------------------------------------

                 Key: WICKET-4484
                 URL: https://issues.apache.org/jira/browse/WICKET-4484
             Project: Wicket
          Issue Type: Bug
          Components: wicket
    Affects Versions: 1.5.5, 1.5.4, 1.5.3, 1.5.2, 1.5.1, 1.5.0
            Reporter: Jesse Long


The resolve() method of org.apache.wicket.markup.parser.filter.WicketLinkTagHandler appends modifies the original tag id and appends the next autoId to it. The problem is that this is done during every render, the the component id gets longer and longer.

I had a situation on a production server where component ids were over 10k. RepeatingView just added to the problem.

Long story short, I think resolve should just return the TransparentWebMarkupContainer with the modified id, and not set the original id.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (WICKET-4484) wicket:link component ids get too long

Posted by "Jesse Long (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jesse Long updated WICKET-4484:
-------------------------------

    Attachment: WICKET-4484.patch

This is what I have done to resolve the issue. I have tested and it works for me. Please verify that this is correct, I'm not sure I understand the implications 100%.
                
> wicket:link component ids get too long
> --------------------------------------
>
>                 Key: WICKET-4484
>                 URL: https://issues.apache.org/jira/browse/WICKET-4484
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5.0, 1.5.1, 1.5.2, 1.5.3, 1.5.4, 1.5.5
>            Reporter: Jesse Long
>         Attachments: WICKET-4484.patch
>
>
> The resolve() method of org.apache.wicket.markup.parser.filter.WicketLinkTagHandler appends modifies the original tag id and appends the next autoId to it. The problem is that this is done during every render, the the component id gets longer and longer.
> I had a situation on a production server where component ids were over 10k. RepeatingView just added to the problem.
> Long story short, I think resolve should just return the TransparentWebMarkupContainer with the modified id, and not set the original id.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (WICKET-4484) wicket:link component ids get too long

Posted by "Sven Meier (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sven Meier resolved WICKET-4484.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 6.0.0-RC1
                   1.5.6
         Assignee: Sven Meier

You're dead right, the tag id is not supposed to be changed by the component resolver.

Thanks for reporting this issue!
                
> wicket:link component ids get too long
> --------------------------------------
>
>                 Key: WICKET-4484
>                 URL: https://issues.apache.org/jira/browse/WICKET-4484
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5.0, 1.5.1, 1.5.2, 1.5.3, 1.5.4, 1.5.5
>            Reporter: Jesse Long
>            Assignee: Sven Meier
>             Fix For: 1.5.6, 6.0.0-RC1
>
>         Attachments: WICKET-4484.patch
>
>
> The resolve() method of org.apache.wicket.markup.parser.filter.WicketLinkTagHandler appends modifies the original tag id and appends the next autoId to it. The problem is that this is done during every render, the the component id gets longer and longer.
> I had a situation on a production server where component ids were over 10k. RepeatingView just added to the problem.
> Long story short, I think resolve should just return the TransparentWebMarkupContainer with the modified id, and not set the original id.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira