[GitHub] [accumulo] dlmarion commented on pull request #3067: Reduce logging when external compactions are cancelled

[GitBox <gi...@apache.org>]

dlmarion commented on PR #3067:
URL: https://github.com/apache/accumulo/pull/3067#issuecomment-1307264651

   The CompactionEnv implementation that is used in External Compactions is [ExtCEnv](https://github.com/apache/accumulo/blob/main/server/compactor/src/main/java/org/apache/accumulo/compactor/ExtCEnv.java). When [CompactionJobHolder.cancel()](https://github.com/apache/accumulo/blob/main/server/compactor/src/main/java/org/apache/accumulo/compactor/CompactionJobHolder.java#L61) is called, then ExtCEnv.isCompactionEnabled() returns false. CompactionJobHolder.cancel() is called from several places in Compactor.java. When it's called from Compactor.checkIfCanceled, then it's not an error, the compaction is being canceled because the tablet split, the table was deleted, or the user canceled the compaction. I think in this case, it warrants a debug message. When CompactionJobHolder.cancel is called via Compactor.cancel(String) from Compactor.run(), it's preceded by an error message.
   
   I'm thinking that when env.isCompactionEnabled() returns false in FileCompactor.compactLocalityGroup() and a CompactionCanceledException is thrown, then FileCompactor.call() should log a debug message in the exception handler *and* suppress logging in the finally block.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org