You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/11/01 19:16:00 UTC
Review Request 15185: Adjusted Master failover tests to use the same flags
across Master runs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15185/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Repository: mesos-git
Description
-------
This is sufficient for making all the existing tests pass with the new stateful Master.
Diffs
-----
src/tests/allocator_zookeeper_tests.cpp 9ad0fa7c9ac970bf3a68d28a3ce756fc2b38c9c4
src/tests/fault_tolerance_tests.cpp 3989e14eb926d7f9b5c7731aa0713a56fc3fb6e9
src/tests/slave_recovery_tests.cpp 37faf2054750080902cb06b62da9a9e2252c566f
Diff: https://reviews.apache.org/r/15185/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request 15185: Adjusted Master failover tests to use the same
flags across Master runs.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15185/#review43174
-----------------------------------------------------------
is this still relevant?
- Vinod Kone
On Nov. 5, 2013, 10:29 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15185/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2013, 10:29 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This is sufficient for making all the existing tests pass with the new stateful Master.
>
>
> Diffs
> -----
>
> src/tests/allocator_zookeeper_tests.cpp 9ad0fa7c9ac970bf3a68d28a3ce756fc2b38c9c4
> src/tests/fault_tolerance_tests.cpp d521f4be3e5297b7ab8f21f4173733bc2a2001c9
> src/tests/slave_recovery_tests.cpp 37faf2054750080902cb06b62da9a9e2252c566f
>
> Diff: https://reviews.apache.org/r/15185/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 15185: Adjusted Master failover tests to use the same
flags across Master runs.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15185/#review31062
-----------------------------------------------------------
Ship it!
src/tests/allocator_zookeeper_tests.cpp
<https://reviews.apache.org/r/15185/#comment59401>
Perhaps a comment on why you do Stop() instead of ShutdownMasters() ?
- Vinod Kone
On Nov. 5, 2013, 10:29 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15185/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2013, 10:29 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This is sufficient for making all the existing tests pass with the new stateful Master.
>
>
> Diffs
> -----
>
> src/tests/allocator_zookeeper_tests.cpp 9ad0fa7c9ac970bf3a68d28a3ce756fc2b38c9c4
> src/tests/fault_tolerance_tests.cpp d521f4be3e5297b7ab8f21f4173733bc2a2001c9
> src/tests/slave_recovery_tests.cpp 37faf2054750080902cb06b62da9a9e2252c566f
>
> Diff: https://reviews.apache.org/r/15185/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 15185: Adjusted Master failover tests to use the same
flags across Master runs.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15185/
-----------------------------------------------------------
(Updated Nov. 5, 2013, 10:29 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
No change, minor rebase.
Repository: mesos-git
Description
-------
This is sufficient for making all the existing tests pass with the new stateful Master.
Diffs (updated)
-----
src/tests/allocator_zookeeper_tests.cpp 9ad0fa7c9ac970bf3a68d28a3ce756fc2b38c9c4
src/tests/fault_tolerance_tests.cpp d521f4be3e5297b7ab8f21f4173733bc2a2001c9
src/tests/slave_recovery_tests.cpp 37faf2054750080902cb06b62da9a9e2252c566f
Diff: https://reviews.apache.org/r/15185/diff/
Testing
-------
make check
Thanks,
Ben Mahler