[GitHub] [nifi] NissimShiman commented on a diff in pull request #6414: NIFI-9878 fix for hanging client thread with handshake does not complete

[GitBox <gi...@apache.org>]

NissimShiman commented on code in PR #6414:
URL: https://github.com/apache/nifi/pull/6414#discussion_r990401868


##########
nifi-nar-bundles/nifi-standard-services/nifi-distributed-cache-services-bundle/nifi-distributed-cache-server/src/test/java/org/apache/nifi/distributed/cache/server/map/TestDistributedMapServerAndClient.java:
##########
@@ -312,6 +354,26 @@ private DistributedMapCacheClientService createClient(final int port) throws Ini
         return client;
     }
 
+    private Thread startServerSocket(ServerSocketChannel serverSocketChannel) {
+        final Runnable runnable = new Runnable() {
+            @Override
+            public void run() {
+                while (true) {
+                    try {
+                        serverSocketChannel.accept();
+                    } catch (final IOException e) {
+                        return;
+                    }
+                }
+            }
+        };
+        final Thread thread = new Thread(runnable);
+        thread.setDaemon(true);
+        thread.setName("Test Server Socket");
+        thread.start();
+        return thread;
+    }

Review Comment:
   Thabk you so much @exceptionfactory for looking at this and for your feedback.  @jlshoem graciously granted me permissions to his repository and I made a commit in response your points.
   
   I having difficulty with the ci/cd workflow being kicked off, though.
   
   Something about needing approval from a maintainer  https://github.com/apache/nifi/actions/runs/3206783125
   Is this something you might be able to assist with?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org