[GitHub] [cordova-plugin-statusbar] breautek commented on a diff in pull request #247: refactor(android): extract action & value strings as static constants

[GitBox <gi...@apache.org>]

breautek commented on code in PR #247:
URL: https://github.com/apache/cordova-plugin-statusbar/pull/247#discussion_r985270094


##########
src/android/StatusBar.java:
##########
@@ -36,12 +36,24 @@
 import org.apache.cordova.CordovaWebView;
 import org.apache.cordova.LOG;
 import org.apache.cordova.PluginResult;
+import org.jetbrains.annotations.NonNls;

Review Comment:
   is this import really safe? Is it included in the Android SDK?



##########
src/android/StatusBar.java:
##########
@@ -36,12 +36,24 @@
 import org.apache.cordova.CordovaWebView;
 import org.apache.cordova.LOG;
 import org.apache.cordova.PluginResult;
+import org.jetbrains.annotations.NonNls;

Review Comment:
   On a basic gradle project, this import fails, but in a cordova-android project this import works as is.
   
   But `org.jetbriains` is not existent in the Android documentation, and I don't see how we are importing `'org.jetbrains:annotations:23.0.0'` (via [jetbrains documentation](https://github.com/JetBrains/java-annotations#using-the-annotations)) so this import might be relying on a third-party dependency implementation detail.
   
   I wonder if we should be explicitly declaring this dependency in gradle.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org