You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "villebro (via GitHub)" <gi...@apache.org> on 2025/06/08 23:24:40 UTC
[PR] chore: move backend under superset-backend [superset]
villebro opened a new pull request, #33722:
URL: https://github.com/apache/superset/pull/33722
### SUMMARY
WIP
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: move backend under superset-backend [superset]
Posted by "korbit-ai[bot] (via GitHub)" <gi...@apache.org>.
korbit-ai[bot] commented on code in PR #33722:
URL: https://github.com/apache/superset/pull/33722#discussion_r2134854335
##########
.github/workflows/bashlib.sh:
##########
@@ -109,7 +109,7 @@ testdata() {
say "::group::Load test data"
# must specify PYTHONPATH to make `tests.superset_test_config` importable
export PYTHONPATH="$GITHUB_WORKSPACE"
- pip install -e .
+ pip install -e superset-backend/.
Review Comment:
### Missing directory existence check <sub></sub>
<details>
<summary>Tell me more</summary>
###### What is the issue?
The path to the backend installation has been changed but no verification is done to ensure the directory exists before attempting installation.
###### Why this matters
If the 'superset-backend' directory is missing or not properly relocated, the pip install command will fail, breaking the test data loading process and subsequent operations.
###### Suggested change ∙ *Feature Preview*
Add a directory check before pip installation:
```bash
if [ ! -d "superset-backend" ]; then
echo "Error: superset-backend directory not found"
exit 1
fi
pip install -e superset-backend/.
```
###### Provide feedback to improve future suggestions
[](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/40328053-b97f-4389-afa9-b5163181fabd/upvote) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/40328053-b97f-4389-afa9-b5163181fabd?what_not_true=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/40328053-b97f-4389-afa9-b5163181fabd?what_out_of_scope=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/40328053-b97f-4389-afa9-b5163181fabd?what_not_in_standard=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/40328053-b97f-4389-afa9-b5163181fabd)
</details>
<sub>
💬 Looking for more details? Reply to this comment to chat with Korbit.
</sub>
<!--- korbi internal id:566cefb1-6ffa-44a8-a468-3109d3a071bc -->
[](566cefb1-6ffa-44a8-a468-3109d3a071bc)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: move backend under superset-backend [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on PR #33722:
URL: https://github.com/apache/superset/pull/33722#issuecomment-2954489242
Nice to see this! Wondering if you should take one step further and move to `superset-backend/app/`, assuming will be a need for things like `superset-backend/extension-sdk/`, `superset-backend/data-access-layer/`, all depending on something like `superset-backend/core/` (?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: move backend under superset-backend [superset]
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro closed pull request #33722: chore: move backend under superset-backend
URL: https://github.com/apache/superset/pull/33722
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org