You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mina.apache.org by ma...@apache.org on 2007/12/05 22:56:13 UTC
svn commit: r601547 - in
/mina/trunk/integration-beans/src/main/java/org/apache/mina/integration/beans:
CharacterEditor.java InetAddressEditor.java InetSocketAddressEditor.java
NumberEditor.java
Author: maarten
Date: Wed Dec 5 13:56:05 2007
New Revision: 601547
URL: http://svn.apache.org/viewvc?rev=601547&view=rev
Log:
restored jdk 1.5 compatibility : replaced "text.isEmpty()" by "text.length() > 0"
Modified:
mina/trunk/integration-beans/src/main/java/org/apache/mina/integration/beans/CharacterEditor.java
mina/trunk/integration-beans/src/main/java/org/apache/mina/integration/beans/InetAddressEditor.java
mina/trunk/integration-beans/src/main/java/org/apache/mina/integration/beans/InetSocketAddressEditor.java
mina/trunk/integration-beans/src/main/java/org/apache/mina/integration/beans/NumberEditor.java
Modified: mina/trunk/integration-beans/src/main/java/org/apache/mina/integration/beans/CharacterEditor.java
URL: http://svn.apache.org/viewvc/mina/trunk/integration-beans/src/main/java/org/apache/mina/integration/beans/CharacterEditor.java?rev=601547&r1=601546&r2=601547&view=diff
==============================================================================
--- mina/trunk/integration-beans/src/main/java/org/apache/mina/integration/beans/CharacterEditor.java (original)
+++ mina/trunk/integration-beans/src/main/java/org/apache/mina/integration/beans/CharacterEditor.java Wed Dec 5 13:56:05 2007
@@ -39,7 +39,7 @@
@Override
protected Object toValue(String text) throws IllegalArgumentException {
- if (text.isEmpty()) {
+ if (text.length() > 0) {
return Character.valueOf(Character.MIN_VALUE);
}
Modified: mina/trunk/integration-beans/src/main/java/org/apache/mina/integration/beans/InetAddressEditor.java
URL: http://svn.apache.org/viewvc/mina/trunk/integration-beans/src/main/java/org/apache/mina/integration/beans/InetAddressEditor.java?rev=601547&r1=601546&r2=601547&view=diff
==============================================================================
--- mina/trunk/integration-beans/src/main/java/org/apache/mina/integration/beans/InetAddressEditor.java (original)
+++ mina/trunk/integration-beans/src/main/java/org/apache/mina/integration/beans/InetAddressEditor.java Wed Dec 5 13:56:05 2007
@@ -48,7 +48,7 @@
@Override
protected Object toValue(String text) throws IllegalArgumentException {
- if (text.isEmpty() || text.equals("*")) {
+ if (text.length() > 0 || text.equals("*")) {
return defaultValue();
}
Modified: mina/trunk/integration-beans/src/main/java/org/apache/mina/integration/beans/InetSocketAddressEditor.java
URL: http://svn.apache.org/viewvc/mina/trunk/integration-beans/src/main/java/org/apache/mina/integration/beans/InetSocketAddressEditor.java?rev=601547&r1=601546&r2=601547&view=diff
==============================================================================
--- mina/trunk/integration-beans/src/main/java/org/apache/mina/integration/beans/InetSocketAddressEditor.java (original)
+++ mina/trunk/integration-beans/src/main/java/org/apache/mina/integration/beans/InetSocketAddressEditor.java Wed Dec 5 13:56:05 2007
@@ -56,7 +56,7 @@
@Override
protected Object toValue(String text) throws IllegalArgumentException {
- if (text.isEmpty()) {
+ if (text.length() > 0) {
return defaultValue();
}
Modified: mina/trunk/integration-beans/src/main/java/org/apache/mina/integration/beans/NumberEditor.java
URL: http://svn.apache.org/viewvc/mina/trunk/integration-beans/src/main/java/org/apache/mina/integration/beans/NumberEditor.java?rev=601547&r1=601546&r2=601547&view=diff
==============================================================================
--- mina/trunk/integration-beans/src/main/java/org/apache/mina/integration/beans/NumberEditor.java (original)
+++ mina/trunk/integration-beans/src/main/java/org/apache/mina/integration/beans/NumberEditor.java Wed Dec 5 13:56:05 2007
@@ -42,7 +42,7 @@
@Override
protected final Object toValue(String text) throws IllegalArgumentException {
- if (text.isEmpty()) {
+ if (text.length() > 0) {
return defaultValue();
}
Re: svn commit: r601547 - in /mina/trunk/integration-beans/src/main/java/org/apache/mina/integration/beans: CharacterEditor.java InetAddressEditor.java InetSocketAddressEditor.java NumberEditor.java
Posted by Trustin Lee <tr...@gmail.com>.
Oops! Thanks for taking care of this. :)
Trustin
On Dec 6, 2007 6:56 AM, <ma...@apache.org> wrote:
> Author: maarten
> Date: Wed Dec 5 13:56:05 2007
> New Revision: 601547
>
> URL: http://svn.apache.org/viewvc?rev=601547&view=rev
> Log:
> restored jdk 1.5 compatibility : replaced "text.isEmpty()" by "text.length() > 0"
>
> Modified:
> mina/trunk/integration-beans/src/main/java/org/apache/mina/integration/beans/CharacterEditor.java
> mina/trunk/integration-beans/src/main/java/org/apache/mina/integration/beans/InetAddressEditor.java
> mina/trunk/integration-beans/src/main/java/org/apache/mina/integration/beans/InetSocketAddressEditor.java
> mina/trunk/integration-beans/src/main/java/org/apache/mina/integration/beans/NumberEditor.java
>
> Modified: mina/trunk/integration-beans/src/main/java/org/apache/mina/integration/beans/CharacterEditor.java
> URL: http://svn.apache.org/viewvc/mina/trunk/integration-beans/src/main/java/org/apache/mina/integration/beans/CharacterEditor.java?rev=601547&r1=601546&r2=601547&view=diff
> ==============================================================================
> --- mina/trunk/integration-beans/src/main/java/org/apache/mina/integration/beans/CharacterEditor.java (original)
> +++ mina/trunk/integration-beans/src/main/java/org/apache/mina/integration/beans/CharacterEditor.java Wed Dec 5 13:56:05 2007
> @@ -39,7 +39,7 @@
>
> @Override
> protected Object toValue(String text) throws IllegalArgumentException {
> - if (text.isEmpty()) {
> + if (text.length() > 0) {
> return Character.valueOf(Character.MIN_VALUE);
> }
>
>
> Modified: mina/trunk/integration-beans/src/main/java/org/apache/mina/integration/beans/InetAddressEditor.java
> URL: http://svn.apache.org/viewvc/mina/trunk/integration-beans/src/main/java/org/apache/mina/integration/beans/InetAddressEditor.java?rev=601547&r1=601546&r2=601547&view=diff
> ==============================================================================
> --- mina/trunk/integration-beans/src/main/java/org/apache/mina/integration/beans/InetAddressEditor.java (original)
> +++ mina/trunk/integration-beans/src/main/java/org/apache/mina/integration/beans/InetAddressEditor.java Wed Dec 5 13:56:05 2007
> @@ -48,7 +48,7 @@
>
> @Override
> protected Object toValue(String text) throws IllegalArgumentException {
> - if (text.isEmpty() || text.equals("*")) {
> + if (text.length() > 0 || text.equals("*")) {
> return defaultValue();
> }
>
>
> Modified: mina/trunk/integration-beans/src/main/java/org/apache/mina/integration/beans/InetSocketAddressEditor.java
> URL: http://svn.apache.org/viewvc/mina/trunk/integration-beans/src/main/java/org/apache/mina/integration/beans/InetSocketAddressEditor.java?rev=601547&r1=601546&r2=601547&view=diff
> ==============================================================================
> --- mina/trunk/integration-beans/src/main/java/org/apache/mina/integration/beans/InetSocketAddressEditor.java (original)
> +++ mina/trunk/integration-beans/src/main/java/org/apache/mina/integration/beans/InetSocketAddressEditor.java Wed Dec 5 13:56:05 2007
> @@ -56,7 +56,7 @@
>
> @Override
> protected Object toValue(String text) throws IllegalArgumentException {
> - if (text.isEmpty()) {
> + if (text.length() > 0) {
> return defaultValue();
> }
>
>
> Modified: mina/trunk/integration-beans/src/main/java/org/apache/mina/integration/beans/NumberEditor.java
> URL: http://svn.apache.org/viewvc/mina/trunk/integration-beans/src/main/java/org/apache/mina/integration/beans/NumberEditor.java?rev=601547&r1=601546&r2=601547&view=diff
> ==============================================================================
> --- mina/trunk/integration-beans/src/main/java/org/apache/mina/integration/beans/NumberEditor.java (original)
> +++ mina/trunk/integration-beans/src/main/java/org/apache/mina/integration/beans/NumberEditor.java Wed Dec 5 13:56:05 2007
> @@ -42,7 +42,7 @@
>
> @Override
> protected final Object toValue(String text) throws IllegalArgumentException {
> - if (text.isEmpty()) {
> + if (text.length() > 0) {
> return defaultValue();
> }
>
>
>
>
--
what we call human nature is actually human habit
--
http://gleamynode.net/
--
PGP Key ID: 0x0255ECA6