You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/12/31 16:41:00 UTC

[jira] [Commented] (TOMEE-2437) TestCLIFromJaxRSTest fails on Windows due to incorrect assumtion for "new line separator"

    [ https://issues.apache.org/jira/browse/TOMEE-2437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16731372#comment-16731372 ] 

ASF GitHub Bot commented on TOMEE-2437:
---------------------------------------

GitHub user doychin opened a pull request:

    https://github.com/apache/tomee/pull/338

    Use correct line separator when checking call result.

    Fix for issue 
    https://issues.apache.org/jira/browse/TOMEE-2437

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/doychin/tomee line-separator-windows

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tomee/pull/338.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #338
    
----
commit 3f17abc3dd0f402f378ae29fab073bcb32b3f84b
Author: Doychin Bondzhev <do...@...>
Date:   2018-12-31T16:01:38Z

    Use correct line separator when checking call result.

----


> TestCLIFromJaxRSTest fails on Windows due to incorrect assumtion for "new line separator"
> -----------------------------------------------------------------------------------------
>
>                 Key: TOMEE-2437
>                 URL: https://issues.apache.org/jira/browse/TOMEE-2437
>             Project: TomEE
>          Issue Type: Bug
>          Components: TomEE Core Server
>            Reporter: Doychin
>            Priority: Minor
>              Labels: pull-request-available
>
> in the test
> TestCLIFromJaxRSTest code assumes line ends with "\n" but when run on Windows it ends with "'\r\n".



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)