You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/07/02 07:06:33 UTC
Re: Review Request: Add APIs for event notification in cgroups.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5395/#review8780
-----------------------------------------------------------
src/tests/cgroups_tests.cpp
<https://reviews.apache.org/r/5395/#comment18582>
Seeing this used again makes me think that there should really be a second test fixture, one where the body of 'prepare' is inside SetUp and one where it doesn't exist. Thoughts?
src/tests/cgroups_tests.cpp
<https://reviews.apache.org/r/5395/#comment18580>
Put the value expected first (here and others below).
src/tests/cgroups_tests.cpp
<https://reviews.apache.org/r/5395/#comment18579>
Kill newline.
src/tests/cgroups_tests.cpp
<https://reviews.apache.org/r/5395/#comment18584>
Making 'size' be in terms of 'limit' is more robust.
src/tests/cgroups_tests.cpp
<https://reviews.apache.org/r/5395/#comment18583>
Space after '(char*)' please.
- Benjamin Hindman
On June 29, 2012, 12:47 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5395/
> -----------------------------------------------------------
>
> (Updated June 29, 2012, 12:47 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> In cgroups, sometimes you want to be notified if some certain events happen. For example, users may want to be notified when an out-of-memory event happens.
>
> This patch introduce a function called "listenEvent" which returns an instance of Future so that you can check the status of this future to see whether any event happens.
>
> This interface is general to all the events in cgroups.
>
>
> Diffs
> -----
>
> src/linux/cgroups.hpp PRE-CREATION
> src/linux/cgroups.cpp PRE-CREATION
> src/tests/cgroups_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/5395/diff/
>
>
> Testing
> -------
>
> On Linux machines, make check.
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request: Add APIs for event notification in cgroups.
Posted by Jie Yu <yu...@gmail.com>.
> On July 2, 2012, 5:06 a.m., Benjamin Hindman wrote:
> > src/tests/cgroups_tests.cpp, line 401
> > <https://reviews.apache.org/r/5395/diff/10/?file=117203#file117203line401>
> >
> > Seeing this used again makes me think that there should really be a second test fixture, one where the body of 'prepare' is inside SetUp and one where it doesn't exist. Thoughts?
Done. Refactored.
> On July 2, 2012, 5:06 a.m., Benjamin Hindman wrote:
> > src/tests/cgroups_tests.cpp, line 426
> > <https://reviews.apache.org/r/5395/diff/10/?file=117203#file117203line426>
> >
> > Put the value expected first (here and others below).
Done.
> On July 2, 2012, 5:06 a.m., Benjamin Hindman wrote:
> > src/tests/cgroups_tests.cpp, line 440
> > <https://reviews.apache.org/r/5395/diff/10/?file=117203#file117203line440>
> >
> > Kill newline.
Done.
> On July 2, 2012, 5:06 a.m., Benjamin Hindman wrote:
> > src/tests/cgroups_tests.cpp, line 450
> > <https://reviews.apache.org/r/5395/diff/10/?file=117203#file117203line450>
> >
> > Making 'size' be in terms of 'limit' is more robust.
Done.
> On July 2, 2012, 5:06 a.m., Benjamin Hindman wrote:
> > src/tests/cgroups_tests.cpp, line 451
> > <https://reviews.apache.org/r/5395/diff/10/?file=117203#file117203line451>
> >
> > Space after '(char*)' please.
Done.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5395/#review8780
-----------------------------------------------------------
On June 29, 2012, 12:47 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5395/
> -----------------------------------------------------------
>
> (Updated June 29, 2012, 12:47 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> In cgroups, sometimes you want to be notified if some certain events happen. For example, users may want to be notified when an out-of-memory event happens.
>
> This patch introduce a function called "listenEvent" which returns an instance of Future so that you can check the status of this future to see whether any event happens.
>
> This interface is general to all the events in cgroups.
>
>
> Diffs
> -----
>
> src/linux/cgroups.hpp PRE-CREATION
> src/linux/cgroups.cpp PRE-CREATION
> src/tests/cgroups_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/5395/diff/
>
>
> Testing
> -------
>
> On Linux machines, make check.
>
>
> Thanks,
>
> Jie Yu
>
>