[GitHub] [helix] alirezazamani commented on a change in pull request #432: TASK: Fix incorrect counting of numAttempts for tasks

[GitBox <gi...@apache.org>]

alirezazamani commented on a change in pull request #432: TASK: Fix incorrect counting of numAttempts for tasks
URL: https://github.com/apache/helix/pull/432#discussion_r317723993
 
 

 ##########
 File path: helix-core/src/test/java/org/apache/helix/integration/task/TestTaskNumAttempts.java
 ##########
 @@ -0,0 +1,79 @@
+package org.apache.helix.integration.task;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import com.google.common.collect.ImmutableMap;
+import org.apache.helix.TestHelper;
+import org.apache.helix.task.JobConfig;
+import org.apache.helix.task.JobContext;
+import org.apache.helix.task.TaskState;
+import org.apache.helix.task.TaskUtil;
+import org.apache.helix.task.Workflow;
+import org.testng.Assert;
+import org.testng.annotations.BeforeClass;
+import org.testng.annotations.Test;
+
+/**
+ * TestTaskNumAttempts tests that number of attempts for tasks are incremented correctly respecting
+ * the retry delay.
+ * NOTE: This test relies heavily upon timing.
+ */
+public class TestTaskNumAttempts extends TaskTestBase {
+  @BeforeClass
+  public void beforeClass() throws Exception {
+    _numPartitions = 1;
+    super.beforeClass();
+  }
+
+  @Test
+  public void testTaskNumAttemptsWithDelay() throws Exception {
+    int maxAttempts = Integer.MAX_VALUE; // Allow the count to increase infinitely
+    // Use a delay that's long enough for multiple rounds of pipeline
+    long retryDelay = 4000L;
+
+    String workflowName = TestHelper.getTestMethodName();
+    JobConfig.Builder jobBuilder = JobConfig.Builder.fromMap(WorkflowGenerator.DEFAULT_JOB_CONFIG);
+    jobBuilder.setJobCommandConfigMap(WorkflowGenerator.DEFAULT_COMMAND_CONFIG)
+        .setMaxAttemptsPerTask(maxAttempts).setCommand(MockTask.TASK_COMMAND)
+        .setWorkflow(workflowName).setFailureThreshold(Integer.MAX_VALUE)
+        .setTaskRetryDelay(retryDelay).setJobCommandConfigMap(
+            ImmutableMap.of(MockTask.FAILURE_COUNT_BEFORE_SUCCESS, String.valueOf(maxAttempts)));
+    Workflow flow =
+        WorkflowGenerator.generateSingleJobWorkflowBuilder(workflowName, jobBuilder).build();
+    _driver.start(flow);
+
+    // Wait until the job completes.
+    _driver.pollForWorkflowState(workflowName, TaskState.IN_PROGRESS);
+
 
 Review comment:
   The comment says complete but here we poll for IN_PROGRESS condition.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org