[jira] [Updated] (PIG-3615) Update the way that JsonLoader/JsonStorage deal with BigDecimal

["Eyal Allweil (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/PIG-3615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eyal Allweil updated PIG-3615:
------------------------------
    Attachment: PIG-3615.patch

How about if we only do half the change? We change the way JsonLoader works to accept both formats, but we don't change JsonStorage, so it continues to store in the old, backward-compatible way.

I've changed the original patch to do this, plus added a unit test that checks that both formats can be read and produce identical results.

> Update the way that JsonLoader/JsonStorage deal with BigDecimal
> ---------------------------------------------------------------
>
>                 Key: PIG-3615
>                 URL: https://issues.apache.org/jira/browse/PIG-3615
>             Project: Pig
>          Issue Type: Improvement
>    Affects Versions: 0.12.0
>            Reporter: Erik Selin
>            Assignee: Erik Selin
>            Priority: Minor
>         Attachments: PIG-3615.patch, bugPig-3615.patch
>
>
> It's a common (and good) convention to quote fixed point numbers when storing them as json. The reason being that majority of json libraries will implicitly load any number value as a floating point number and if you care about data integrity this will make you very sad.
> This update makes JsonLoader able to load BigDecimal values from quoted values (the old jackson library that we're using doesn't support this through the current approach) as well as making JsonStorage store BigDecimal values as quoted strings.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)