[jira] [Commented] (OAK-800) EffectiveType#getTypeNames may throw NPE

["Tommaso Teofili (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13644554#comment-13644554 ] 

Tommaso Teofili commented on OAK-800:
-------------------------------------

the trivial patch would be 
{code}
    PropertyState superTypes = type.getProperty("oak:supertypes");
    if (superTypes != null) {
        Iterables.addAll(names, superTypes.getValue(NAMES));
    }
{code}
                
> EffectiveType#getTypeNames may throw NPE
> ----------------------------------------
>
>                 Key: OAK-800
>                 URL: https://issues.apache.org/jira/browse/OAK-800
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core
>            Reporter: Tommaso Teofili
>            Priority: Minor
>
> _EffectiveType#getTypeNames_ may throw NPE if any of the types doesn't have _oak:supertypes_ property defined.
> At line 200: 
> {code}
>     Iterables.addAll(names, type.getProperty("oak:supertypes").getValue(NAMES));
> {code}
> where _type.getProperty("oak:supertypes")_ may be _null_ (as per _@CheckForNull_ annotation on _NodeState#getProperty(String name)_).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira