You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/02/02 19:21:33 UTC

[GitHub] [pulsar-client-go] zzzming opened a new pull request #459: Improve error log for frame size too big and maxMessageSize

zzzming opened a new pull request #459:
URL: https://github.com/apache/pulsar-client-go/pull/459


   
   ### Motivation
   This PR is to improve error log for `frame size too big` on the consumer. We have a customer with a number of frame size too big error and I would like to trace what the exact maxMessageSize is set to that is not default. Debug log was not able to be enabled on the production system.
   
   
   ### Modifications
   
   Log improvement mostly
   
   ### Verifying this change
   
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API: no
     - The schema: no
     - The default values of configurations: no
     - The wire protocol: no
   
   ### Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? no
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] merlimat commented on a change in pull request #459: Improve error log for frame size too big and maxMessageSize

Posted by GitBox <gi...@apache.org>.
merlimat commented on a change in pull request #459:
URL: https://github.com/apache/pulsar-client-go/pull/459#discussion_r571479063



##########
File path: pulsar/producer_partition.go
##########
@@ -348,7 +348,7 @@ func (p *partitionProducer) internalSend(request *sendRequest) {
 		p.log.WithError(errMessageTooLarge).
 			WithField("size", len(payload)).
 			WithField("properties", msg.Properties).
-			Error()
+			Errorf("MaxMessageSize %d", int(p.cnx.GetMaxMessageSize()))

Review comment:
       Should we keep this in a structured form instead? 
   ```suggestion
   
   			WithField("max-message-size", int(p.cnx.GetMaxMessageSize())).
   			Error()
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] wolfstudy merged pull request #459: Improve error log for frame size too big and maxMessageSize

Posted by GitBox <gi...@apache.org>.
wolfstudy merged pull request #459:
URL: https://github.com/apache/pulsar-client-go/pull/459


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org