You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/11/30 13:40:24 UTC
[GitHub] [servicecomb-java-chassis] liubao68 opened a new pull request #2093: add an example and test case for same class/interface name
liubao68 opened a new pull request #2093:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2093
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] codecov-io commented on pull request #2093: add an example and test case for same class/interface name
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #2093:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2093#issuecomment-735809213
# [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2093?src=pr&el=h1) Report
> Merging [#2093](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2093?src=pr&el=desc) (f3ad9d1) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/cbd4c577a01221e1421f8e7c6a2ba04aa3c4e6bd?el=desc) (cbd4c57) will **decrease** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2093?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2093 +/- ##
============================================
- Coverage 81.54% 81.53% -0.01%
- Complexity 1327 1329 +2
============================================
Files 1442 1443 +1
Lines 39501 39507 +6
Branches 3353 3353
============================================
+ Hits 32210 32214 +4
- Misses 5825 5830 +5
+ Partials 1466 1463 -3
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2093?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../servicecomb/demo/pojo/client/TestSameService.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2093/diff?src=pr&el=tree#diff-ZGVtby9kZW1vLXBvam8vcG9qby1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2RlbW8vcG9qby9jbGllbnQvVGVzdFNhbWVTZXJ2aWNlLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...mb/serviceregistry/client/http/RestClientUtil.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2093/diff?src=pr&el=tree#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NsaWVudC9odHRwL1Jlc3RDbGllbnRVdGlsLmphdmE=) | `75.70% <0.00%> (-1.87%)` | `0.00% <0.00%> (ø%)` | |
| [...egistry/client/http/ServiceRegistryClientImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2093/diff?src=pr&el=tree#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NsaWVudC9odHRwL1NlcnZpY2VSZWdpc3RyeUNsaWVudEltcGwuamF2YQ==) | `69.32% <0.00%> (-0.78%)` | `0.00% <0.00%> (ø%)` | |
| [...ecomb/provider/pojo/PojoConsumerMetaRefresher.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2093/diff?src=pr&el=tree#diff-cHJvdmlkZXJzL3Byb3ZpZGVyLXBvam8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL3Byb3ZpZGVyL3Bvam8vUG9qb0NvbnN1bWVyTWV0YVJlZnJlc2hlci5qYXZh) | `78.04% <0.00%> (+2.43%)` | `0.00% <0.00%> (ø%)` | |
| [...omb/codec/protobuf/definition/ProtobufManager.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2093/diff?src=pr&el=tree#diff-Y29tbW9uL2NvbW1vbi1wcm90b2J1Zi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29kZWMvcHJvdG9idWYvZGVmaW5pdGlvbi9Qcm90b2J1Zk1hbmFnZXIuamF2YQ==) | `73.17% <0.00%> (+2.43%)` | `0.00% <0.00%> (ø%)` | |
| [.../servicecomb/registry/discovery/DiscoveryTree.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2093/diff?src=pr&el=tree#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1yZWdpc3RyeS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvcmVnaXN0cnkvZGlzY292ZXJ5L0Rpc2NvdmVyeVRyZWUuamF2YQ==) | `100.00% <0.00%> (+3.50%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2093?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2093?src=pr&el=footer). Last update [cbd4c57...f3ad9d1](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2093?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #2093: add an example and test case for same class/interface name
Posted by GitBox <gi...@apache.org>.
liubao68 merged pull request #2093:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2093
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] codecov-io edited a comment on pull request #2093: add an example and test case for same class/interface name
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #2093:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2093#issuecomment-735809213
# [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2093?src=pr&el=h1) Report
> Merging [#2093](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2093?src=pr&el=desc) (e793e57) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/cbd4c577a01221e1421f8e7c6a2ba04aa3c4e6bd?el=desc) (cbd4c57) will **increase** coverage by `0.02%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2093?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2093 +/- ##
============================================
+ Coverage 81.54% 81.56% +0.02%
- Complexity 1327 1329 +2
============================================
Files 1442 1443 +1
Lines 39501 39507 +6
Branches 3353 3353
============================================
+ Hits 32210 32225 +15
+ Misses 5825 5817 -8
+ Partials 1466 1465 -1
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2093?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../servicecomb/demo/pojo/client/TestSameService.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2093/diff?src=pr&el=tree#diff-ZGVtby9kZW1vLXBvam8vcG9qby1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2RlbW8vcG9qby9jbGllbnQvVGVzdFNhbWVTZXJ2aWNlLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | |
| [...mb/serviceregistry/client/http/RestClientUtil.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2093/diff?src=pr&el=tree#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NsaWVudC9odHRwL1Jlc3RDbGllbnRVdGlsLmphdmE=) | `75.70% <0.00%> (-1.87%)` | `0.00% <0.00%> (ø%)` | |
| [...egistry/client/http/ServiceRegistryClientImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2093/diff?src=pr&el=tree#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NsaWVudC9odHRwL1NlcnZpY2VSZWdpc3RyeUNsaWVudEltcGwuamF2YQ==) | `70.87% <0.00%> (+0.77%)` | `0.00% <0.00%> (ø%)` | |
| [...mb/serviceregistry/task/MicroserviceWatchTask.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2093/diff?src=pr&el=tree#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L3Rhc2svTWljcm9zZXJ2aWNlV2F0Y2hUYXNrLmphdmE=) | `70.00% <0.00%> (+1.66%)` | `0.00% <0.00%> (ø%)` | |
| [...ervicecomb/foundation/vertx/tcp/TcpConnection.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2093/diff?src=pr&el=tree#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi12ZXJ0eC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvZm91bmRhdGlvbi92ZXJ0eC90Y3AvVGNwQ29ubmVjdGlvbi5qYXZh) | `86.48% <0.00%> (+2.70%)` | `0.00% <0.00%> (ø%)` | |
| [...rviceregistry/client/http/WebsocketClientUtil.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2093/diff?src=pr&el=tree#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NsaWVudC9odHRwL1dlYnNvY2tldENsaWVudFV0aWwuamF2YQ==) | `77.19% <0.00%> (+3.50%)` | `0.00% <0.00%> (ø%)` | |
| [...cecomb/serviceregistry/task/ServiceCenterTask.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2093/diff?src=pr&el=tree#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L3Rhc2svU2VydmljZUNlbnRlclRhc2suamF2YQ==) | `89.79% <0.00%> (+6.12%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2093?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2093?src=pr&el=footer). Last update [cbd4c57...e793e57](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2093?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org