You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by mg...@apache.org on 2013/02/07 13:18:28 UTC

[1/2] git commit: Javadoc improvements - move the Javadoc from a field to its getter method. Otherwise it doesn't appear in the generated html.

Javadoc improvements - move the Javadoc from a field to its getter method. Otherwise it doesn't appear in the generated html.


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/08015cdc
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/08015cdc
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/08015cdc

Branch: refs/heads/master
Commit: 08015cdc143342052793e81bdc30e1da799095f6
Parents: e9df9fb
Author: Martin Tzvetanov Grigorov <mg...@apache.org>
Authored: Thu Feb 7 12:58:22 2013 +0100
Committer: Martin Tzvetanov Grigorov <mg...@apache.org>
Committed: Thu Feb 7 12:58:22 2013 +0100

----------------------------------------------------------------------
 .../src/main/java/org/apache/wicket/Page.java      |    9 +--------
 .../wicket/ajax/attributes/ThrottlingSettings.java |   12 ++++--------
 2 files changed, 5 insertions(+), 16 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/wicket/blob/08015cdc/wicket-core/src/main/java/org/apache/wicket/Page.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/Page.java b/wicket-core/src/main/java/org/apache/wicket/Page.java
index 6fd6742..1467798 100644
--- a/wicket-core/src/main/java/org/apache/wicket/Page.java
+++ b/wicket-core/src/main/java/org/apache/wicket/Page.java
@@ -120,11 +120,7 @@ public abstract class Page extends MarkupContainer implements IRedirectListener,
 	private final PageParameters pageParameters;
 
 	/**
-	 * The purpose of render count is to detect stale listener interface links. For example: there
-	 * is a page A rendered in tab 1. Then page A is opened also in tab 2. During render page state
-	 * changes (i.e. some repeater gets rebuilt). This makes all links on tab 1 stale - because they
-	 * no longer match the actual page state. This is done by incrementing render count. When link
-	 * is clicked Wicket checks if it's render count matches the render count value of page
+	 * @see IRequestablePage#getRenderCount()
 	 */
 	private int renderCount = 0;
 
@@ -972,9 +968,6 @@ public abstract class Page extends MarkupContainer implements IRedirectListener,
 		return numericId;
 	}
 
-	/**
-	 * @see org.apache.wicket.request.component.IRequestablePage#getRenderCount()
-	 */
 	@Override
 	public int getRenderCount()
 	{

http://git-wip-us.apache.org/repos/asf/wicket/blob/08015cdc/wicket-core/src/main/java/org/apache/wicket/ajax/attributes/ThrottlingSettings.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/ajax/attributes/ThrottlingSettings.java b/wicket-core/src/main/java/org/apache/wicket/ajax/attributes/ThrottlingSettings.java
index 0893d86..a737cfe 100644
--- a/wicket-core/src/main/java/org/apache/wicket/ajax/attributes/ThrottlingSettings.java
+++ b/wicket-core/src/main/java/org/apache/wicket/ajax/attributes/ThrottlingSettings.java
@@ -30,13 +30,6 @@ public class ThrottlingSettings implements IClusterable
 
 	private final Duration delay;
 	private final String id;
-
-	/**
-	 * If it is set to true, then the timer is reset each time the throttle function
-	 * gets called. Use this behaviour if you want something to happen at X milliseconds
-	 * after the *last* call to throttle. If the parameter is not set, or set to false,
-	 * then the timer is not reset.
-	 */
 	private final boolean postponeTimerOnUpdate;
 
 	/**
@@ -81,7 +74,10 @@ public class ThrottlingSettings implements IClusterable
 	}
 
 	/**
-	 * @return
+	 * If it is set to true, then the timer is reset each time the throttle function
+	 * gets called. Use this behaviour if you want something to happen at X milliseconds
+	 * after the *last* call to throttle. If the parameter is not set, or set to false,
+	 * then the timer is not reset.
 	 */
 	public boolean getPostponeTimerOnUpdate() {
 		return postponeTimerOnUpdate;