You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2020/10/18 10:46:42 UTC

[GitHub] [systemds] mboehm7 commented on pull request #1079: fix bug in CostEstimator.java

mboehm7 commented on pull request #1079:
URL: https://github.com/apache/systemds/pull/1079#issuecomment-711149500


   LGTM - thanks @XorSum for catching this issue and the related fix. I'll merge this in, as we indeed removed unnecessary entries in this instruction (in the past this instruction included both row and column blocksize). However, over the last years we mostly switched away from runtime plan costing to analytical cost models at hop level. This is the reason why this code path was also not tested. If you're doing a project were you need the costs, I would recommend to use something like our cost-based operator fusion optimizer: 
   https://github.com/apache/systemds/blob/master/src/main/java/org/apache/sysds/hops/codegen/opt/PlanSelectionFuseCostBasedV2.java#L1014 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org