[jira] [Commented] (HIVE-4075) TypeInfoFactory is not thread safe and is access by multiple threads

["Brock Noland (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13587301#comment-13587301 ] 

Brock Noland commented on HIVE-4075:
------------------------------------

Either making the methods synchronized or using a ConcurrentHashMap should resolve the infinite loop. Since the TypeInfo objects are read only and it appears the keys/values will never be null in this class, I think a ConcurrentHashMap will work.
                
> TypeInfoFactory is not thread safe and is access by multiple threads
> --------------------------------------------------------------------
>
>                 Key: HIVE-4075
>                 URL: https://issues.apache.org/jira/browse/HIVE-4075
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 0.10.0
>            Reporter: Brock Noland
>
> TypeInfoFactory is not thread safe and when accessed by multiple threads calls to any of the methods can modify hashmaps concurrently resulting in infinite loops.
> {noformat}
> "pool-1-thread-240" prio=10 tid=0x00002aabd8bf7000 nid=0x5f4a runnable [0x0000000044626000] 
> java.lang.Thread.State: RUNNABLE 
> at java.util.HashMap.get(HashMap.java:303) 
> at org.apache.hadoop.hive.serde2.typeinfo.TypeInfoFactory.getStructTypeInfo(TypeInfoFactory.java:94) 
> at org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe.initSerdeParams(LazySimpleSerDe.java:237) 
> at org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe.initialize(LazySimpleSerDe.java:182) 
> at org.apache.hadoop.hive.metastore.MetaStoreUtils.getDeserializer(MetaStoreUtils.java:203) 
> at org.apache.hadoop.hive.ql.metadata.Table.getDeserializerFromMetaStore(Table.java:260) 
> at org.apache.hadoop.hive.ql.metadata.Table.checkValidity(Table.java:167) 
> at org.apache.hadoop.hive.ql.metadata.Hive.getTable(Hive.java:930) 
> at org.apache.hadoop.hive.ql.parse.DDLSemanticAnalyzer.analyzeDropTable(DDLSemanticAnalyzer.java:706) 
> at org.apache.hadoop.hive.ql.parse.DDLSemanticAnalyzer.analyzeInternal(DDLSemanticAnalyzer.java:212) 
> at org.apache.hadoop.hive.ql.parse.BaseSemanticAnalyzer.analyze(BaseSemanticAnalyzer.java:246) 
> at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:432) 
> at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:337) 
> at org.apache.hadoop.hive.ql.Driver.run(Driver.java:906) 
> - locked <0x00002aaac6e1c270> (a java.lang.Object) 
> at org.apache.hive.service.cli.operation.SQLOperation.run(SQLOperation.java:94)
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira