You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by qh...@apache.org on 2015/10/15 05:14:16 UTC
incubator-kylin git commit: minor function name change
Repository: incubator-kylin
Updated Branches:
refs/heads/2.x-staging 41c184811 -> 51e02be50
minor function name change
Project: http://git-wip-us.apache.org/repos/asf/incubator-kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kylin/commit/51e02be5
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kylin/tree/51e02be5
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kylin/diff/51e02be5
Branch: refs/heads/2.x-staging
Commit: 51e02be5000f0583a1b31933f466c292723691ee
Parents: 41c1848
Author: qianhao.zhou <qi...@ebay.com>
Authored: Mon Oct 12 20:17:28 2015 +0800
Committer: qianhao.zhou <qi...@ebay.com>
Committed: Thu Oct 15 11:14:56 2015 +0800
----------------------------------------------------------------------
.../test/java/org/apache/kylin/job/BuildCubeWithStreamTest.java | 2 +-
.../java/org/apache/kylin/cube/inmemcubing/InMemCubeBuilder.java | 2 ++
.../java/org/apache/kylin/source/kafka/KafkaConfigManager.java | 2 +-
3 files changed, 4 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/51e02be5/assembly/src/test/java/org/apache/kylin/job/BuildCubeWithStreamTest.java
----------------------------------------------------------------------
diff --git a/assembly/src/test/java/org/apache/kylin/job/BuildCubeWithStreamTest.java b/assembly/src/test/java/org/apache/kylin/job/BuildCubeWithStreamTest.java
index 964f972..07ab947 100644
--- a/assembly/src/test/java/org/apache/kylin/job/BuildCubeWithStreamTest.java
+++ b/assembly/src/test/java/org/apache/kylin/job/BuildCubeWithStreamTest.java
@@ -93,7 +93,7 @@ public class BuildCubeWithStreamTest {
//Use a random topic for kafka data stream
KafkaConfig streamingConfig = KafkaConfigManager.getInstance(kylinConfig).getKafkaConfig(streamingName);
streamingConfig.setTopic(UUID.randomUUID().toString());
- KafkaConfigManager.getInstance(kylinConfig).saveStreamingConfig(streamingConfig);
+ KafkaConfigManager.getInstance(kylinConfig).saveKafkaConfig(streamingConfig);
DeployUtil.prepareTestDataForStreamingCube(startTime, endTime, config.getCubeName(), streamingConfig);
}
http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/51e02be5/core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/InMemCubeBuilder.java
----------------------------------------------------------------------
diff --git a/core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/InMemCubeBuilder.java b/core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/InMemCubeBuilder.java
index fa998ff..1666fc2 100644
--- a/core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/InMemCubeBuilder.java
+++ b/core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/InMemCubeBuilder.java
@@ -490,7 +490,9 @@ public class InMemCubeBuilder extends AbstractInMemCubeBuilder {
}
// disable sanity check for performance
+ long t = System.currentTimeMillis();
sanityCheck(scanner.getTotalSumForSanityCheck());
+ logger.info("sanity check for Cuboid " + cuboidId + " cost " + (System.currentTimeMillis() - t) + "ms");
} finally {
scanner.close();
builder.close();
http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/51e02be5/source-kafka/src/main/java/org/apache/kylin/source/kafka/KafkaConfigManager.java
----------------------------------------------------------------------
diff --git a/source-kafka/src/main/java/org/apache/kylin/source/kafka/KafkaConfigManager.java b/source-kafka/src/main/java/org/apache/kylin/source/kafka/KafkaConfigManager.java
index be07290..d8f9f50 100644
--- a/source-kafka/src/main/java/org/apache/kylin/source/kafka/KafkaConfigManager.java
+++ b/source-kafka/src/main/java/org/apache/kylin/source/kafka/KafkaConfigManager.java
@@ -115,7 +115,7 @@ public class KafkaConfigManager {
}
}
- public void saveStreamingConfig(KafkaConfig kafkaConfig) throws IOException {
+ public void saveKafkaConfig(KafkaConfig kafkaConfig) throws IOException {
if (kafkaConfig == null || StringUtils.isEmpty(kafkaConfig.getName())) {
throw new IllegalArgumentException();
}