You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/16 04:09:57 UTC
[GitHub] [spark] Yikun opened a new pull request #35869: [SPARK-38561][K8S][DOCS] Add doc for `Customized Kubernetes Schedulers`
Yikun opened a new pull request #35869:
URL: https://github.com/apache/spark/pull/35869
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] holdenk commented on pull request #35869: [SPARK-38561][K8S][DOCS] Add doc for `Customized Kubernetes Schedulers`
Posted by GitBox <gi...@apache.org>.
holdenk commented on pull request #35869:
URL: https://github.com/apache/spark/pull/35869#issuecomment-1069409699
Merged to the current development branch :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] martin-g commented on a change in pull request #35869: [SPARK-38561][K8S][DOCS] Add doc for `Customized Kubernetes Schedulers`
Posted by GitBox <gi...@apache.org>.
martin-g commented on a change in pull request #35869:
URL: https://github.com/apache/spark/pull/35869#discussion_r827681954
##########
File path: docs/running-on-kubernetes.md
##########
@@ -1722,6 +1722,25 @@ spec:
image: will-be-overwritten
```
+#### Customized Kubernetes Schedulers for Spark on Kubernetes
+
+Spark allows users to specify a customized scheduler as Spark on Kubernetes scheduler.
Review comment:
```suggestion
Spark allows users to specify a custom Kubernetes schedulers.
```
##########
File path: docs/running-on-kubernetes.md
##########
@@ -1722,6 +1722,25 @@ spec:
image: will-be-overwritten
```
+#### Customized Kubernetes Schedulers for Spark on Kubernetes
+
+Spark allows users to specify a customized scheduler as Spark on Kubernetes scheduler.
+
+1. Specify scheduler name.
+
+ Users can specify customized scheduler using <code>spark.kubernetes.scheduler.name</code> or
Review comment:
```suggestion
Users can specify a custom scheduler using <code>spark.kubernetes.scheduler.name</code> or
```
##########
File path: docs/running-on-kubernetes.md
##########
@@ -1722,6 +1722,25 @@ spec:
image: will-be-overwritten
```
+#### Customized Kubernetes Schedulers for Spark on Kubernetes
+
+Spark allows users to specify a customized scheduler as Spark on Kubernetes scheduler.
+
+1. Specify scheduler name.
+
+ Users can specify customized scheduler using <code>spark.kubernetes.scheduler.name</code> or
+ <code>spark.kubernetes.{driver/executor}.scheduler.name</code> configuration.
+
+2. Specify scheduler related configurations.
+
+ Users can use [Pod template](#pod-template), existing configurations to specify label (<code>spark.kubernetes.{driver,executor}.label.*</code>), annotations style (<code>spark.kubernetes.{driver/executor}.annotation.*</code>) scheduler hints.
+
+3. Specify scheduler feature step.
+
+ Users may also consider to use <code>spark.kubernetes.{driver/executor}.pod.featureSteps</code> to support more complex requirements and more centralized scheduler hints configure, included but not limited to:
+ - Creating a scheduler needed additional Kubernetes custom resource for driver/executor scheduling.
Review comment:
```suggestion
- Create additional Kubernetes custom resources for driver/executor scheduling.
```
##########
File path: docs/running-on-kubernetes.md
##########
@@ -1722,6 +1722,25 @@ spec:
image: will-be-overwritten
```
+#### Customized Kubernetes Schedulers for Spark on Kubernetes
+
+Spark allows users to specify a customized scheduler as Spark on Kubernetes scheduler.
+
+1. Specify scheduler name.
+
+ Users can specify customized scheduler using <code>spark.kubernetes.scheduler.name</code> or
+ <code>spark.kubernetes.{driver/executor}.scheduler.name</code> configuration.
+
+2. Specify scheduler related configurations.
+
+ Users can use [Pod template](#pod-template), existing configurations to specify label (<code>spark.kubernetes.{driver,executor}.label.*</code>), annotations style (<code>spark.kubernetes.{driver/executor}.annotation.*</code>) scheduler hints.
Review comment:
```suggestion
To configure the custom scheduler the user can use [Pod templates](#pod-template), add labels (<code>spark.kubernetes.{driver,executor}.label.*</code>) and/or annotations (<code>spark.kubernetes.{driver/executor}.annotation.*</code>).
```
##########
File path: docs/running-on-kubernetes.md
##########
@@ -1722,6 +1722,25 @@ spec:
image: will-be-overwritten
```
+#### Customized Kubernetes Schedulers for Spark on Kubernetes
+
+Spark allows users to specify a customized scheduler as Spark on Kubernetes scheduler.
+
+1. Specify scheduler name.
+
+ Users can specify customized scheduler using <code>spark.kubernetes.scheduler.name</code> or
+ <code>spark.kubernetes.{driver/executor}.scheduler.name</code> configuration.
+
+2. Specify scheduler related configurations.
+
+ Users can use [Pod template](#pod-template), existing configurations to specify label (<code>spark.kubernetes.{driver,executor}.label.*</code>), annotations style (<code>spark.kubernetes.{driver/executor}.annotation.*</code>) scheduler hints.
+
+3. Specify scheduler feature step.
+
+ Users may also consider to use <code>spark.kubernetes.{driver/executor}.pod.featureSteps</code> to support more complex requirements and more centralized scheduler hints configure, included but not limited to:
Review comment:
```suggestion
Users may also consider to use <code>spark.kubernetes.{driver/executor}.pod.featureSteps</code> to support more complex requirements, including but not limited to:
```
##########
File path: docs/running-on-kubernetes.md
##########
@@ -1722,6 +1722,25 @@ spec:
image: will-be-overwritten
```
+#### Customized Kubernetes Schedulers for Spark on Kubernetes
+
+Spark allows users to specify a customized scheduler as Spark on Kubernetes scheduler.
+
+1. Specify scheduler name.
+
+ Users can specify customized scheduler using <code>spark.kubernetes.scheduler.name</code> or
+ <code>spark.kubernetes.{driver/executor}.scheduler.name</code> configuration.
+
+2. Specify scheduler related configurations.
+
+ Users can use [Pod template](#pod-template), existing configurations to specify label (<code>spark.kubernetes.{driver,executor}.label.*</code>), annotations style (<code>spark.kubernetes.{driver/executor}.annotation.*</code>) scheduler hints.
+
+3. Specify scheduler feature step.
+
+ Users may also consider to use <code>spark.kubernetes.{driver/executor}.pod.featureSteps</code> to support more complex requirements and more centralized scheduler hints configure, included but not limited to:
+ - Creating a scheduler needed additional Kubernetes custom resource for driver/executor scheduling.
+ - Setting scheduler hints according to configuration or existing Pod info dynamically.
Review comment:
```suggestion
- Set scheduler hints according to configuration or existing Pod info dynamically.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #35869: [SPARK-38561][K8S][DOCS] Add doc for `Customized Kubernetes Schedulers`
Posted by GitBox <gi...@apache.org>.
Yikun commented on pull request #35869:
URL: https://github.com/apache/spark/pull/35869#issuecomment-1077000681
Backport to 3.3: https://github.com/apache/spark/pull/35955
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] asfgit closed pull request #35869: [SPARK-38561][K8S][DOCS] Add doc for `Customized Kubernetes Schedulers`
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #35869:
URL: https://github.com/apache/spark/pull/35869
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org