[jira] [Resolved] (LUCENE-7389) Validation issue in FieldType#setDimensions?

["Martijn van Groningen (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/LUCENE-7389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martijn van Groningen resolved LUCENE-7389.
-------------------------------------------
       Resolution: Fixed
    Fix Version/s: 6.2
                   master (7.0)

Thanks Adrien and Mike!

(accidentally used from issue number in commit message)
Fixed in master: https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9b85f68
and branch_6x: https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=dc54f97

> Validation issue in FieldType#setDimensions?
> --------------------------------------------
>
>                 Key: LUCENE-7389
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7389
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Martijn van Groningen
>             Fix For: master (7.0), 6.2
>
>         Attachments: LUCENE-7383.patch
>
>
> It compares if the {{dimensionCount}} is larger than {{PointValues.MAX_NUM_BYTES}} while this constant should be compared to {{dimensionNumBytes}} instead?
> So this if statement:
> {noformat}
> if (dimensionCount > PointValues.MAX_NUM_BYTES) {
>       throw new IllegalArgumentException("dimensionNumBytes must be <= " + PointValues.MAX_NUM_BYTES + "; got " + dimensionNumBytes);
>     }
> {noformat}
> Should be:
> {noformat}
> if (dimensionNumBytes > PointValues.MAX_NUM_BYTES) {
>       throw new IllegalArgumentException("dimensionNumBytes must be <= " + PointValues.MAX_NUM_BYTES + "; got " + dimensionNumBytes);
>     }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org