You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2025/02/03 20:03:40 UTC
[PR] [branch-45] Fix regression list Type Coercion List with inner type struct which has large/view types (#14385) [datafusion]
alamb opened a new pull request, #14456:
URL: https://github.com/apache/datafusion/pull/14456
- Part of https://github.com/apache/datafusion/issues/14008
- Backport https://github.com/apache/datafusion/pull/14385 to the 45 release branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] [branch-45] Fix regression list Type Coercion List with inner type struct which has large/view types (#14385) [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #14456:
URL: https://github.com/apache/datafusion/pull/14456
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] [branch-45] Fix regression list Type Coercion List with inner type struct which has large/view types (#14385) [datafusion]
Posted by "Omega359 (via GitHub)" <gi...@apache.org>.
Omega359 commented on code in PR #14456:
URL: https://github.com/apache/datafusion/pull/14456#discussion_r1940000285
##########
datafusion/sqllogictest/test_files/case.slt:
##########
@@ -416,5 +416,58 @@ SELECT
end
FROM t;
+statement ok
+drop table t
+
+# Fix coercion of lists of structs
+# https://github.com/apache/datafusion/issues/14154
+
+statement ok
+create or replace table t as values
+(
+ 100, -- column1 int (so the case isn't constant folded)
+ [{ 'foo': arrow_cast('baz', 'Utf8View') }], -- column2 has List of Struct w/ Utf8View
+ [{ 'foo': 'bar' }], -- column3 has List of Struct w/ Utf8
+ [{ 'foo': 'blarg' }] -- column4 has List of Struct w/ Utf8
Review Comment:
wondering if this should be LargeUtf8 for completeness?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] [branch-45] Fix regression list Type Coercion List with inner type struct which has large/view types (#14385) [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #14456:
URL: https://github.com/apache/datafusion/pull/14456#discussion_r1940027464
##########
datafusion/sqllogictest/test_files/case.slt:
##########
@@ -416,5 +416,58 @@ SELECT
end
FROM t;
+statement ok
+drop table t
+
+# Fix coercion of lists of structs
+# https://github.com/apache/datafusion/issues/14154
+
+statement ok
+create or replace table t as values
+(
+ 100, -- column1 int (so the case isn't constant folded)
+ [{ 'foo': arrow_cast('baz', 'Utf8View') }], -- column2 has List of Struct w/ Utf8View
+ [{ 'foo': 'bar' }], -- column3 has List of Struct w/ Utf8
+ [{ 'foo': 'blarg' }] -- column4 has List of Struct w/ Utf8
Review Comment:
Yes, probably.
@Lordworms is working on a follow up here:
- https://github.com/apache/datafusion/issues/14396
I will add a note to that ticket
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org