You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by paulk-asert <gi...@git.apache.org> on 2016/06/12 11:24:54 UTC
[GitHub] groovy pull request #348: Groovy7860
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/348
Groovy7860
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paulk-asert/groovy groovy7860
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/groovy/pull/348.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #348
----
commit 300b976e50550e38c22198fc23812e9605925d5e
Author: paulk <pa...@asert.com.au>
Date: 2016-06-07T11:46:11Z
minor refactor
commit 8823db8eff3912c7b004b483c6804ae29e8786f9
Author: paulk <pa...@asert.com.au>
Date: 2016-06-12T11:23:29Z
GROOVY-7860: Groovy could implement an @AutoImplement transform (closes #348)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] groovy pull request #348: Groovy7860 AutoImplement transform
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/348
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] groovy pull request #348: Groovy7860 AutoImplement transform
Posted by paulk-asert <gi...@git.apache.org>.
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/348#discussion_r68484985
--- Diff: src/main/groovy/transform/Undefined.java ---
@@ -28,6 +28,10 @@
private Undefined() {}
public static final String STRING = "<DummyUndefinedMarkerString-DoNotUse>";
public static final class CLASS {}
+ public static final class UNDEFINED_EXCEPTION extends RuntimeException {
--- End diff --
Changed. Thanks for the suggestion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] groovy pull request #348: Groovy7860 AutoImplement transform
Posted by shils <gi...@git.apache.org>.
Github user shils commented on a diff in the pull request:
https://github.com/apache/groovy/pull/348#discussion_r67703766
--- Diff: src/main/groovy/transform/Undefined.java ---
@@ -28,6 +28,10 @@
private Undefined() {}
public static final String STRING = "<DummyUndefinedMarkerString-DoNotUse>";
public static final class CLASS {}
+ public static final class UNDEFINED_EXCEPTION extends RuntimeException {
--- End diff --
I think it would be more in line with the other Undefined fields if the 'UNDEFINED_' prefix were dropped from the field name e.g. 'EXCEPTION_CLASS' or something to that effect.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---