You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/10 21:42:29 UTC
[GitHub] [arrow-rs] tustvold opened a new pull request, #3085: Remove unused range module
tustvold opened a new pull request, #3085:
URL: https://github.com/apache/arrow-rs/pull/3085
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
This was added by @Ted-Jiang in https://github.com/apache/arrow-rs/pull/1791 but hasn't ever been hooked up. It overlaps sufficiently with the RowSelector logic, that I think it can be removed.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Ted-Jiang commented on pull request #3085: Remove unused range module
Posted by GitBox <gi...@apache.org>.
Ted-Jiang commented on PR #3085:
URL: https://github.com/apache/arrow-rs/pull/3085#issuecomment-1311166487
@tustvold Thanks, It can be removed, I have intended to use bytes offset as input, now use the selection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #3085: Remove unused range module
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3085:
URL: https://github.com/apache/arrow-rs/pull/3085#issuecomment-1311128482
Benchmark runs are scheduled for baseline = 522625814cbb5f22e0b4f60227a397aff71098b5 and contender = 01396822eb68a90565cf8b177aab4b0ce8af40e1. 01396822eb68a90565cf8b177aab4b0ce8af40e1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/f477734a64ed4dc884e414c944b554f7...bb418dd9eb1b45538fd97ba381c03495/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/1a14b9e6de6f44f380002d6d3b173b34...87e569a30b044ea2b57a10d2baa8f209/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/a8d83b5457cd4a06b90b4fdb77e3f104...78b9f82ccd40480695a9d988fb70fe8f/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/ccb5a0b17eb04cf09043e32b1b19c892...685d324342c343938483506624a2220d/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #3085: Remove unused range module
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #3085:
URL: https://github.com/apache/arrow-rs/pull/3085
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on a diff in pull request #3085: Remove unused range module
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #3085:
URL: https://github.com/apache/arrow-rs/pull/3085#discussion_r1019700928
##########
parquet/src/file/page_index/mod.rs:
##########
@@ -17,6 +17,3 @@
pub mod index;
pub mod index_reader;
-
-#[cfg(test)]
-pub(crate) mod range;
Review Comment:
Seems it is only for test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org