You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/05 08:04:53 UTC
[GitHub] [incubator-nuttx-apps] coffee809721232 opened a new pull request #958: netutils/dhcpc: Fix dhcpc lease bug
coffee809721232 opened a new pull request #958:
URL: https://github.com/apache/incubator-nuttx-apps/pull/958
## Summary
netutils/dhcpc: Fix dhcpc lease bug
Signed-off-by: songlinzhang songlinzhang@xiaomi.com
## Impact
dhcpc lease management
## Testing
call dhcpc_request_async
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #958: netutils/dhcpc: Fix dhcpc lease bug
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #958:
URL: https://github.com/apache/incubator-nuttx-apps/pull/958#discussion_r778629324
##########
File path: netutils/dhcpc/dhcpc.c
##########
@@ -458,6 +458,7 @@ static void *dhcpc_run(void *args)
struct dhcpc_state result;
int ret;
+ memset(&result, 0, sizeof(result));
Review comment:
@normanr please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #958: netutils/dhcpc: Fix dhcpc lease bug
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #958:
URL: https://github.com/apache/incubator-nuttx-apps/pull/958#discussion_r778628718
##########
File path: netutils/dhcpc/dhcpc.c
##########
@@ -458,6 +458,7 @@ static void *dhcpc_run(void *args)
struct dhcpc_state result;
int ret;
+ memset(&result, 0, sizeof(result));
Review comment:
If so, should we move into while block to handle the fail in no first loop?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #958: netutils/dhcpc: Fix dhcpc lease bug
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #958:
URL: https://github.com/apache/incubator-nuttx-apps/pull/958#discussion_r778620373
##########
File path: netutils/dhcpc/dhcpc.c
##########
@@ -458,6 +458,7 @@ static void *dhcpc_run(void *args)
struct dhcpc_state result;
int ret;
+ memset(&result, 0, sizeof(result));
Review comment:
why need memset here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #958: netutils/dhcpc: Fix dhcpc lease bug
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #958:
URL: https://github.com/apache/incubator-nuttx-apps/pull/958
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] coffee809721232 commented on a change in pull request #958: netutils/dhcpc: Fix dhcpc lease bug
Posted by GitBox <gi...@apache.org>.
coffee809721232 commented on a change in pull request #958:
URL: https://github.com/apache/incubator-nuttx-apps/pull/958#discussion_r778622368
##########
File path: netutils/dhcpc/dhcpc.c
##########
@@ -458,6 +458,7 @@ static void *dhcpc_run(void *args)
struct dhcpc_state result;
int ret;
+ memset(&result, 0, sizeof(result));
Review comment:
If the first request fails, there may be a delay before the second request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] coffee809721232 commented on a change in pull request #958: netutils/dhcpc: Fix dhcpc lease bug
Posted by GitBox <gi...@apache.org>.
coffee809721232 commented on a change in pull request #958:
URL: https://github.com/apache/incubator-nuttx-apps/pull/958#discussion_r778636018
##########
File path: netutils/dhcpc/dhcpc.c
##########
@@ -458,6 +458,7 @@ static void *dhcpc_run(void *args)
struct dhcpc_state result;
int ret;
+ memset(&result, 0, sizeof(result));
Review comment:
> If so, should we move into while block to handle the fail in no first loop?
Yes, updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org