[jira] Commented: (HIVE-1147) Update Eclipse project configuration to match Checkstyle

["Carl Steinbach (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12833525#action_12833525 ] 

Carl Steinbach commented on HIVE-1147:
--------------------------------------


Changes to Eclipse settings:

* Added Apache Hive Cleanup configuration:
** Remove 'this' qualifier for non static field accesses
** Remove 'this' qualifier for non static method accesses
** Change non static accesses to static members using declaring type
** Change indirect accesses to static members to direct accesses (accesses through subtypes)
** Convert control statement bodies to block
** Convert for loops to enhanced for loops
** Remove unused imports
** Remove unused local variables
** Add missing '@Override' annotations
** Add missing '@Deprecated' annotations
** Remove unnecessary casts
** Remove unnecessary '$NON-NLS$' tags
** Organize imports
** Format source code
** Remove trailing white spaces on all lines
** Correct indentation
* Added Apache Hive Formatter Configuration (default formatter with the following changes):
** Insert new line at end of file.
** Increase code maximum length to 100.
** Increase comment maximum length to 100.
** Never join lines.
** Remove whitespace after opening brace of array initializer.
** Remove whitespace before closing brace of array initializer.
* Added the following save actions:
** Organize imports
** Convert control statement bodies to block
** Add final modifier to private fields.
** Remove unused imports.
** Add missing '@Override' annotations.
** Add missing '@Deprecated' annotations.
** Remove unnecessary casts.
** Remove trailing white spaces on all lines.

* Simplified Checkstyle inclusion/exclusion rules in .checkstyle and build.xml
* Added plaintext Checkstyle output to build.xml
* Added the [IllegalType | http://checkstyle.sourceforge.net/config_coding.html#IllegalType] module the checkstyle configuration.

Please note the following:
* The formatting and cleanup configurations are not applied automatically -- you must explicitly run them.
* The save actions are applied to a file every time it is saved.





> Update Eclipse project configuration to match Checkstyle
> --------------------------------------------------------
>
>                 Key: HIVE-1147
>                 URL: https://issues.apache.org/jira/browse/HIVE-1147
>             Project: Hadoop Hive
>          Issue Type: Task
>            Reporter: Carl Steinbach
>            Assignee: Carl Steinbach
>         Attachments: HIVE-1147.patch
>
>
> We recently made Checkstyle part of the build. We need to update
> the Eclipse project configuration so that it is compatible with Checkstyle.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.