You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by mt...@apache.org on 2007/04/02 14:57:24 UTC
svn commit: r524777 - /tomcat/connectors/trunk/jk/tools/jkrelease.sh
Author: mturk
Date: Mon Apr 2 05:57:24 2007
New Revision: 524777
URL: http://svn.apache.org/viewvc?view=rev&rev=524777
Log:
Do not try to make the release on the hosts where tar doesn't support cfz.
Modified:
tomcat/connectors/trunk/jk/tools/jkrelease.sh
Modified: tomcat/connectors/trunk/jk/tools/jkrelease.sh
URL: http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/tools/jkrelease.sh?view=diff&rev=524777&r1=524776&r2=524777
==============================================================================
--- tomcat/connectors/trunk/jk/tools/jkrelease.sh (original)
+++ tomcat/connectors/trunk/jk/tools/jkrelease.sh Mon Apr 2 05:57:24 2007
@@ -193,8 +193,7 @@
cd ../../
# Pack and sign
-tar cvf ${JK_DIST}.tar --owner="${JK_OWNER}" --group="${JK_GROUP}" ${JK_DIST}
-gzip ${JK_DIST}.tar
+tar cfz ${JK_DIST}.tar.gz ${JK_DIST}
perl ${JK_DIST}/tools/lineends.pl --cr ${JK_DIST}
zip -9 -r ${JK_DIST}.zip ${JK_DIST}
# Create detatched signature
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r524777 - /tomcat/connectors/trunk/jk/tools/jkrelease.sh
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Mladen Turk wrote:
> Rainer Jung wrote:
>> Hi Mladen,
>>
>> did you delete setting owner and group by accident from the release
>> script?
>>
>
> No, I did it by purpose. I don't have user or group named asf, so the tar
> fails. What would be a purpose of it anyhow, and how would you ensure
> that the same user will exist on the users box?
It should be root / bin or similar.
Simple - if you unpack without root privilage, it unpacks as 'you'.
If 'you' == root, it would try to restore mladen:staff or whatever your
group is. Please back out this change and make an appropriate change :)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r524777 - /tomcat/connectors/trunk/jk/tools/jkrelease.sh
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Mladen Turk wrote:
> Rainer Jung wrote:
>> OK, I forgot, that I actually had a user and group named asf (I
>> thought tar would ignore their non-existance).
>>
>> All in all I would suggest root:bin to.
>
> I used root:users instead.
> Think the users group exists on all *nixes.
So does bin. users has a radically different connotation, that if you
change the perms to 664, everyone on the box has access to the unpacked
file, depending on your umask etc. Sounds very dangerous to me.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r524777 - /tomcat/connectors/trunk/jk/tools/jkrelease.sh
Posted by Mladen Turk <mt...@apache.org>.
>>
>> All in all I would suggest root:bin to.
>>
> I used root:users instead.
> Think the users group exists on all *nixes.
>
Hmm, it doesn't after all :(
Switching to suggested root/bin
Regards,
Mladen.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r524777 - /tomcat/connectors/trunk/jk/tools/jkrelease.sh
Posted by Mladen Turk <mt...@apache.org>.
Rainer Jung wrote:
> OK, I forgot, that I actually had a user and group named asf (I thought
> tar would ignore their non-existance).
>
> All in all I would suggest root:bin to.
>
I used root:users instead.
Think the users group exists on all *nixes.
Regards,
Mladen.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r524777 - /tomcat/connectors/trunk/jk/tools/jkrelease.sh
Posted by Rainer Jung <ra...@kippdata.de>.
OK, I forgot, that I actually had a user and group named asf (I thought
tar would ignore their non-existance).
But I agree with William, that we should instead use a general purpose
user and group exactly because of the reasons given by him.
If a non-root user extracts the tarball, his ownership will be used, but
many people unfortunately do it as root, because of the final
installation steps and the end up with files created by root but owned
by some foreign user/group which might exist on their local system. I
never liked tarballs, which generated strange user ids when extracting them.
root as the user sounds like a plausible default, bin as a group will
work on most *nix systems (I shortly checked Solaris, SuSE Linux and
people.apache.org), although the ideas what bin is used for seem to vary
a lot. All in all I would suggest root:bin to.
Regards,
Rainer
Mladen Turk wrote:
> Rainer Jung wrote:
>> Hi Mladen,
>>
>> did you delete setting owner and group by accident from the release
>> script?
>>
>
> No, I did it by purpose. I don't have user or group named asf, so the tar
> fails. What would be a purpose of it anyhow, and how would you ensure
> that the same user will exist on the users box?
>
> Regards,
> Mladen.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r524777 - /tomcat/connectors/trunk/jk/tools/jkrelease.sh
Posted by Mladen Turk <mt...@apache.org>.
Rainer Jung wrote:
> Hi Mladen,
>
> did you delete setting owner and group by accident from the release script?
>
No, I did it by purpose. I don't have user or group named asf, so the tar
fails. What would be a purpose of it anyhow, and how would you ensure
that the same user will exist on the users box?
Regards,
Mladen.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r524777 - /tomcat/connectors/trunk/jk/tools/jkrelease.sh
Posted by Rainer Jung <ra...@kippdata.de>.
Hi Mladen,
did you delete setting owner and group by accident from the release script?
mturk@apache.org schrieb:
>
> # Pack and sign
> -tar cvf ${JK_DIST}.tar --owner="${JK_OWNER}" --group="${JK_GROUP}" ${JK_DIST}
> -gzip ${JK_DIST}.tar
> +tar cfz ${JK_DIST}.tar.gz ${JK_DIST}
> perl ${JK_DIST}/tools/lineends.pl --cr ${JK_DIST}
> zip -9 -r ${JK_DIST}.zip ${JK_DIST}
Regards,
Rainer
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org