You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (JIRA)" <ji...@apache.org> on 2014/04/03 21:15:18 UTC

[jira] [Created] (LUCENE-5570) FSDirectory's fsync() is lenient

Robert Muir created LUCENE-5570:
-----------------------------------

             Summary: FSDirectory's fsync() is lenient
                 Key: LUCENE-5570
                 URL: https://issues.apache.org/jira/browse/LUCENE-5570
             Project: Lucene - Core
          Issue Type: Bug
          Components: core/store
            Reporter: Robert Muir


This method has a lot of problems:
1. it tracks 'stale files' as it writes (this seems pointless), and only actually fsyncs the intersection of that 'stale files' and the filenames passed as argument to sync(). So any bogus names passed to sync() are just silently ignored
2. if "something bad happens" (e.g. two indexwriters/dirs on the same path, or some other shenanigans), and the file is actually in stale files, but was say actually deleted on the filesystem, the underlying fsync() call will create a new 0-byte file and fsync that.

In my opinion we should do none of this. we should throw exceptions when this stuff is wrong.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org