You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@aurora.apache.org by "Juan Manuel Fresia (JIRA)" <ji...@apache.org> on 2018/01/18 14:58:00 UTC
[jira] [Resolved] (AURORA-1963) Structdump endpoint shows thrift
metadata
[ https://issues.apache.org/jira/browse/AURORA-1963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Juan Manuel Fresia resolved AURORA-1963.
----------------------------------------
Resolution: Fixed
Fix Version/s: 0.20.0
Patched with commit from review [65076|https://reviews.apache.org/r/65076/]
> Structdump endpoint shows thrift metadata
> -----------------------------------------
>
> Key: AURORA-1963
> URL: https://issues.apache.org/jira/browse/AURORA-1963
> Project: Aurora
> Issue Type: Bug
> Components: Scheduler
> Affects Versions: 0.19.0
> Environment: Devcluster VM
> Reporter: Juan Manuel Fresia
> Priority: Minor
> Labels: patch
> Fix For: 0.20.0
>
>
> The structdump endpoint changed the way it displays the task config. This change made some thrift internal metadata visible, such as {{__isset_bitfield}} on optionals fields and appending underscores on the names of other fields.
> For example, here is a fragment of a 0.19 structdump output:
> {code}
> "timestamp": 1514573549125,
> "status": "RUNNING",
> "scheduler": "ee5feaf3d8b1",
> "__isset_bitfield": 1,
> "optionals": [
> "MESSAGE",
> "SCHEDULER"
> ]
> {code}
> And here is the same fragment, but with 0.18 scheduler:
> {code}
> Item[2] =
> timestamp: 1514574966299
> status: RUNNING
> message: not set
> scheduler: "84611e03fe9e"
> {code}
> As the structdump is the only way to get the full configuration of a task through the UI, it is inconvenient to have those fields and naming messing around.
> The issue seems to be caused by a change in the way data taken from thrift is converted to be pretty printed; by changing a thrift specific converter to a GSON serializer. The proposed fix is to backport the old converter and restore the old structdump style.
> The review of the change related to the issue is [here|https://reviews.apache.org/r/63418/diff/3#16]
> The old pretty print utility used in 0.18 is [here|https://github.com/apache/aurora/blob/87eb8914b3d79a0d27a91c50cc7070970e47abf9/commons/src/main/java/org/apache/aurora/common/thrift/Util.java]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)