You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "snazy (via GitHub)" <gi...@apache.org> on 2025/01/15 07:57:29 UTC
[I] Generated files in `regtests/client/python/polaris` [polaris]
snazy opened a new issue, #755:
URL: https://github.com/apache/polaris/issues/755
### Describe the bug
The Python client sources in `regtests/client/python/polaris/` contain generated files, which do not seem to be in sync with the definitions in `spec/`.
Generated files _can_ be in that source tree, but should
a) be `.gitignore`d and
b) be (automatically) generated
### To Reproduce
_No response_
### Actual Behavior
_No response_
### Expected Behavior
_No response_
### Additional context
_No response_
### System information
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Generated files in `regtests/client/python/polaris` [polaris]
Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard commented on issue #755:
URL: https://github.com/apache/polaris/issues/755#issuecomment-2791765647
I have a draft PR, #1347, that introduces a script to do the code generation and fixes some of the aforementioned issues with the generated code. If that ends up working, I believe we can eventually remove the generated code from the repo and use the script to generate it at build time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Generated files in `regtests/client/python/polaris` [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on issue #755:
URL: https://github.com/apache/polaris/issues/755#issuecomment-2917751192
Remove the blocker tag, as #1347 has been merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Generated files in `regtests/client/python/polaris` [polaris]
Posted by "HonahX (via GitHub)" <gi...@apache.org>.
HonahX closed issue #755: Generated files in `regtests/client/python/polaris`
URL: https://github.com/apache/polaris/issues/755
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Generated files in `regtests/client/python/polaris` [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on issue #755:
URL: https://github.com/apache/polaris/issues/755#issuecomment-2722104785
Per this doc, https://github.com/apache/polaris/blob/9425a6e0cb5febc3fa0ec06cfed0294700ce701c/regtests/client/python/README.md?plain=1#L24, these python code is auto-generated. We may just need to exclude them in the repo by putting them in `.gitignore`.
cc @eric-maynard
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Generated files in `regtests/client/python/polaris` [polaris]
Posted by "rakesh-das08 (via GitHub)" <gi...@apache.org>.
rakesh-das08 commented on issue #755:
URL: https://github.com/apache/polaris/issues/755#issuecomment-2745057702
@flyrain -> when i am checking the mentioned folder, i see all the files are generated except for : apache/polaris/regtests/client/python/polaris/catalog/api_response.py
Also could not find it in spec/polaris-catalog-service.yaml or spec/polaris-management-service.yaml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Generated files in `regtests/client/python/polaris` [polaris]
Posted by "collado-mike (via GitHub)" <gi...@apache.org>.
collado-mike commented on issue #755:
URL: https://github.com/apache/polaris/issues/755#issuecomment-2758947102
Unfortunately, the client files are checked in because there was a small customization needed in the AWSStorageConfig code. I never figured out how to correct the error in the generated code, so I manually fixed it and checked it in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Generated files in `regtests/client/python/polaris` [polaris]
Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard commented on issue #755:
URL: https://github.com/apache/polaris/issues/755#issuecomment-2777679800
I think that's correct @rakesh-das08, if you were to regenerate the files right now you would see some changes and in fact I think some things would break. That's what happened last time I tried it, at least. Being the change needed in the AWS code, IIRC the licenses got removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Generated files in `regtests/client/python/polaris` [polaris]
Posted by "rakesh-das08 (via GitHub)" <gi...@apache.org>.
rakesh-das08 commented on issue #755:
URL: https://github.com/apache/polaris/issues/755#issuecomment-2763194587
@collado-mike sorry so let me check if my understanding is correct. Are we saying that right now we have some code that has been manually added and is not part of the generated code and due to that right now we cannot ignore these files ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org