[GitHub] [kyuubi] turboFei commented on a diff in pull request #4984: [KYUUBI #4843] Support multiple kubernetes contexts and namespaces

["turboFei (via GitHub)" <gi...@apache.org>]

turboFei commented on code in PR #4984:
URL: https://github.com/apache/kyuubi/pull/4984#discussion_r1237912054


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/metadata/api/Metadata.scala:
##########
@@ -66,6 +68,8 @@ case class Metadata(
     createTime: Long = 0L,
     engineType: String = null,
     clusterManager: Option[String] = None,
+    kubernetesContext: Option[String] = None,
+    kubernetesNamespace: Option[String] = None,

Review Comment:
   Good idea



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org