You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/01/14 21:38:25 UTC
[GitHub] [spark] parthchandra commented on a change in pull request #35212: [SPARK-37912][SQL][TESTS] Add benchmark for vectorized delta binary packed encoding
parthchandra commented on a change in pull request #35212:
URL: https://github.com/apache/spark/pull/35212#discussion_r785184992
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRebaseDatetimeSuite.scala
##########
@@ -260,25 +260,25 @@ abstract class ParquetRebaseDatetimeSuite
}
withAllParquetReaders {
- // The file metadata indicates if it needs rebase or not, so we can always get
- // the correct result regardless of the "rebase mode" config.
+ // The file metadata indicates if it needs rebase or not, so we can always get
+ // the correct result regardless of the "rebase mode" config.
runInMode(inReadConf, Seq(LEGACY, CORRECTED, EXCEPTION)) { options =>
checkAnswer(
- spark.read.options(options).parquet(path).select($"ts".cast("string")),
- Seq.tabulate(N)(_ => Row(tsStr)))
+ spark.read.options(options).parquet(path).select($"ts".cast("string")),
+ Seq.tabulate(N)(_ => Row(tsStr)))
}
// Force to not rebase to prove the written datetime values are rebased
// and we will get wrong result if we don't rebase while reading.
withSQLConf("spark.test.forceNoRebase" -> "true") {
checkAnswer(
- spark.read.parquet(path).select($"ts".cast("string")),
- Seq.tabulate(N)(_ => Row(nonRebased)))
- }
- }
+ spark.read.parquet(path).select($"ts".cast("string")),
+ Seq.tabulate(N)(_ => Row(nonRebased)))
}
}
}
+ }
+ }
Review comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org